Re: Review Request 126037: Drop setuid of `kcheckpass`/Use LIBEXEC_INSTALL_DIR wherever appropriate

> On Nov. 12, 2015, 12:46 a.m., David Edmundson wrote: > > pretty sure this breaks slackware > > > > might have to make it an option yes it breaks slackware and probably also BSDs. So -2 on this approach. - Martin --- This is an automa

Re: Review Request 126037: Drop setuid of `kcheckpass`/Use LIBEXEC_INSTALL_DIR wherever appropriate

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126037/#review88275 --- pretty sure this breaks slackware might have to make it an op

Review Request 126037: Drop setuid of `kcheckpass`/Use LIBEXEC_INSTALL_DIR wherever appropriate

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126037/ --- Review request for Plasma, Bhushan Shah and Martin Gräßlin. Repository: k

Re: Review Request 126036: Update wallpaper package with plasma 5.5 wallpaper contest

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126036/#review88274 --- I can't seem to create folders so I'll post my feedback here w

Re: Review Request 126036: Update wallpaper package with plasma 5.5 wallpaper contest

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126036/#review88272 --- This lists a file: Tauplitz/contents/images/Untitled.jpg

Review Request 126036: Update wallpaper package with plasma 5.5 wallpaper contest

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126036/ --- Review request for Plasma. Repository: plasma-workspace-wallpapers Desc

Re: Review Request 126027: Port Kickoff to the Kicker backend

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126027/ --- (Updated Nov. 11, 2015, 9 p.m.) Review request for Plasma and Ivan Čukić.

Re: Review Request 126027: Port Kickoff to the Kicker backend

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126027/ --- (Updated Nov. 11, 2015, 8:51 p.m.) Review request for Plasma and Ivan Čuk

Re: Review Request 126027: Port Kickoff to the Kicker backend

> On Nov. 11, 2015, 5:16 p.m., David Edmundson wrote: > > applets/kicker/plugin/appsmodel.cpp, line 322 > > > > > > favoritesModel needs to refresh too Good catch (RootModel handles this, and AppsModel wasn't us

Re: Review Request 126027: Port Kickoff to the Kicker backend

> On Nov. 11, 2015, 4:03 p.m., David Edmundson wrote: > > FYI you can force push with > > > > git push origin :myBranch (to delete it) > > git push myBranch > > > > so it's a delete and replace with the same name, rather than a "force push" > > but it has the same net effect > > > > another

Re: Review Request 126027: Port Kickoff to the Kicker backend

> On Nov. 11, 2015, 4:03 p.m., David Edmundson wrote: > > FYI you can force push with > > > > git push origin :myBranch (to delete it) > > git push myBranch > > > > so it's a delete and replace with the same name, rather than a "force push" > > but it has the same net effect > > > > another

Re: Review Request 126031: [appletinterface] Allow specifying separate toolTipIcon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126031/#review88264 --- I like the applet previews in widget explorer but making them

Re: Review Request 126010: [digital-clock] Split the Calendar config stuff to it's own category + load the plugins configs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126010/ --- (Updated Nov. 11, 2015, 8:58 p.m.) Review request for Plasma. Changes -

Re: Review Request 125951: [calendar] Move the plugins handling to a separate class

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125951/ --- (Updated Nov. 11, 2015, 8:54 p.m.) Review request for KDE Frameworks and

Review Request 126031: [appletinterface] Allow specifying separate toolTipIcon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126031/ --- Review request for Plasma. Repository: plasma-framework Description ---

Review Request 126032: [CompactApplet] Set tooltipIcon for tooltip

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126032/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 126027: Port Kickoff to the Kicker backend

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126027/#review88260 --- applets/kicker/plugin/appsmodel.cpp (line 322)

Re: Review Request 126027: Port Kickoff to the Kicker backend

> On Nov. 11, 2015, 5:03 p.m., David Edmundson wrote: > > FYI you can force push with > > > > git push origin :myBranch (to delete it) > > git push myBranch > > > > so it's a delete and replace with the same name, rather than a "force push" > > but it has the same net effect > > > > another

Re: Review Request 126027: Port Kickoff to the Kicker backend

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126027/#review88259 --- FYI you can force push with git push origin :myBranch (to de

Re: Review Request 126027: Port Kickoff to the Kicker backend

> On Nov. 11, 2015, 2:38 p.m., David Edmundson wrote: > > applets/kicker/plugin/computermodel.cpp, line 83 > > > > > > return QSortFilterProxyModel::lessThan() > > > > I dont't think you can rely on it fo

Re: Review Request 126016: fix: properly recognise Plasma 5 KCM modules (wmClass=kcmshell5)

> On Nov. 11, 2015, 8:14 a.m., Martin Gräßlin wrote: > > personal comment from X world: this is horrible, horrible ;-) What we > > should try is to make the desktop file available to the window. With KF > > 5.16 we will have all that's needed available. Let's try to improve this in > > Plasma

Re: Review Request 126027: Port Kickoff to the Kicker backend

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126027/ --- (Updated Nov. 11, 2015, 3:28 p.m.) Review request for Plasma and Ivan Čuk

Re: Review Request 126027: Port Kickoff to the Kicker backend

> On Nov. 11, 2015, 2:38 p.m., David Edmundson wrote: > > applets/kicker/plugin/computermodel.cpp, line 264 > > > > > > why do this? trigger is virtual But it's not const, while QModelIndex::model() is, and I do

Re: Review Request 126025: Require Frameworks 5.16

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126025/ --- (Updated Nov. 11, 2015, 2:46 p.m.) Status -- This change has been ma

Re: Review Request 126021: Destroy allowed client in WaylandServer::stop

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126021/ --- (Updated Nov. 11, 2015, 2:45 p.m.) Status -- This change has been ma

Re: Review Request 126027: Port Kickoff to the Kicker backend

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126027/#review88252 --- Got halfway... applets/kicker/plugin/computermodel.cpp (line

Re: Review Request 126016: fix: properly recognise Plasma 5 KCM modules (wmClass=kcmshell5)

> On Nov. 11, 2015, 7:14 a.m., Martin Gräßlin wrote: > > personal comment from X world: this is horrible, horrible ;-) What we > > should try is to make the desktop file available to the window. With KF > > 5.16 we will have all that's needed available. Let's try to improve this in > > Plasma

Re: Review Request 126016: fix: properly recognise Plasma 5 KCM modules (wmClass=kcmshell5)

> On Nov. 11, 2015, 7:14 a.m., Martin Gräßlin wrote: > > libtaskmanager/taskitem.cpp, line 627 > > > > > > don't we have to change to kdeinit5 here? No. The commandline is /path/used/to/launch/kcmshell5 style. T

Re: Review Request 126012: Fix crash if context gets unrefd

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126012/ --- (Updated Nov. 11, 2015, 12:37 p.m.) Status -- This change has been m

Review Request 126027: Port Kickoff to the Kicker backend

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126027/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 126025: Require Frameworks 5.16

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126025/#review88250 --- Ship it! Ship It! - David Edmundson On Nov. 11, 2015, 10:2

Re: Review Request 126025: Require Frameworks 5.16

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126025/#review88247 --- +1 for me bumping the dependency of workspace now. for me go a

Re: Review Request 126022: [ksmserver] Add a dedicated --no-lockscreen command line option

On Wednesday, November 11, 2015 3:45:53 PM CET Bhushan Shah wrote: > I kinda don't like idea of the command line option.. For instance if > someone uses this option on X11 they are lift without lockscreen.. Any > other solution possible? I don't think that is an actual threat. This requires modify

Review Request 126025: Require Frameworks 5.16

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126025/ --- Review request for Plasma. Repository: kde-cli-tools Description --

Re: Review Request 126021: Destroy allowed client in WaylandServer::stop

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126021/#review88245 --- Ship it! Ship It! - Bhushan Shah On Nov. 11, 2015, 2:08 p.

Re: Review Request 126022: [ksmserver] Add a dedicated --no-lockscreen command line option

I kinda don't like idea of the command line option.. For instance if someone uses this option on X11 they are lift without lockscreen.. Any other solution possible? Ideally ksmserver should just retire in Wayland world imo and other functionality of it should be split out of it.. On Nov 11, 2015 2

Re: Review Request 126016: fix: properly recognise Plasma 5 KCM modules (wmClass=kcmshell5)

> On Nov. 11, 2015, 7:14 a.m., Martin Gräßlin wrote: > > personal comment from X world: this is horrible, horrible ;-) What we > > should try is to make the desktop file available to the window. With KF > > 5.16 we will have all that's needed available. Let's try to improve this in > > Plasma

Review Request 126022: [ksmserver] Add a dedicated --no-lockscreen command line option

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126022/ --- Review request for Plasma and Bhushan Shah. Repository: plasma-workspace

Review Request 126021: Destroy allowed client in WaylandServer::stop

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126021/ --- Review request for Plasma and Bhushan Shah. Repository: kscreenlocker D