Re: Review Request 124702: Set component display name for all actions

2015-08-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124702/#review83721 --- As the review is for master: please remember that this must go

Re: Review Request 124697: Make Wayland a hard build time dependency

2015-08-11 Thread Martin Gräßlin
> On Aug. 11, 2015, 6:45 p.m., Thomas Lübking wrote: > > abstract_client.cpp, line 519 > > > > > > Why are these functions in AbstractClient itfp.? Looks like > > shell-client-only feature. No, we also need to

[Powerdevil] [Bug 351209] Brightness setting for "On Battery" works only for a very low brightness level

2015-08-11 Thread a.pronobis
https://bugs.kde.org/show_bug.cgi?id=351209 --- Comment #3 from a.prono...@gmail.com --- In my case it will not be lowered. When I said that there is a dependency between the AC and battery brightness, I meant that AC brightness level has to be sth like 10 times larger than the battery brightness

[Powerdevil] [Bug 351209] Brightness setting for "On Battery" works only for a very low brightness level

2015-08-11 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=351209 Kai Uwe Broulik changed: What|Removed |Added CC||k...@privat.broulik.de Resolution|---

[Powerdevil] [Bug 351209] Brightness setting for "On Battery" works only for a very low brightness level

2015-08-11 Thread a.pronobis
https://bugs.kde.org/show_bug.cgi?id=351209 --- Comment #1 from a.prono...@gmail.com --- It also seems that the max level for which brightness will still be adjusted depends on the screen brightness when AC is unplugged. Example: If I lower the brightness using Fn keys before unplugging, the brigh

[Powerdevil] [Bug 351209] New: Brightness setting for "On Battery" works only for a very low brightness level

2015-08-11 Thread a.pronobis
https://bugs.kde.org/show_bug.cgi?id=351209 Bug ID: 351209 Summary: Brightness setting for "On Battery" works only for a very low brightness level Product: Powerdevil Version: 5.3.90 Platform: Ubuntu Packages

phabricator setup for Plasma Mobile: task tracking

2015-08-11 Thread Sebastian Kügler
Hi all, Some news on the phabricator setup for Plasma Mobile. We want to use phabricator here to track tasks, designs and patch review. Task tracking Phabricator has so-called Workboards, these are kanban-style board which can contain tasks. The board has 4 columns, and tasks move from left to

Re: Review Request 124702: Set component display name for all actions

2015-08-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124702/#review83718 --- Ship it! Ship It! - David Edmundson On Aug. 11, 2015, 8:56

Review Request 124702: Set component display name for all actions

2015-08-11 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124702/ --- Review request for Plasma and Martin Gräßlin. Repository: plasma-desktop

Re: Plasma Mobile Vision, intended personas & meeting notes

2015-08-11 Thread Thomas Pfeiffer
On Tuesday 11 August 2015 11:13:57 Sebastian Kügler wrote: > > Some minor things: > > > > It provides a seamless experience across multiple devices. > > > > I guess your primarily mean devices running other Plasma "Experiences" > > (Desktop / PMC / whatever the future brings) > > Or do you want t

Re: Review Request 124675: Fix Bug 311991 - Taskbar buttons for minimized apps should not use disabled state

2015-08-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124675/#review83715 --- ok, well lets follow the designers in that bug report. *If* t

Re: Review Request 124675: Fix Bug 311991 - Taskbar buttons for minimized apps should not use disabled state

2015-08-11 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124675/ --- (Updated Aug. 11, 2015, 5:14 p.m.) Review request for Plasma. Changes -

Re: Review Request 124697: Make Wayland a hard build time dependency

2015-08-11 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124697/#review83711 --- Generally fine with the change, but some present oddities were

Re: Review Request 124469: ConsoleKit2 support for screenlocker

2015-08-11 Thread Eric Koegel
> On Aug. 10, 2015, 2:12 p.m., David Edmundson wrote: > > Ship It! Thanks for the review. I don't have push rights, would you mind doing that for me? Thanks! - Eric --- This is an automatically generated e-mail. To reply, visit: https:

Re: Plasma Mobile Vision, intended personas & meeting notes

2015-08-11 Thread Andrew Lake
Ten thumbs up! (just need 4 more people to get to ten thumbs) So exciting, Andrew On Mon, Aug 10, 2015, 1:01 PM Jens Reuterberg wrote: PRESENT: Ivan, Sebas, Thomas and Jens MEETING GOAL: write up a vision statement for Plasma Mobile and talk about the early work of the Plasma Mobile HIG and de

Review Request 124697: Make Wayland a hard build time dependency

2015-08-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124697/ --- Review request for kwin and Plasma. Repository: kwin Description --

Re: Plasma Mobile Vision, intended personas & meeting notes

2015-08-11 Thread Michael Bohlender
> > > Also, don't confuse the vision statement with a marketing product vision. > The > vision statement is mainly inward-facing, so we can look at it and measure > our > deeds against it, not so much outward-facing. For marketing and > communication, > we'd likely reword these things slightly, eit

Re: [kubuntu-devel] Re: git moves

2015-08-11 Thread Jonathan Riddell
On Tue, Aug 11, 2015 at 01:18:20PM +0200, Valentin Rusu wrote: > * Jonathan Riddell [2015-08-05 18:11:56 +0200]: > > > some changes to pkg-kde git today: > > > > I added kwallet-pam to plasma > > > > Why not include the kwallet-pam module in the kwallet framework? The > src/runtime would be th

Re: Review Request 124694: Drop build option KWIN_PLASMA_ACTIVE

2015-08-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124694/ --- (Updated Aug. 11, 2015, 11:22 a.m.) Status -- This change has been m

Re: Review Request 124694: Drop build option KWIN_PLASMA_ACTIVE

2015-08-11 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124694/#review83700 --- Ship it! Ship It! - Sebastian Kügler On Aug. 11, 2015, 6:5

Re: Review Request 124625: Filter out non-desktop formfactors in Kickoff's application model

2015-08-11 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124625/ --- (Updated Aug. 11, 2015, 11:17 a.m.) Status -- This change has been m

Re: Plasma Mobile Vision, intended personas & meeting notes

2015-08-11 Thread Sebastian Kügler
On Tuesday, August 11, 2015 01:09:15 Michael Bohlender wrote: > Great work guys! > I love the part about privacy and I can identify with the rest of the > vision. Cool, thanks for reading it critically and for the feedback. > Some minor things: > > It provides a seamless experience across multip

Re: Review Request 124633: Parse formfactor in KService and KPluginInfo

2015-08-11 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124633/ --- (Updated Aug. 11, 2015, 11:05 a.m.) Status -- This change has been m

Re: Review Request 124625: Filter out non-desktop formfactors in Kickoff's application model

2015-08-11 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124625/#review83698 --- Ship it! Ship It! - Kai Uwe Broulik On Aug. 5, 2015, 9 nac

Re: Review Request 124633: Parse formfactor in KService and KPluginInfo

2015-08-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124633/#review83697 --- Ship it! - David Faure On Aug. 5, 2015, 10:41 p.m., Sebasti

Re: Review Request 124633: Parse formfactor in KService and KPluginInfo

2015-08-11 Thread Sebastian Kügler
> On Aug. 6, 2015, 7:13 a.m., David Faure wrote: > > If the goal is to query this property for the K menu for instance, aren't > > you missing an accessor in KService? OK, on the other hand, if this is the > > only user, then property("...") would do too, but still, compile-time > > checking i

Re: Review Request 124625: Filter out non-desktop formfactors in Kickoff's application model

2015-08-11 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124625/#review83696 --- If there are no more issues, I'd like to ship this. - Sebasti

Re: Review Request 124692: Add new entities for sebas and plasma-pa

2015-08-11 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124692/ --- (Updated Aug. 11, 2015, 10:51 a.m.) Status -- This change has been m

Plasma 5.4 beta out now

2015-08-11 Thread Jonathan Riddell
9 days until final tag https://www.kde.org/announcements/plasma-5.3.95.php Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124695: Drop build option KWIN_BUILD_EGL

2015-08-11 Thread Thomas Lübking
> On Aug. 11, 2015, 9:10 vorm., Thomas Lübking wrote: > > Two notes: > > a) no idea how epoxy works, but it doesn't link any GL library itself here > > (it's an epoxy build time dependency, though) > > b) fglrx doesn't support EGL - though rather irrelevant since EGL from MESA > > will just be

Re: Review Request 124695: Drop build option KWIN_BUILD_EGL

2015-08-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124695/ --- (Updated Aug. 11, 2015, 9:16 a.m.) Status -- This change has been ma

Re: Review Request 124695: Drop build option KWIN_BUILD_EGL

2015-08-11 Thread Martin Gräßlin
> On Aug. 11, 2015, 11:10 a.m., Thomas Lübking wrote: > > Two notes: > > a) no idea how epoxy works, but it doesn't link any GL library itself here > > (it's an epoxy build time dependency, though) > > b) fglrx doesn't support EGL - though rather irrelevant since EGL from MESA > > will just be

Re: Review Request 124694: Drop build option KWIN_PLASMA_ACTIVE

2015-08-11 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124694/#review83692 --- Ship it! and, most important, you can still turn off the part

Re: Review Request 124695: Drop build option KWIN_BUILD_EGL

2015-08-11 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124695/#review83690 --- Ship it! Two notes: a) no idea how epoxy works, but it doesn'

Review Request 124695: Drop build option KWIN_BUILD_EGL

2015-08-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124695/ --- Review request for kwin and Plasma. Repository: kwin Description --

Re: Review Request 124692: Add new entities for sebas and plasma-pa

2015-08-11 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124692/#review83686 --- Ship it! Please ensure with David Faure that this can stlk go