Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 95 - Failure!

2015-07-21 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/95/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 22 Jul 2015 06:37:29 + Build duration: 4 min 2 sec CHANGE SET Revision 19da19c9ae6a00fdf60117ec1a2f9bd

Re: Review Request 122488: Improved calendar navigation

2015-07-21 Thread Bernhard Friedreich
> On Mai 21, 2015, 5:24 nachm., Martin Klapetek wrote: > > Bump. Can we get this in for 5.4? > > Marco Martin wrote: > ugh, i almost forgot about this... > yes please Just tested the patch. Working beautifully for me from a user perspective :) - Bernhard

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 87 - Failure!

2015-07-21 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/87/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 21 Jul 2015 21:20:14 + Build duration: 11 min CHANGE SET Revision 9e6dd77ecfc2286d3d4278e700a382cc94cc45

Re: Review Request 124415: Don't crash when OSD QML file is invalid

2015-07-21 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124415/#review82787 --- Ship it! shell/osd.cpp (lines 146 - 148)

Re: Review Request 124394: Timer: trying to fix missing translation in config file (not working)

2015-07-21 Thread Martin Klapetek
> On July 19, 2015, 6:51 p.m., Kai Uwe Broulik wrote: > > What about just leaving the default an empty string and then do a fallback > > on the QML side? > > Bernhard Friedreich wrote: > that should be possible yes.. but shouldn't it also work like this? > > Martin Klapetek wrote: > I

Re: Review Request 124394: Timer: trying to fix missing translation in config file (not working)

2015-07-21 Thread Bernhard Friedreich
> On Juli 19, 2015, 4:51 nachm., Kai Uwe Broulik wrote: > > What about just leaving the default an empty string and then do a fallback > > on the QML side? > > Bernhard Friedreich wrote: > that should be possible yes.. but shouldn't it also work like this? > > Martin Klapetek wrote: >

Review Request 124415: Don't crash when OSD QML file is invalid

2015-07-21 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124415/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 124408: Make PlasmaCore.Dialog opacity work

2015-07-21 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124408/ --- (Updated July 21, 2015, 8:29 p.m.) Status -- This change has been ma

[Breeze] [Bug 350434] SDDM theme does not use Breeze user icons

2015-07-21 Thread Markus S .
https://bugs.kde.org/show_bug.cgi?id=350434 --- Comment #3 from Markus S. --- (In reply to David Edmundson from comment #2) > This path overridable in sddm.conf Why not then make the KCM change the path on theme change? Would this also fix displaying custom per-user icons set in System Settings

Jenkins-kde-ci: plasma-desktop Plasma-5.3 stable-kf5-qt5 » Linux,gcc - Build # 5 - Still Failing!

2015-07-21 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.3%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/5/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 21 Jul 2015 16:50:13 + Build duration: 7 min 9 sec CHANGE SET Revision 6706161541c147bc600cdde

Re: Review Request 124374: custom inline edit menu for plasma controls

2015-07-21 Thread Andrew Lake
> On July 21, 2015, 4:20 p.m., Andrew Lake wrote: > > Very nice. A couple questions: > > 1. Are the inline selectiion handles grab-able? I assume yes. > > 2. Does this automatically appear when a selection is made or on > > right-click? I assume the former. > > > > It would eventually be nice t

Re: Review Request 124374: custom inline edit menu for plasma controls

2015-07-21 Thread Marco Martin
> On July 21, 2015, 4:20 p.m., Andrew Lake wrote: > > Very nice. A couple questions: > > 1. Are the inline selectiion handles grab-able? I assume yes. > > 2. Does this automatically appear when a selection is made or on > > right-click? I assume the former. > > > > It would eventually be nice t

Re: Review Request 124374: custom inline edit menu for plasma controls

2015-07-21 Thread Andrew Lake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124374/#review82771 --- Very nice. A couple questions: 1. Are the inline selectiion ha

[Breeze] [Bug 350434] SDDM theme does not use Breeze user icons

2015-07-21 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=350434 --- Comment #2 from David Edmundson --- Slightly tricky; SDDM decided to add code themselves into show a fallback icon they provide from /usr/share/sddm/faces This path overridable in sddm.conf So now instead of getting a file path, or nothing we al

Re: Review Request 124409: Begin fading the OSD immediately

2015-07-21 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- (Updated July 21, 2015, 3:05 p.m.) Status -- This change has been ma

Re: Review Request 124409: Begin fading the OSD immediately

2015-07-21 Thread Sebastian Kügler
On Tuesday, July 21, 2015 12:30:34 David Edmundson wrote: > > On July 21, 2015, 8:07 a.m., Martin Klapetek wrote: > > > ...with my maintainer hat on. I would say let's gather feedback from > > > beta and during akademy and if it's bad, we can revert for the release. > +1 to that idea. +another1 --

Re: Review Request 124409: Begin fading the OSD immediately

2015-07-21 Thread David Edmundson
> On July 21, 2015, 8:07 a.m., Martin Klapetek wrote: > > ...with my maintainer hat on. I would say let's gather feedback from beta > > and during akademy and if it's bad, we can revert for the release. +1 to that idea. - David --- Thi

Re: Review Request 124409: Begin fading the OSD immediately

2015-07-21 Thread Kai Uwe Broulik
> On Juli 21, 2015, 8:46 vorm., Mark Gaiser wrote: > > lookandfeel/contents/osd/Osd.qml, line 44 > > > > > > http://doc.qt.io/qt-5/qml-qtquick-opacityanimator.html perhaps? Animators only work within the SceneGra

Re: Review Request 124347: Update desktopthemedetails kcm docbook to Plasma 5

2015-07-21 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124347/ --- (Updated July 21, 2015, 10:14 a.m.) Status -- This change has been m

Re: Review Request 124352: Update kwinsceenedges to Plasma 5

2015-07-21 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124352/ --- (Updated July 21, 2015, 10:02 a.m.) Status -- This change has been m

Re: Review Request 124351: Update kwindecoration kcm docbook to Plama 5

2015-07-21 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124351/ --- (Updated July 21, 2015, 9:57 a.m.) Status -- This change has been ma

Re: Review Request 124374: custom inline edit menu for plasma controls

2015-07-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124374/ --- (Updated July 21, 2015, 9:35 a.m.) Review request for Plasma. Repositor

Re: Review Request 124409: Begin fading the OSD immediately

2015-07-21 Thread Heiko Tietze
> On Juli 21, 2015, 7:03 vorm., Heiko Tietze wrote: > > Nice presentation, as always. But I'm not so sure that the realization of > > fading out quickly meets the needs from 'OSD is disturbing'. The second > > when the OSD is shown is still annoying (interaction during the fading > > might res

Re: Review Request 124408: Make PlasmaCore.Dialog opacity work

2015-07-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124408/#review82759 --- Ship it! Ship It! - Marco Martin On July 20, 2015, 7:40 p.

Re: Review Request 124409: Begin fading the OSD immediately

2015-07-21 Thread Martin Klapetek
> On July 21, 2015, 9:03 a.m., Heiko Tietze wrote: > > Nice presentation, as always. But I'm not so sure that the realization of > > fading out quickly meets the needs from 'OSD is disturbing'. The second > > when the OSD is shown is still annoying (interaction during the fading > > might rest

Re: Review Request 124409: Begin fading the OSD immediately

2015-07-21 Thread Martin Gräßlin
> On July 21, 2015, 9:03 a.m., Heiko Tietze wrote: > > Nice presentation, as always. But I'm not so sure that the realization of > > fading out quickly meets the needs from 'OSD is disturbing'. The second > > when the OSD is shown is still annoying (interaction during the fading > > might rest

Re: Review Request 124409: Begin fading the OSD immediately

2015-07-21 Thread Heiko Tietze
> On Juli 21, 2015, 7:03 vorm., Heiko Tietze wrote: > > Nice presentation, as always. But I'm not so sure that the realization of > > fading out quickly meets the needs from 'OSD is disturbing'. The second > > when the OSD is shown is still annoying (interaction during the fading > > might res

Re: Review Request 124409: Begin fading the OSD immediately

2015-07-21 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82755 --- lookandfeel/contents/osd/Osd.qml (line 44)

Re: Review Request 124408: Make PlasmaCore.Dialog opacity work

2015-07-21 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124408/#review82754 --- +1 - Martin Klapetek On July 20, 2015, 9:40 p.m., Kai Uwe B

Re: Review Request 124409: Begin fading the OSD immediately

2015-07-21 Thread Martin Klapetek
> On July 21, 2015, 9:03 a.m., Heiko Tietze wrote: > > Nice presentation, as always. But I'm not so sure that the realization of > > fading out quickly meets the needs from 'OSD is disturbing'. The second > > when the OSD is shown is still annoying (interaction during the fading > > might rest

Re: Review Request 124409: Begin fading the OSD immediately

2015-07-21 Thread Heiko Tietze
> On Juli 21, 2015, 7:03 vorm., Heiko Tietze wrote: > > Nice presentation, as always. But I'm not so sure that the realization of > > fading out quickly meets the needs from 'OSD is disturbing'. The second > > when the OSD is shown is still annoying (interaction during the fading > > might res

Re: Review Request 124409: Begin fading the OSD immediately

2015-07-21 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82751 --- Ship it! ...with my maintainer hat on. I would say let's gath

Re: Review Request 124409: Begin fading the OSD immediately

2015-07-21 Thread Martin Klapetek
> On July 21, 2015, 8:28 a.m., Martin Gräßlin wrote: > > This needs quite a bit of testing in real world: how does it behave with > > changing content underneath (e.g. a video, scrolling web browser), heavy > > load on the system, heavy load on the compositor, etc. Looks like the upcoming beta

Re: Review Request 124409: Begin fading the OSD immediately

2015-07-21 Thread Martin Klapetek
> On July 21, 2015, 9:03 a.m., Heiko Tietze wrote: > > Nice presentation, as always. But I'm not so sure that the realization of > > fading out quickly meets the needs from 'OSD is disturbing'. The second > > when the OSD is shown is still annoying (interaction during the fading > > might rest

Re: Review Request 124409: Begin fading the OSD immediately

2015-07-21 Thread Martin Klapetek
> On July 21, 2015, 1:36 a.m., Aleix Pol Gonzalez wrote: > > lookandfeel/contents/osd/Osd.qml, line 48 > > > > > > This looks like a random wait time... Looking at the video, it seems > > like a slow animation. >

Re: Review Request 124409: Begin fading the OSD immediately

2015-07-21 Thread Martin Gräßlin
> On July 21, 2015, 9:03 a.m., Heiko Tietze wrote: > > Nice presentation, as always. But I'm not so sure that the realization of > > fading out quickly meets the needs from 'OSD is disturbing'. The second > > when the OSD is shown is still annoying (interaction during the fading > > might rest

Re: Review Request 124409: Begin fading the OSD immediately

2015-07-21 Thread Heiko Tietze
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82745 --- Nice presentation, as always. But I'm not so sure that the rea