Re: baloo monitor visibility

2015-07-17 Thread Andrew Lake
It seems this desktop search monitor fits squarely into the "powerful when needed" bucket. In that sense I don't think it is necessary to expose it through any of the primary search interfaces (Alt-F2 or application menu). That doesn't mean it should be completely hidden away since when it is actua

Re: Review Request 124375: Fix potential endless recursion in PanelView::event() handler

2015-07-17 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124375/#review82604 --- Ship it! Ship It! - David Edmundson On July 16, 2015, 1:48

Re: Review Request 124375: Fix potential endless recursion in PanelView::event() handler

2015-07-17 Thread Daniel Vrátil
> On July 16, 2015, 4:34 p.m., David Edmundson wrote: > > Surely all this patch will do is change it from infinitely recursing to > > 100% CPU busy looping in each event loop? > > I don't see how that's much better? With the event handling going through the event loop there is a high chance th

Re: baloo monitor visibility

2015-07-17 Thread Harald Sitter
On Wed, Jul 15, 2015 at 10:39 AM, Pinak Ahuja wrote: > In fact I'm working on a plasmoid with the monitor's functionality, which > will show up in the tray. Maybe we can hide the monitor from applications > and add a button to plasmoid? i.e. if we do end up shipping the plasmoid. I think that wou