Re: Review Request 124234: Add option to always show all system tray icons

2015-07-02 Thread Xen
Good, the layout looks better. It still gets lost in between the preceding text and the options. That's why I suggtested putting it below (as long as the text doesn't scroll off the window because there are too many items to display, and even then). Right now you skip over it (visually, men

Re: Review Request 124234: Add option to always show al system tray icons

2015-07-02 Thread David Edmundson
Xen, Could you post any replied to reviews via git.reviewboard.kde.org. Otherwise comment threads get split and lost. David ​ ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124234: Add option to always show all system tray icons

2015-07-02 Thread Andrew Lake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124234/#review82025 --- Yeah, let's not bother with the dimming. It just introduces an

Re: Review Request 124234: Add option to always show all system tray icons

2015-07-02 Thread Heiko Tietze
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124234/#review82024 --- Nice addition. I was checking if users are able to realize the

Re: Review Request 124234: Add option to always show all system tray icons

2015-07-02 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124234/ --- (Updated Juli 2, 2015, 9:23 nachm.) Review request for Plasma and KDE Usa

Re: Review Request 124234: Add option to always show al system tray icons

2015-07-02 Thread Xen
I would suggest that you frame it in a negative way. Instead of show all icons you make it "Do not hide unused icons." or "Do not hide any icons." You frame it negatively because hiding unused items is the default, so that's where you come from. This makes it more comprehensible. Also, I

Re: Review Request 124234: Add option to always show all system tray icons

2015-07-02 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124234/#review82018 --- I'd change the label to "Always show all entries" (actually, i

Re: Review Request 124234: Add option to always show all system tray icons

2015-07-02 Thread Jonathan Marten
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124234/#review82012 --- Requested a long time ago (for KDE 4) as https://git.reviewbo

Re: Review Request 124234: Add option to always show all system tray icons

2015-07-02 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124234/#review82008 --- Perhaps we should/could slightly reduce opacity on items that

Re: Review Request 124234: Add option to always show all system tray icons

2015-07-02 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124234/ --- (Updated Juli 2, 2015, 7:47 nachm.) Review request for Plasma and KDE Usa

Re: Review Request 124234: Add option to always show all system tray icons

2015-07-02 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124234/#review82007 --- No usability review without screenshots ;) - Thomas Pfeiffer

Review Request 124236: More sensible sizing for containment configuration

2015-07-02 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124236/ --- Review request for Plasma. Repository: plasma-desktop Description -

Review Request 124234: Add option to always show all system tray icons

2015-07-02 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124234/ --- Review request for Plasma and KDE Usability. Bugs: 349812 https://bug

[Powerdevil] [Bug 349750] Laptop does not suspend when lid closed in lock screen

2015-07-02 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=349750 Kai Uwe Broulik changed: What|Removed |Added Severity|normal |major CC|

Re: Review Request 124215: Explicitly look for XKB instead of juggling paths in base of a prefix

2015-07-02 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124215/#review81977 --- Ship it! Ship It! - Hrvoje Senjan On July 2, 2015, 1:07 a.