Re: Review Request 124210: [shell] A desktop window should be frameless

2015-06-29 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124210/ --- (Updated June 29, 2015, 1:42 p.m.) Status -- This change has been ma

Re: Review Request 124210: [shell] A desktop window should be frameless

2015-06-29 Thread Martin Gräßlin
> On June 29, 2015, 3:05 p.m., Mark Gaiser wrote: > > +1 > > > > Just curious, why was this never an issue with X11? Because Qt on X11 doesn't do client side decorations and KWin didn't do server side decorations for desktop windows. - Martin ---

Re: Review Request 124210: [shell] A desktop window should be frameless

2015-06-29 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124210/#review81862 --- Ship it! Ship It! - Sebastian Kügler On June 29, 2015, 12:

Re: Review Request 124210: [shell] A desktop window should be frameless

2015-06-29 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124210/#review81861 --- +1 Just curious, why was this never an issue with X11? - Mar

Review Request 124210: [shell] A desktop window should be frameless

2015-06-29 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124210/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 124207: Use proper relative paths to import js code

2015-06-29 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124207/#review81856 --- Ship it! Ship It! - Sebastian Kügler On June 29, 2015, 7:1

Re: Review Request 124206: Use proper relative paths to import js code

2015-06-29 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124206/#review81857 --- Ship it! Ship It! - Sebastian Kügler On June 29, 2015, 7:1

Re: Review Request 124204: Use proper relative paths to import js code

2015-06-29 Thread Kevin Ottens
> On June 29, 2015, 7:57 a.m., David Edmundson wrote: > > Was this causing an error? Yes, most of the applets (see my other patches) were broken after my update this week-end. I didn't update in a while previously. I noted that the applets were inconsistent some using import "foo.js" (all brok

Re: Review Request 124204: Use proper relative paths to import js code

2015-06-29 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124204/#review81845 --- Theoretically Plasma should automatically use the code directo

Re: Review Request 124204: Use proper relative paths to import js code

2015-06-29 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124204/#review81844 --- Was this causing an error? - David Edmundson On June 29, 20

Review Request 124207: Use proper relative paths to import js code

2015-06-29 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124207/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Review Request 124206: Use proper relative paths to import js code

2015-06-29 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124206/ --- Review request for Plasma. Repository: plasma-desktop Description -

Review Request 124205: Use proper relative paths to import js code

2015-06-29 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124205/ --- Review request for Plasma. Repository: kdeplasma-addons Description ---

Review Request 124204: Use proper relative paths to import js code

2015-06-29 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124204/ --- Review request for Plasma. Repository: bluedevil Description --- U