Re: Where to place kcron in systemsettings5?

2015-05-16 Thread Christoph Feck
On Friday 08 May 2015 03:49:30 šumski wrote: > On Friday 08 of May 2015 01:34:14 Christoph Feck wrote: > > On Friday 08 May 2015 01:10:18 David Edmundson wrote: > > > ​Probably just not ported? > > > > Only the category needs to be ported, but I am unsure where it > > belongs. If I understand Burk

Re: Review Request 123817: Device notifier: Refresh the space indicator every 5 seconds.

2015-05-16 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123817/#review80492 --- I think it should be refreshed whenever you hover a device, no

Re: Review Request 123821: Highlight leading and trailing whitespace

2015-05-16 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123821/#review80488 --- Definitiely +1 from the usability side, great work! - Thomas

Re: Review Request 123821: Highlight leading and trailing whitespace

2015-05-16 Thread Kai Uwe Broulik
> On Mai 16, 2015, 7:39 nachm., Patrick Eigensatz wrote: > > applets/clipboard/contents/ui/ClipboardItemDelegate.qml, line 70 > > > > > > One question: Does this line only apply to the displayed string? What > >

Re: Review Request 123821: Highlight leading and trailing whitespace

2015-05-16 Thread Patrick Eigensatz
> On Mai 16, 2015, 7:39 nachm., Patrick Eigensatz wrote: > > applets/clipboard/contents/ui/ClipboardItemDelegate.qml, line 70 > > > > > > One question: Does this line only apply to the displayed string? What > >

Re: Review Request 123821: Highlight leading and trailing whitespace

2015-05-16 Thread Kai Uwe Broulik
> On Mai 16, 2015, 7:39 nachm., Patrick Eigensatz wrote: > > applets/clipboard/contents/ui/ClipboardItemDelegate.qml, line 70 > > > > > > One question: Does this line only apply to the displayed string? What > >

Re: Review Request 123821: Highlight leading and trailing whitespace

2015-05-16 Thread Patrick Eigensatz
> On Mai 16, 2015, 7:34 nachm., Christoph Feck wrote: > > +1 from just looking at the image. The coloring isn't annoying, so I see no > > reason why anyone would need to turn this off. Ah, messed stuff up in my head. Sorry... - Patrick ---

Re: Review Request 123821: Highlight leading and trailing whitespace

2015-05-16 Thread Patrick Eigensatz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123821/#review80482 --- applets/clipboard/contents/ui/ClipboardItemDelegate.qml (line

Re: Review Request 123821: Highlight leading and trailing whitespace

2015-05-16 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123821/#review80480 --- +1 from just looking at the image. The coloring isn't annoying

Re: Review Request 123821: Highlight leading and trailing whitespace

2015-05-16 Thread Patrick Eigensatz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123821/#review80478 --- This looks awesome! :) Are we still supposed to have a configu

Re: Review Request 123821: Highlight leading and trailing whitespace

2015-05-16 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123821/ --- (Updated Mai 16, 2015, 6:54 nachm.) Review request for Plasma, KDE Usabil

Review Request 123821: Highlight leading and trailing whitespace

2015-05-16 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123821/ --- Review request for Plasma, KDE Usability, Martin Gräßlin, and Patrick Eigen

Re: Review Request 123818: soliddevice: Use KDiskFreeSpaceInfo instead of solid to get disk size

2015-05-16 Thread Yoann Laissus
> On mai 16, 2015, 6:03 après-midi, Mark Gaiser wrote: > > Why the C-Sytle casts? (qulonglong).. > > If you use casts, use the C++ style casts. Ah, you're right, several years without c++, it doesn't help ... I just send a new patch with a refactor of this part. - Yoann -

Re: Review Request 123818: soliddevice: Use KDiskFreeSpaceInfo instead of solid to get disk size

2015-05-16 Thread Yoann Laissus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123818/ --- (Updated mai 16, 2015, 6:44 après-midi) Review request for Plasma. Chan

[Plasma Workspace Wallpapers] [Bug 347532] preferencias de escritorio no permite establecer fondo de pantalla ni individual ni en presentacion solo las del sistenma

2015-05-16 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=347532 --- Comment #2 from Christoph Feck --- If you can provide the information requested in comment #1, please add a comment. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-d

Re: Review Request 123818: soliddevice: Use KDiskFreeSpaceInfo instead of solid to get disk size

2015-05-16 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123818/#review80471 --- Why the C-Sytle casts? (qulonglong).. If you use casts, use th

Review Request 123818: soliddevice: Use KDiskFreeSpaceInfo instead of solid to get disk size

2015-05-16 Thread Yoann Laissus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123818/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Review Request 123817: Device notifier: Refresh the space indicator every 5 seconds.

2015-05-16 Thread Yoann Laissus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123817/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 123770: Play the login sound in its own thread

2015-05-16 Thread Martin Klapetek
> On May 16, 2015, 7:13 p.m., Andreas Hartmetz wrote: > > Sorry, this has a major flaw: KNotification may pop up a window which is > > clearly not what you want as a login "sound". Worse, this window is created > > from a secondary thread which will cause an assertion to fail and kill > > ksms

Re: Review Request 123770: Play the login sound in its own thread

2015-05-16 Thread Andreas Hartmetz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123770/#review80468 --- Sorry, this has a major flaw: KNotification may pop up a windo

Review Request 123815: Fix the panel configuration width in case of long strings in buttons.

2015-05-16 Thread Yoann Laissus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123815/ --- Review request for Plasma. Repository: plasma-desktop Description -

Review Request 123814: Use KMessageWidget for polkit error

2015-05-16 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123814/ --- Review request for Plasma. Repository: polkit-kde-agent-1 Description -

Re: Review Request 123781: Don't mangle UDS_TARGET_URL to UDS_LOCAL_PATH in UDSEntries

2015-05-16 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123781/ --- (Updated May 16, 2015, 12:54 p.m.) Status -- This change has been ma