Re: Review Request 123411: Protect X11 calls in the Pager plasmoid to prevent plasmashell from crashing in Wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123411/#review79322 --- Ship it! yep, that worked. - Martin Gräßlin On April 22, 2

Re: Review Request 123411: Protect X11 calls in the Pager plasmoid to prevent plasmashell from crashing in Wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123411/ --- (Updated April 22, 2015, 5:55 a.m.) Status -- This change has been m

[Powerdevil] [Bug 346456] New: When screen turn off automatically, it will turn black twice.

https://bugs.kde.org/show_bug.cgi?id=346456 Bug ID: 346456 Summary: When screen turn off automatically, it will turn black twice. Product: Powerdevil Version: 5.2.95 Platform: Chakra OS: Linux St

Re: Review Request 123459: Lockscreen: It shouldn't show the battery information on system which they don't have a battery

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123459/#review79321 --- -1 that's what the visible: pmSource.data["Battery"]["Has Cum

Re: Review Request 123411: Protect X11 calls in the Pager plasmoid to prevent plasmashell from crashing in Wayland

> On April 18, 2015, 7:50 a.m., Martin Gräßlin wrote: > > applets/pager/plugin/pager.h, line 144 > > > > > > m_rows seems not to be initialized if m_isX11 is false I tried to change this in patch revision #2. I

Re: Review Request 123411: Protect X11 calls in the Pager plasmoid to prevent plasmashell from crashing in Wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123411/ --- (Updated April 22, 2015, 12:05 a.m.) Review request for Plasma. Changes

Re: Review Request 123459: Lockscreen: It shouldn't show the battery information on system which they don't have a battery

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123459/#review79312 --- Ship it! Ship It! - Lukáš Tinkl On Dub. 21, 2015, 11:18 od

Re: Review Request 123459: Lockscreen: It shouldn't show the battery information on system which they don't have a battery

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123459/#review79311 --- lookandfeel/contents/components/InfoPane.qml (line 47)

Review Request 123459: Lockscreen: It shouldn't show the battery information on system which they don't have a battery

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123459/ --- Review request for Plasma. Bugs: 346441 https://bugs.kde.org/show_bug

Re: Review Request 123457: Plasma-Workspace: we don't need QtWebkit as a depedency.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123457/#review79308 --- Ship it! Ship It! - David Edmundson On April 21, 2015, 8:2

Re: Review Request 123448: Message dialog should be shown before we change a category in the "Desktop Settings"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123448/ --- (Updated April 21, 2015, 8:30 p.m.) Status -- This change has been m

Review Request 123457: Plasma-Workspace: we don't need QtWebkit as a depedency.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123457/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 123455: Plasma-Desktop: "Desktop Settings" apply button should become disabled after it has been pressed.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123455/ --- (Updated April 21, 2015, 8:32 p.m.) Status -- This change has been m

Re: Review Request 123448: Message dialog should be shown before we change a category in the "Desktop Settings"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123448/#review79307 --- Ship it! Ship It! - Marco Martin On April 21, 2015, 3:04 p

Re: Review Request 123455: Plasma-Desktop: "Desktop Settings" apply button should become disabled after it has been pressed.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123455/#review79306 --- Ship it! Ship It! - Marco Martin On April 21, 2015, 7:43 p

Re: Review Request 123448: Message dialog should be shown before we change a category in the "Desktop Settings"

> On April 21, 2015, 3:31 p.m., Martin Klapetek wrote: > > Note that currently if you press "Apply" in the applet's config dialogs, > > the Apply will not become disabled but will stay enabled forever. > > Antonis Tsiapaliokas wrote: > Oh, i see. > Then i guess i can fix this one too. I

Review Request 123455: Plasma-Desktop: "Desktop Settings" apply button should become disabled after it has been pressed.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123455/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 123448: Message dialog should be shown before we change a category in the "Desktop Settings"

> On April 21, 2015, 3:31 p.m., Martin Klapetek wrote: > > Note that currently if you press "Apply" in the applet's config dialogs, > > the Apply will not become disabled but will stay enabled forever. Oh, i see. Then i guess i can fix this one too. I will open another review for that one. -

Re: Review Request 123420: Timer: added tooltip for compact mode (e.g. in panel) and full mode

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123420/ --- (Updated April 21, 2015, 7:37 p.m.) Status -- This change has been m

Build failed in Jenkins: plasma-desktop_stable_qt5 #123

See Changes: [hein] Fix crash. -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace

Re: Review Request 123448: Message dialog should be shown before we change a category in the "Desktop Settings"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123448/#review79298 --- Note that currently if you press "Apply" in the applet's confi

Build failed in Jenkins: plasma-desktop_stable_qt5 #122

See Changes: [lukas] unbreak "Revert" function -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in works

Review Request 123448: Message dialog should be shown before we change a category in the "Desktop Settings"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123448/ --- Review request for Plasma. Bugs: 346431 https://bugs.kde.org/show_bug

Build failed in Jenkins: polkit-kde-agent-1_stable_qt5 #5

See Changes: [scripty] SVN_SILENT made messages (.desktop file) [scripty] SVN_SILENT made messages (.desktop file) [jr] Update version number for 5.2.90 [scripty] SVN_SILENT made messages (.desktop file) [scripty] SVN_SILENT m

Build failed in Jenkins: plasma-workspace_stable_qt5 #113

See Changes: [lukas] [containmentactions] Verify that list returned from kglobalaccel is not empty -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building re

[Plasma Workspace Wallpapers] [Bug 346425] New: crash when you want to change the time of image sequences

https://bugs.kde.org/show_bug.cgi?id=346425 Bug ID: 346425 Summary: crash when you want to change the time of image sequences Product: Plasma Workspace Wallpapers Version: 5.2.95 Platform: openSUSE RPMs OS:

Re: Review Request 123444: [ksmserver] Do not try to start X11 window manager if Wayland env variables are set

> On April 21, 2015, 12:45 p.m., David Edmundson wrote: > > related to this, on logout ksmserver kills kwin. > > > > If you're up first, I assume you also need to be down last? oh I wasn't aware the ksmserver kills kwin. I assumed it's the X connection going away that kills kwin. Will search f

Re: Review Request 123444: [ksmserver] Do not try to start X11 window manager if Wayland env variables are set

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123444/ --- (Updated April 21, 2015, 10:58 a.m.) Status -- This change has been

Re: Review Request 123444: [ksmserver] Do not try to start X11 window manager if Wayland env variables are set

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123444/#review79278 --- related to this, on logout ksmserver kills kwin. If you're up

Re: Review Request 123444: [ksmserver] Do not try to start X11 window manager if Wayland env variables are set

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123444/#review79279 --- Ship it! Ship It! - David Edmundson On April 21, 2015, 8:3

Review Request 123444: [ksmserver] Do not try to start X11 window manager if Wayland env variables are set

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123444/ --- Review request for Plasma. Repository: plasma-workspace Description ---