Re: Review Request 121097: Add a FileDialog to choose the image for fifteenpuzzle.

2015-04-03 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121097/ --- (Updated April 3, 2015, 1:35 p.m.) Status -- This change has been di

Re: Review Request 120877: Convert switch statements to if/else due to MSVC limitation

2015-04-03 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120877/ --- (Updated April 3, 2015, 7:30 p.m.) Status -- This change has been ma

Re: Proposal regarding plasmate's release

2015-04-03 Thread Marco Martin
On Friday 03 April 2015 20:41:47 David Edmundson wrote: > > > > I don't have a problem with it depending on stuff in extragear as we > > depend on many external items. As long as that stuff we depend on in > > extragear doesn't depend on stuff in plasma. > > What happens when kdevplatform releas

Re: Proposal regarding plasmate's release

2015-04-03 Thread David Edmundson
On Fri, Apr 3, 2015 at 8:10 PM, Jonathan Riddell wrote: > On Fri, Apr 03, 2015 at 08:52:09PM +0300, Antonis Tsiapaliokas wrote: > > On Fri, Apr 03, 2015 at 06:08:52PM +0200, David Edmundson wrote: > > > Can it go under kde/workspace if in future it will depend on something > in > > > extragear? >

Re: Proposal regarding plasmate's release

2015-04-03 Thread Jonathan Riddell
On Fri, Apr 03, 2015 at 08:52:09PM +0300, Antonis Tsiapaliokas wrote: > On Fri, Apr 03, 2015 at 06:08:52PM +0200, David Edmundson wrote: > > Can it go under kde/workspace if in future it will depend on something in > > extragear? > > > > I still support doing the rest, and making / release.. I'm ju

Re: Review Request 123247: Fix multiple documents and applications lists in Recently used tab

2015-04-03 Thread Anthony Vital
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123247/ --- (Updated April 3, 2015, 6:06 p.m.) Status -- This change has been ma

Re: Review Request 123242: Fix recent applications list not being updated

2015-04-03 Thread Anthony Vital
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123242/ --- (Updated April 3, 2015, 6:06 p.m.) Status -- This change has been ma

Re: Review Request 123246: Plasmate repo: Use the PROJECT_VERSION variable in order to define the version of the applications

2015-04-03 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123246/ --- (Updated April 3, 2015, 5:58 p.m.) Status -- This change has been ma

Re: Review Request 123247: Fix multiple documents and applications lists in Recently used tab

2015-04-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123247/#review78456 --- Ship it! Ship It! - Marco Martin On April 3, 2015, 5:52 p.

Review Request 123247: Fix multiple documents and applications lists in Recently used tab

2015-04-03 Thread Anthony Vital
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123247/ --- Review request for Plasma. Bugs: 342127 https://bugs.kde.org/show_bug

Re: Proposal regarding plasmate's release

2015-04-03 Thread Antonis Tsiapaliokas
On Fri, Apr 03, 2015 at 06:08:52PM +0200, David Edmundson wrote: > Can it go under kde/workspace if in future it will depend on something in > extragear? > > I still support doing the rest, and making / release.. I'm just not sure we > can do the move and release it with plasma. At the moment the

Re: Review Request 123242: Fix recent applications list not being updated

2015-04-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123242/#review78454 --- Ship it! Ship It! - David Edmundson On April 3, 2015, 5:44

Review Request 123242: Fix recent applications list not being updated

2015-04-03 Thread Anthony Vital
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123242/ --- Review request for Plasma. Bugs: 342084 https://bugs.kde.org/show_bug

Re: Review Request 123246: Plasmate repo: Use the PROJECT_VERSION variable in order to define the version of the applications

2015-04-03 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123246/#review78453 --- Ship it! Ship It! - Jonathan Riddell On April 3, 2015, 5:3

Review Request 123246: Plasmate repo: Use the PROJECT_VERSION variable in order to define the version of the applications

2015-04-03 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123246/ --- Review request for Plasma. Repository: plasmate Description --- Th

Re: Review Request 123244: Plasmate repo should no longer depend on kde4.

2015-04-03 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123244/ --- (Updated April 3, 2015, 5:32 p.m.) Status -- This change has been ma

Re: Review Request 123244: Plasmate repo should no longer depend on kde4.

2015-04-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123244/#review78451 --- Ship it! - David Edmundson On April 3, 2015, 4:59 p.m., Ant

Review Request 123244: Plasmate repo should no longer depend on kde4.

2015-04-03 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123244/ --- Review request for Plasma. Repository: plasmate Description --- Th

Re: Review Request 123241: Plasmate Repo: Change the application versions in order to match the version of Plasma's and disable Plasmate build by default.

2015-04-03 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123241/ --- (Updated April 3, 2015, 4:44 p.m.) Status -- This change has been ma

Re: Review Request 123211: Ask for confirmation before deleting a wallpaper.

2015-04-03 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123211/#review78450 --- wallpapers/image/backgroundlistmodel.h (line 93)

Re: Review Request 123241: Plasmate Repo: Change the application versions in order to match the version of Plasma's and disable Plasmate build by default.

2015-04-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123241/#review78449 --- Ship it! - David Edmundson On April 3, 2015, 4:15 p.m., Ant

Re: Review Request 123241: Plasmate Repo: Change the application versions in order to match the version of Plasma's and disable Plasmate build by default.

2015-04-03 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123241/#review78447 --- File Attachment: plasmate_disable_build - plasmate_disable_bu

Review Request 123241: Plasmate Repo: Change the application versions in order to match the version of Plasma's and disable Plasmate build by default.

2015-04-03 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123241/ --- Review request for Plasma. Repository: plasmate Description --- Th

Re: Proposal regarding plasmate's release

2015-04-03 Thread David Edmundson
On Fri, Apr 3, 2015 at 5:53 PM, Antonis Tsiapaliokas < antonis.tsiapalio...@kde.org> wrote: > On Wed, Apr 01, 2015 at 01:51:02PM +0200, Marco Martin wrote: > > Any news on this? > > besides plasmate, the repository has other utilities (plasmoidviewer, > > plasmaengineexplorer, plasmathemeexplorer,

Re: Review Request 123211: Ask for confirmation before deleting a wallpaper.

2015-04-03 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123211/ --- (Updated April 3, 2015, 3:58 p.m.) Review request for Plasma. Bugs: 338

Re: Review Request 123211: Ask for confirmation before deleting a wallpaper.

2015-04-03 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123211/ --- (Updated April 3, 2015, 4:05 p.m.) Status -- This change has been ma

Re: Proposal regarding plasmate's release

2015-04-03 Thread Jonathan Riddell
On Fri, Apr 03, 2015 at 06:53:28PM +0300, Antonis Tsiapaliokas wrote: > As it has been mentioned in previous email, we must first mail the > kde-core-devel. > As a new name i suggess the plasma-sdk and it will be under the kde/workspace. Please do so :) I'll include it in the beta tars next week

Re: Proposal regarding plasmate's release

2015-04-03 Thread Marco Martin
On Friday 03 April 2015 18:53:28 Antonis Tsiapaliokas wrote: > > > 4. make the PLASMATE_BUILD_WITH_KDEVPLATFORM off(false) by default and > > > add a > > > > > > message that will inform the user that the plasmate application > > > > > > isn't ready yet > > > > > > for production. > >

Re: Review Request 123211: Ask for confirmation before deleting a wallpaper.

2015-04-03 Thread Antonis Tsiapaliokas
> On April 3, 2015, 3:13 p.m., Thomas Pfeiffer wrote: > > It's great that you've implemented the undo function, awesome! > > What I cannot really tell from the screenshots is how a wallpaper which is > > marked to be removed is visualized. Can you maybe add a screenshot where > > the distinctio

Re: Proposal regarding plasmate's release

2015-04-03 Thread Antonis Tsiapaliokas
On Wed, Apr 01, 2015 at 01:51:02PM +0200, Marco Martin wrote: > Any news on this? > besides plasmate, the repository has other utilities (plasmoidviewer, > plasmaengineexplorer, plasmathemeexplorer, cuttlefish) that really NEED to be > released Yes, I am sorry for the delay. So lets summarize a b

Re: Review Request 123211: Ask for confirmation before deleting a wallpaper.

2015-04-03 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123211/#review78441 --- It's great that you've implemented the undo function, awesome!

Re: Review Request 123211: Ask for confirmation before deleting a wallpaper.

2015-04-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123211/#review78440 --- Ship it! Ship It! - Marco Martin On April 3, 2015, 3:06 p.

Re: Review Request 123211: Ask for confirmation before deleting a wallpaper.

2015-04-03 Thread Antonis Tsiapaliokas
> On April 2, 2015, 4:44 p.m., Marco Martin wrote: > > wallpapers/image/backgroundlistmodel.h, line 93 > > > > > > this function is not clear what it actually does > > looks like a verb but returns a list? > >

Re: Review Request 123211: Ask for confirmation before deleting a wallpaper.

2015-04-03 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123211/ --- (Updated April 3, 2015, 3:06 p.m.) Review request for Plasma. Bugs: 338

Jenkins build is back to normal : kinfocenter_master_qt5 #92

2015-04-03 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Build failed in Jenkins: kinfocenter_master_qt5 #91

2015-04-03 Thread KDE CI System
See Changes: [lueck] update to kf5 -- [...truncated 114 lines...] == Configuring Build -- The C compiler identification is GNU 4.8.2 -- The CXX compiler identification is GNU 4.8.2 -- Check for

Re: about-distro in plasma

2015-04-03 Thread David Edmundson
It duplicates some parts of "Summary" which I don't like. We could merge and drop the summary page. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: about-distro in plasma

2015-04-03 Thread Marco Martin
On Friday 03 April 2015 13:20:00 Jonathan Riddell wrote: > It does already appear in kinfocenter so if you think it's not > appropriate for system settings that's just a trivial change in the > .desktop file. > > It uses os-release which should be supported by even lame distros (not > my terminolo

Re: about-distro in plasma

2015-04-03 Thread Jonathan Riddell
On Fri, Apr 03, 2015 at 04:19:56AM -0700, Marco Martin wrote: > On Friday 03 April 2015 13:04:08 David Edmundson wrote: > > Gah, GMail pressed send too early. > > > > +1 for moving in general. > > > > I'd like it to be part of our restore kinfocenter project. It's not a > > configuration thing as

Re: about-distro in plasma

2015-04-03 Thread Marco Martin
On Friday 03 April 2015 13:04:08 David Edmundson wrote: > Gah, GMail pressed send too early. > > +1 for moving in general. > > I'd like it to be part of our restore kinfocenter project. It's not a > configuration thing as it doesn't configure anything. > > I'm not convinced about doing it for 5.

Re: about-distro in plasma

2015-04-03 Thread Jonathan Riddell
It does already appear in kinfocenter so if you think it's not appropriate for system settings that's just a trivial change in the .desktop file. It uses os-release which should be supported by even lame distros (not my terminology!) but it's easy enough to add a configure check to not build it if

Re: about-distro in plasma

2015-04-03 Thread David Edmundson
Gah, GMail pressed send too early. +1 for moving in general. I'd like it to be part of our restore kinfocenter project. It's not a configuration thing as it doesn't configure anything. I'm not convinced about doing it for 5.3 as it's less than a week before freeze and it won't work in some of th

Jenkins build is back to normal : plasma-workspace_master_qt5 #1434

2015-04-03 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: about-distro in plasma

2015-04-03 Thread David Edmundson
On Fri, Apr 3, 2015 at 12:46 PM, Jonathan Riddell wrote: > About Distro is still in Playground but it would be a useful kcm to > have included as default. +1 > Can we move it into plasma-desktop? > > Jonathan > ___ > Plasma-devel mailing list > Plas

about-distro in plasma

2015-04-03 Thread Jonathan Riddell
About Distro is still in Playground but it would be a useful kcm to have included as default. Can we move it into plasma-desktop? Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: ISO for 2015-04-03

2015-04-03 Thread Harald Sitter
On Fri, Apr 3, 2015 at 10:11 AM, Martin Gräßlin wrote: > On Friday 03 April 2015 09:34:45 Harald Sitter wrote: >> http://files.kde.org/snapshots/unstable-amd64-latest.iso.mirrorlist >> >> # changes >> - screenlocker is disabled in the live session >> - mouse cursor should use the breeze theme ever

Re: ISO for 2015-04-03

2015-04-03 Thread Martin Gräßlin
On Friday 03 April 2015 09:34:45 Harald Sitter wrote: > http://files.kde.org/snapshots/unstable-amd64-latest.iso.mirrorlist > > # changes > - screenlocker is disabled in the live session > - mouse cursor should use the breeze theme everywhere now > - plasma-nm has been migrated from libmm-qt to mo

ISO for 2015-04-03

2015-04-03 Thread Harald Sitter
http://files.kde.org/snapshots/unstable-amd64-latest.iso.mirrorlist # changes - screenlocker is disabled in the live session - mouse cursor should use the breeze theme everywhere now - plasma-nm has been migrated from libmm-qt to modemmanager-qt (now a framework). please note that the stable PPAs