Re: System Settings app design freshening

2015-03-30 Thread Andrew Lake
On Mon, Mar 30, 2015 at 1:47 AM Marco Martin wrote: > what would the left sidebar do in the first mockup where everything is > shown? > > > Those are links to modules in which recent changes were made. Selecting one would take the user directly to that module. Hope this helps, Andrew

Review Request 123190: CMakeLists.txt: Install sddm theme to KDE_INSTALL_DATADIR

2015-03-30 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123190/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 122679: Show Desktop feature: refurbished

2015-03-30 Thread Thomas Pfeiffer
> On March 22, 2015, 8:28 p.m., Kai Uwe Broulik wrote: > > Sorry for being late to the party: > > > > UX issues I have with that implementation: > > - No transition, the windows just disappear (would be cool to have them > > slide out of the screen or have them stay at the edges of the screen l

Re: Review Request 122679: Show Desktop feature: refurbished

2015-03-30 Thread Thomas Lübking
> On März 30, 2015, 7:12 nachm., Thomas Pfeiffer wrote: > > Was adding the usability group more meant as a heads-up to inform us that > > things are happening on this front, or are you expecting an actual > > usability review? > > In the latter case, we'd need some kind of visualization or at l

Re: Review Request 122679: Show Desktop feature: refurbished

2015-03-30 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/#review78252 --- Really nice, I love the badbadwindows effect! Is it intended

Re: Review Request 122679: Show Desktop feature: refurbished

2015-03-30 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/ --- (Updated März 30, 2015, 9:06 nachm.) Review request for kwin, Plasma, KDE

Re: Plasma 5 is awesome...and some help required with build instructions

2015-03-30 Thread David Edmundson
> > Any ideas? (attached the output/bt I got from gdb) > > it's an assert in "could not find any theme" At a guess you XDG_DATA_DIRS are wrong. cat /proc/PIDOFPLASMASHELL/env will tell you the most > Thanks :) > > Bye, > Bernhard Friedreich > > > > > 2015-03-28 19:23 GMT+01:00 Siddhartha : > >

Re: Plasma 5 is awesome...and some help required with build instructions

2015-03-30 Thread Siddhartha
Hey Martin, Thanks for all the comments :) On 30 March 2015 at 16:11, Martin Klapetek wrote: >> sudo chown -R user:group /opt/kde > > I think this should either use $USER or `whoami` rather than "user" ? Hmm good point. Also I learned that leaving the group empty after a colon automatically set

Re: Plasma 5 is awesome...and some help required with build instructions

2015-03-30 Thread Bernhard Friedreich
Hi, At first: thanks for the guide :) It's a nice addition to https://community.kde.org/Frameworks/Building I've got the following problems: 1.) on my fedora 23 (rawhide) I had to set selinux to permissive mode for the custom dbus files to be read (otherwise it wouldn't let dbus access them, mayb

Re: Review Request 123188: Replicate functionality of Frameworks KStyle for KDE4

2015-03-30 Thread David Edmundson
> On March 30, 2015, 6:06 p.m., Hugo Pereira Da Costa wrote: > > in principle, ship it. The approach is sound. (indeed KDE4 oxygen and hence > > breeze moved away from KStyle at some point in the past because it was > > bringing more issues than solving. Copied the said code from kstyle to > >

Re: Review Request 122679: Show Desktop feature: refurbished

2015-03-30 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/#review78245 --- Was adding the usability group more meant as a heads-up to inf

Re: Review Request 123188: Replicate functionality of Frameworks KStyle for KDE4

2015-03-30 Thread Hugo Pereira Da Costa
> On March 30, 2015, 6:06 p.m., Hugo Pereira Da Costa wrote: > > in principle, ship it. The approach is sound. (indeed KDE4 oxygen and hence > > breeze moved away from KStyle at some point in the past because it was > > bringing more issues than solving. Copied the said code from kstyle to > >

Re: Review Request 123188: Replicate functionality of Frameworks KStyle for KDE4

2015-03-30 Thread David Edmundson
> On March 30, 2015, 6:06 p.m., Hugo Pereira Da Costa wrote: > > in principle, ship it. The approach is sound. (indeed KDE4 oxygen and hence > > breeze moved away from KStyle at some point in the past because it was > > bringing more issues than solving. Copied the said code from kstyle to > >

Re: Review Request 123188: Replicate functionality of Frameworks KStyle for KDE4

2015-03-30 Thread David Edmundson
> On March 30, 2015, 6:06 p.m., Hugo Pereira Da Costa wrote: > > in principle, ship it. The approach is sound. (indeed KDE4 oxygen and hence > > breeze moved away from KStyle at some point in the past because it was > > bringing more issues than solving. Copied the said code from kstyle to > >

Re: Review Request 123188: Replicate functionality of Frameworks KStyle for KDE4

2015-03-30 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123188/ --- (Updated March 30, 2015, 6:22 p.m.) Review request for Plasma and Hugo Pe

Re: Review Request 123188: Replicate functionality of Frameworks KStyle for KDE4

2015-03-30 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123188/#review78237 --- in principle, ship it. The approach is sound. (indeed KDE4 oxy

Review Request 123188: Replicate functionality of Frameworks KStyle for KDE4

2015-03-30 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123188/ --- Review request for Plasma and Hugo Pereira Da Costa. Repository: breeze

Re: Review Request 123164: Add new Bluetooth applet

2015-03-30 Thread Xuetian Weng
> On March 29, 2015, 6 p.m., Kai Uwe Broulik wrote: > > File Attachment: snapshot5.png - snapshot5.png > > > > > > I wouldn't show the ID right at a glance. That's super geeky. Hide that > > in the details section. > > David Rosca wrot

Release Dates for August

2015-03-30 Thread Jonathan Riddell
Plasma 5.4 release schedule needs writing and keeping to our 3 months would release in July. That puts the release during Akademy so it needs shifting. Baloo wants to move from Plasma to Frameworks. At the same time it will get a shiny new database which makes it incompatible with baloo for kdel

Plasma 5 Bugs Saved Searches

2015-03-30 Thread Jonathan Riddell
I've made some searches for Plasma 5 bugs which you can find if you log in and go to https://bugs.kde.org/userprefs.cgi?tab=saved-searches Plasma5-All has all open bugs in products that are part of the Plasma releases. https://bugs.kde.org/buglist.cgi?cmdtype=dorem&remaction=run&namedcmd=Plasm

Re: Minutes Monday Plasma Hangout

2015-03-30 Thread Bhushan Shah
On Mon, Mar 30, 2015 at 4:40 PM, Marco Martin wrote: > minutes of hangout from 30 march 2015: Bhushan Shah: - Bug fixes > Lockscreen password field focus fix. > 1 pixel gap between right aligned panel and screen edge - VDG thread for TV optimized dashboard support in PMC https://forum.kde.org/

Next Plasma Hangout

2015-03-30 Thread Marco Martin
Hi all, since next monday is a public holiday in most of europe, the next plasma hangout will be Tuesday 7 April at 12:00 as usual -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Minutes Monday Plasma Hangout

2015-03-30 Thread Marco Martin
minutes of hangout from 30 march 2015: Antonis: - will work on bug fixing David: - highdpi stuff - merged highdpi branches in frameworks and dolphin (dolphin5 will be in August release) - ported kgamma to Kf5 Harald: - https://git.reviewboard.kde.org/r/123147/ is blocking kubuntu ci - mixer app

Re: Plasma 5 is awesome...and some help required with build instructions

2015-03-30 Thread Martin Klapetek
Good stuff! Here are my comments: > sudo chown -R user:group /opt/kde I think this should either use $USER or `whoami` rather than "user" ? > Uncomment the last two lines if you also want to build the Applications and PIM suite. This should probably be inside the kdesrc-buildrc itself. Maybe

Re: Review Request 123147: do not install so link if the headers are not being installed

2015-03-30 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123147/ --- (Updated March 30, 2015, 10:28 a.m.) Status -- This change has been

Re: Review Request 123147: do not install so link if the headers are not being installed

2015-03-30 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123147/#review78210 --- Ship it! Ship It! - David Edmundson On March 27, 2015, 8:3

Re: Review Request 123164: Add new Bluetooth applet

2015-03-30 Thread David Rosca
> On March 30, 2015, 8:42 a.m., Emmanuel Pescosta wrote: > > src/applet/package/contents/code/logic.js, line 34 > > > > > > array.filter() maybe? Nope, doesn't work: TypeError: Property 'filter' of object [o

Re: System Settings app design freshening

2015-03-30 Thread Marco Martin
On Sunday 29 March 2015, Andrew Lake wrote: > As noted on that page, this is *not* a proposal for the kcm designs; just > the system settings application. So ignore the kcm mockups and focus on the > system settings stuff. As always, we can tweak the proposal, as necessary, > to adjust to implement

Re: Review Request 123164: Add new Bluetooth applet

2015-03-30 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123164/#review78206 --- src/applet/package/contents/code/logic.js (line 34)

Re: Review Request 122679: Show Desktop feature: refurbished

2015-03-30 Thread Thomas Lübking
> On März 30, 2015, 6:02 vorm., Martin Gräßlin wrote: > > effects/CMakeLists.txt, line 133 > > > > > > the name looks a little bit "mhhh" ;-) > > Thomas Lübking wrote: > When thinking about a name that does

Re: Review Request 122679: Show Desktop feature: refurbished

2015-03-30 Thread Thomas Lübking
> On März 30, 2015, 7:55 vorm., Martin Gräßlin wrote: > > effects/badbadwindows/package/contents/code/main.js, line 5 > > > > > > isn't it yours? Yes, had seen that (and fixed it, but didn't finish the eye On Scre

Re: Review Request 122679: Show Desktop feature: refurbished

2015-03-30 Thread Martin Gräßlin
> On March 30, 2015, 8:02 a.m., Martin Gräßlin wrote: > > effects/CMakeLists.txt, line 133 > > > > > > the name looks a little bit "mhhh" ;-) > > Thomas Lübking wrote: > When thinking about a name that does

Re: Review Request 122679: Show Desktop feature: refurbished

2015-03-30 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/#review78200 --- effects/badbadwindows/package/contents/code/main.js (line 5)

Re: Review Request 122679: Show Desktop feature: refurbished

2015-03-30 Thread Thomas Lübking
> On März 30, 2015, 6:02 vorm., Martin Gräßlin wrote: > > Can we be sure that the change reguarding AnimationData in the > > ScriptedEffects doesn't break the existing effects? See scriptedeffect.cpp lines 251, 280. The AnimationData pointer was hardcoded to nullptr, metaFromData thus NOOP. Th