Re: Review Request 123091: [plasma-workspace/dataengines/geolocation] Fix build with NM 1.0.0

2015-03-20 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123091/ --- (Updated March 21, 2015, 2:16 a.m.) Review request for Plasma, Martin Grä

Review Request 123091: [plasma-workspace/dataengines/geolocation] Fix build with NM 1.0.0

2015-03-20 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123091/ --- Review request for Plasma, Martin Gräßlin and Jan Grulich. Repository: pl

Re: Review Request 123088: Adding libkactivities-stats to the build

2015-03-20 Thread Eike Hein
> On March 20, 2015, 9:23 p.m., Marco Martin wrote: > > +1 from here (will read it more) +1 too, takes the risk out of me shipping code against the experimental API in 5.3 and breaking Plasma in a KF upgrade - Eike --- This is an autom

Re: Review Request 123088: Adding libkactivities-stats to the build

2015-03-20 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123088/#review77854 --- +1 from here (will read it more) - Marco Martin On March 20

Review Request 123088: Adding libkactivities-stats to the build

2015-03-20 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123088/ --- Review request for Plasma, Eike Hein and Marco Martin. Repository: plasma

Re: Plasma 5.2.2 candidate tars

2015-03-20 Thread Jonathan Riddell
Changelog updated. https://www.kde.org/announcements/plasma-5.2.1-5.2.2-changelog.php https://www.kde.org/announcements/plasma-5.2.2.php Jonathan On Thu, Mar 19, 2015 at 09:44:20PM +0100, Albert Astals Cid wrote: > El Dijous, 19 de març de 2015, a les 17:52:15, Jonathan Riddell va escriure: >

Re: Review Request 123040: Make selection in krunner wrapping

2015-03-20 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123040/ --- (Updated March 20, 2015, 4:14 p.m.) Status -- This change has been m

Re: Review Request 123040: Make selection in krunner wrapping

2015-03-20 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123040/#review77840 --- Git commit 05570618369027c8636db9abbe3726ece6fe8e72 by Pinak A

Build failed in Jenkins: plasma-workspace_master_qt5 #1411

2015-03-20 Thread KDE CI System
See Changes: [mgraesslin] [ksmserver/screenlocker] Add safety checks before forwarding OSD messages -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building

Build failed in Jenkins: plasma-workspace_master_qt5 #1410

2015-03-20 Thread KDE CI System
See Changes: [mgraesslin] [dataengines/geolocation] Use wifi data if available -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave

Re: Review Request 122736: [dataengines/geolocation] Use wifi data if available

2015-03-20 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122736/ --- (Updated March 20, 2015, 2:04 p.m.) Status -- This change has been m

Re: Review Request 123040: Make selection in krunner wrapping

2015-03-20 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123040/#review77833 --- Ship it! Go ahead then :) - Vishesh Handa On March 18, 201

Re: Plasma 5.2.2 candidate tars

2015-03-20 Thread Jonathan Riddell
plasma-workspace updated http://download.kde.org/stable/plasma/5.2.2/plasma-workspace-5.2.2.tar.xz";>plasma-workspace-5.2.2 6.4MB - f5053a83c54e757c489d5a5cbf7a193123ca9d431f23996295804ff890fae97b + b174136ab7e5ec7190d5ad872e7334245b2e59c2a93e5f53666d155744a90572 adds... commit

Build failed in Jenkins: plasma-workspace_stable_qt5 #95

2015-03-20 Thread KDE CI System
See Changes: [jpwhiting] digitalclock: Don't reverse js timezone offset when using to generate utc from local time. -- [...truncated 3014 lines...] Scanning dependencies of target krunner_p

Re: Review Request 123079: digitalclock: Don't reverse js timezone offset when using to generate utc from local time.

2015-03-20 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123079/ --- (Updated March 20, 2015, 11:51 a.m.) Status -- This change has been

Re: Review Request 123079: digitalclock: Don't reverse js timezone offset when using to generate utc from local time.

2015-03-20 Thread Martin Klapetek
> On March 20, 2015, 9:57 a.m., Martin Klapetek wrote: > > Does anyone else observe this? Because it does sound wrong, JS timezone is > > inverted to QTimeDate (one is positive and one is negative), so they cannot > > be just added together to get the total offset. Or I'm missing something...

Re: Review Request 123079: digitalclock: Don't reverse js timezone offset when using to generate utc from local time.

2015-03-20 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123079/#review77823 --- Ship it! Ship It! - Martin Klapetek On March 20, 2015, 5:4

ISO for 2015-03-20

2015-03-20 Thread Harald Sitter
http://files.kde.org/snapshots/unstable-amd64-latest.iso.mirrorlist # changes - refinement to packaging all over the place - koko package fixed to correctly contain all runtime geomapping assets - installer loads wallpaper again - ISO boots in VMs again (tested with KVM and virtualbox) - muon/qapt

Re: Review Request 122679: Show Desktop feature: refurbished

2015-03-20 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/#review77816 --- Ship it! >From my side I would like to see this in 5.3 - Mar

Re: Plasma 5.2.2 candidate tars

2015-03-20 Thread Jonathan Riddell
On Thu, Mar 19, 2015 at 09:44:20PM +0100, Albert Astals Cid wrote: > El Dijous, 19 de març de 2015, a les 17:52:15, Jonathan Riddell va escriure: > > 5.2.2 tars are up on depot, happy packaging > > > > These tars add documentation translations, looks like the Brazilians have > > been hard at work.

Re: Review Request 122884: Adapt to KDecoration API changes

2015-03-20 Thread Mika Allan Rauhala
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122884/ --- (Updated maalis 20, 2015, 12:35 ip) Review request for kwin and Plasma.

Re: Review Request 122884: Adapt to KDecoration API changes

2015-03-20 Thread Mika Allan Rauhala
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122884/ --- (Updated maalis 20, 2015, 12:33 ip) Review request for kwin and Plasma.

Build failed in Jenkins: plasma-workspace_stable_qt5 #94

2015-03-20 Thread KDE CI System
See Changes: [mklapetek] [applets/notifications] Remove all popups from the on-screen-list -- [...truncated 3007 lines...] Building CXX object runners/windowedwidgets/CMakeFiles/krunner_win

Re: Review Request 122885: Adapt to KDecoration API changes

2015-03-20 Thread Hugo Pereira Da Costa
> On March 20, 2015, 9:16 a.m., Hugo Pereira Da Costa wrote: > > Ship It! ignore I missed the fact that it was already discarded - Hugo --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/12

Re: Review Request 122884: Adapt to KDecoration API changes

2015-03-20 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122884/#review77805 --- Ship it! Ship It! - Hugo Pereira Da Costa On March 16, 201

Re: Review Request 122885: Adapt to KDecoration API changes

2015-03-20 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122885/#review77806 --- Ship it! Ship It! - Hugo Pereira Da Costa On March 11, 201

Re: Plasma 5.2.2 candidate tars

2015-03-20 Thread Willy Sudiarto Raharjo
> Please check over info and announcement pages and let me know of any > improvements or changes > > https://www.kde.org/info/plasma-5.2.2.php > https://www.kde.org/announcements/plasma-5.2.2.php Small typo on plasma-5.2.2.php Set the passoword -> Set the password -- Willy Sudiarto Raharjo

Re: Review Request 123046: Use own copy of org.kde.JobView.xml

2015-03-20 Thread Harald Sitter
> On March 19, 2015, 5:01 p.m., Harald Sitter wrote: > > FWIW I think kjobwidgets' V2 change should be reverted and instead forked > > into a V3. Otherwise KF5.9 will break ever plasma-workspace source that was > > released in the past, which is kind of the definition of a source > > incompati

Re: Review Request 123079: digitalclock: Don't reverse js timezone offset when using to generate utc from local time.

2015-03-20 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123079/#review77796 --- Does anyone else observe this? Because it does sound wrong, JS