Re: Review Request 122463: Wipe source when IconItem becomes invisible

2015-02-06 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122463/ --- (Updated Feb. 7, 2015, 12:54 vorm.) Status -- This change has been d

Re: Review Request 122463: Wipe source when IconItem becomes invisible

2015-02-06 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122463/#review75553 --- It does seem to break the close icon in the notification popup

Review Request 122463: Wipe source when IconItem becomes invisible

2015-02-06 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122463/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: Review Request 122370: Prevent icon transition in tooltip

2015-02-06 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122370/ --- (Updated Feb. 7, 2015, 12:14 vorm.) Status -- This change has been d

Re: Review Request 122332: KQuickControls IconDialog

2015-02-06 Thread Kai Uwe Broulik
> On Feb. 2, 2015, 9:13 vorm., Marco Martin wrote: > > to do modality you have to use exec i guess I guess we don't want to black all of plasma just for this one dialog. So, we go without modality then? - Kai Uwe --- This is an automat

Re: Review Request 122452: [shell] Emit dbus signals in org.kde.osdService

2015-02-06 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122452/#review75551 --- Nice! File Attachment: Lock screen with volume OSD - missing

Re: ISO for 2015-02-06

2015-02-06 Thread Aleix Pol
On Fri, Feb 6, 2015 at 5:16 PM, Harald Sitter wrote: > On Fri, Feb 6, 2015 at 4:44 PM, Aleix Pol wrote: >> On Fri, Feb 6, 2015 at 4:38 PM, Harald Sitter wrote: >>> http://files.kde.org/snapshots/unstable-i386-latest.iso.mirrorlist >>> >>> After a brief 5.2 testing interlude, this week's ISO is a

Re: ISO for 2015-02-06

2015-02-06 Thread Harald Sitter
On Fri, Feb 6, 2015 at 4:44 PM, Aleix Pol wrote: > On Fri, Feb 6, 2015 at 4:38 PM, Harald Sitter wrote: >> http://files.kde.org/snapshots/unstable-i386-latest.iso.mirrorlist >> >> After a brief 5.2 testing interlude, this week's ISO is again >> integrating Plasma from master (i.e. what is going t

Re: ISO for 2015-02-06

2015-02-06 Thread Aleix Pol
On Fri, Feb 6, 2015 at 4:38 PM, Harald Sitter wrote: > http://files.kde.org/snapshots/unstable-i386-latest.iso.mirrorlist > > After a brief 5.2 testing interlude, this week's ISO is again > integrating Plasma from master (i.e. what is going to become 5.3). > > # changes > - kde4breeze is working a

ISO for 2015-02-06

2015-02-06 Thread Harald Sitter
http://files.kde.org/snapshots/unstable-i386-latest.iso.mirrorlist After a brief 5.2 testing interlude, this week's ISO is again integrating Plasma from master (i.e. what is going to become 5.3). # changes - kde4breeze is working again \o/ # errata - only limited testing as I am currently workin

Re: Review Request 122452: [shell] Emit dbus signals in org.kde.osdService

2015-02-06 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122452/#review75533 --- Ship it! Looks good, can't really comment on the wayland stuf

Review Request 122452: [shell] Emit dbus signals in org.kde.osdService

2015-02-06 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122452/ --- Review request for Plasma and Martin Klapetek. Repository: plasma-workspa

Re: Review Request 122451: Whitelist brightness keys in the lockscreen

2015-02-06 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122451/ --- (Updated Feb. 6, 2015, 10:40 a.m.) Status -- This change has been ma

Re: Review Request 122451: Whitelist brightness keys in the lockscreen

2015-02-06 Thread Martin Gräßlin
> On Feb. 6, 2015, 11:21 a.m., Martin Gräßlin wrote: > > ksmserver/screenlocker/globalaccel.cpp, line 52 > > > > > > isn't this missing QList or is C++11 even smarter than I > > expected? > > Lukáš Tinkl wrote:

Re: Review Request 122451: Whitelist brightness keys in the lockscreen

2015-02-06 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122451/#review75521 --- Ship it! Ship It! - Martin Gräßlin On Feb. 6, 2015, 11:04

Re: Review Request 122451: Whitelist brightness keys in the lockscreen

2015-02-06 Thread Lukáš Tinkl
> On Úno. 6, 2015, 11:21 dop., Martin Gräßlin wrote: > > ksmserver/screenlocker/globalaccel.cpp, line 52 > > > > > > isn't this missing QList or is C++11 even smarter than I > > expected? It's that smart ;) I wa

Re: Review Request 122451: Whitelist brightness keys in the lockscreen

2015-02-06 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122451/#review75518 --- ksmserver/screenlocker/globalaccel.cpp

Review Request 122451: Whitelist brightness keys in the lockscreen

2015-02-06 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122451/ --- Review request for Plasma, Daniel Vrátil and Martin Gräßlin. Repository:

Re: Review Request 122449: [ksmserver/screenlocker] Allow media control global shortcuts

2015-02-06 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122449/ --- (Updated Feb. 6, 2015, 9:07 a.m.) Status -- This change has been mar

Re: Review Request 122449: [ksmserver/screenlocker] Allow media control global shortcuts

2015-02-06 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122449/#review75516 --- Ship it! Ship It! - David Edmundson On Feb. 6, 2015, 7:52

Review Request 122450: Do not set global shortcuts for the Media keys

2015-02-06 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122450/ --- Review request for Amarok and Plasma. Repository: amarok Description --