Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122239/#review74685 --- Ship it! Ship It! - Lukáš Tinkl On Led. 25, 2015, 12:54 do

Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122239/ --- (Updated Jan. 24, 2015, 11:54 nachm.) Review request for Plasma. Change

Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122239/#review74683 --- src/qmlcontrols/kquickcontrolsaddons/kcmshell.h

Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122239/ --- Review request for Plasma. Repository: kdeclarative Description ---

Re: Review Request 122065: Fix activity start and stop.

> On Jan. 23, 2015, 7:40 a.m., Martin Gräßlin wrote: > > This looks still wrong to me. The service is still called "org.kde.kwin" > > while it should be "org.kde.KWin". Ideally this gets changed to a generated > > adaptor from the DBus interface KWin installs. > > > > To make things worse: the

Re: Review Request 122065: Fix activity start and stop.

> On Jan. 23, 2015, 8:40 a.m., Martin Gräßlin wrote: > > This looks still wrong to me. The service is still called "org.kde.kwin" > > while it should be "org.kde.KWin". Ideally this gets changed to a generated > > adaptor from the DBus interface KWin installs. > > > > To make things worse: the

Re: Further plasma moves

El Divendres, 23 de gener de 2015, a les 18:34:31, David Rosca va escriure: > It's because master is for kdelibs 4 and frameworks for KF5. As far as i know none of the repositories released under Plasma 5.2 follow that rule. > So are you saying that it would be better to switch it - master = KF5

Re: Review Request 122233: Fix global shortcut after configuration.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122233/ --- (Updated Jan. 24, 2015, 2:01 p.m.) Status -- This change has been ma

Re: Review Request 122230: Continuously update notification timestamp

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122230/#review74662 --- Ship it! Ship It! - Lukáš Tinkl On Led. 23, 2015, 9:28 odp

Re: Review Request 122233: Fix global shortcut after configuration.

> On Jan. 24, 2015, 5:02 p.m., Bhushan Shah wrote: > > src/kded/kdedactions.cpp, line 49 > > > > > > since isConfiguration itself is bool, > > > > act->setProperty("isConfigurationAction", isConfiguratio

Re: Review Request 122233: Fix global shortcut after configuration.

> On Jan. 24, 2015, 11:32 a.m., Bhushan Shah wrote: > > src/kded/kdedactions.cpp, line 49 > > > > > > since isConfiguration itself is bool, > > > > act->setProperty("isConfigurationAction", isConfigurati

Re: Review Request 122233: Fix global shortcut after configuration.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122233/#review74654 --- Ship it! one nitpick, otherwise +1 src/kded/kdedactions.cpp

Review Request 122233: Fix global shortcut after configuration.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122233/ --- Review request for Plasma and Lukáš Tinkl. Repository: kcm-touchpad Des