Review Request 121974: Don't invoke context menu when there is only one ContainmentAction contextualAction

2015-01-10 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121974/ --- Review request for Plasma. Bugs: 342702 http://bugs.kde.org/show_bug.

Review Request 121973: Proper plural handling for seconds in logout screen

2015-01-10 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121973/ --- Review request for Plasma and David Edmundson. Repository: plasma-workspa

Re: Review Request 121945: Use i18np for plural units in the jobs applet

2015-01-10 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121945/#review73715 --- applets/notifications/package/contents/ui/JobDetailsItem.qml

Re: Re: RFC: Use Grid as default for KWin's Presnt windows effect

2015-01-10 Thread Martin Gräßlin
On Saturday 10 January 2015 17:54:34 Martin Klapetek wrote: > On Sat, Jan 10, 2015 at 4:31 PM, Martin Gräßlin wrote: > > -2 > > > > The reason for the natural layout is that the other layout sucks. That was > > what we shipped with in 4.0 and 4.1. Let's learn from history and don't > > repeat > >

Re: RFC: Use Grid as default for KWin's Presnt windows effect

2015-01-10 Thread Martin Klapetek
On Sat, Jan 10, 2015 at 4:31 PM, Martin Gräßlin wrote: > > -2 > > The reason for the natural layout is that the other layout sucks. That was > what we shipped with in 4.0 and 4.1. Let's learn from history and don't > repeat > it . > What was the history? I was not around at that time. Is there a

Re: Review Request 120878: Remove unused header

2015-01-10 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120878/ --- (Updated Jan. 10, 2015, 4:09 p.m.) Status -- This change has been ma

Re: RFC: Use Grid as default for KWin's Presnt windows effect

2015-01-10 Thread Martin Gräßlin
On Friday 09 January 2015 17:16:56 Martin Klapetek wrote: > Hey there, > > so I've been thinking about the Present Windows effect of KWin. The default > setting for laying the windows out is currently "Natural", but to me that > layout looks rather random as the windows are scattered all around wi