Re: Review Request 121581: Plotter in kdeclarative

2014-12-17 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121581/#review72219 --- I think it's a useful component that can end up being really u

Review Request 121581: Plotter in kdeclarative

2014-12-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121581/ --- Review request for KDE Frameworks and Plasma. Repository: kdeclarative

[Breeze] [Bug 338979] Breeze window decoration adds spacing around the windeco

2014-12-17 Thread Hugo Pereira Da Costa
https://bugs.kde.org/show_bug.cgi?id=338979 Hugo Pereira Da Costa changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|---

[Breeze] [Bug 338979] Breeze window decoration adds spacing around the windeco

2014-12-17 Thread Hugo Pereira Da Costa
https://bugs.kde.org/show_bug.cgi?id=338979 Hugo Pereira Da Costa changed: What|Removed |Added CC||hugo.pere...@free.fr --- Comment #9 fro

Re: Review Request 121476: Port showdesktop applet to Plasma Next

2014-12-17 Thread Martin Gräßlin
> On Dec. 17, 2014, 1:30 p.m., Vishesh Handa wrote: > > I've tested it out, and it works. > > > > I'm not too sure about the X11 parts, but given that no-one who knows about > > this X11 stuff has commented so far, please ship it. > I'm not too sure about the X11 parts, but given that no-one w

Re: Review Request 121476: Port showdesktop applet to Plasma Next

2014-12-17 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121476/#review72187 --- CMakeLists.txt

Re: Review Request 121476: Port showdesktop applet to Plasma Next

2014-12-17 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121476/#review72173 --- Ship it! I've tested it out, and it works. I'm not too sure

Re: Review Request 121476: Port showdesktop applet to Plasma Next

2014-12-17 Thread Vishesh Handa
> On Dec. 17, 2014, 12:16 p.m., Bhushan Shah wrote: > > applets/showdesktop/CMakeLists.txt, line 18 > > > > > > is this required? maybe port away from KDELibs4Support Lets just ship this for now, and let the port

Re: Review Request 121476: Port showdesktop applet to Plasma Next

2014-12-17 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121476/#review72169 --- applets/showdesktop/CMakeLists.txt

Re: Moving kglobalacceld and framworks < 5.6

2014-12-17 Thread Vishesh Handa
On Wed, Dec 17, 2014 at 11:55 AM, Martin Klapetek wrote: > > This will also mean that plasma 5.2 will not be buildable with frameworks > < 5.6, > is this ok? > Yes. We are already in this situation with Baloo and KFileMetaData. Both of them are going to become frameworks. -- Vishesh Handa

Re: Moving kglobalacceld and framworks < 5.6

2014-12-17 Thread Jonathan Riddell
On Wed, Dec 17, 2014 at 11:55:49AM +0100, Martin Klapetek wrote: >Actually I can't do that as all the frameworks in master still have >version 5.5 and it's only raised on release (?). >This will also mean that plasma 5.2 will not be buildable with frameworks >< 5.6, >is this ok?

Re: Moving kglobalacceld and framworks < 5.6

2014-12-17 Thread Martin Klapetek
On Wed, Dec 17, 2014 at 11:50 AM, Jonathan Riddell wrote: > > On Wed, Dec 17, 2014 at 11:47:13AM +0100, Martin Klapetek wrote: > >Hey, > >so I'm about to move kglobalacceld from plasma-workspace to the > >kglobalaccel framework. > >However, this will mean that plasma 5.2 will not h

Re: Moving kglobalacceld and framworks < 5.6

2014-12-17 Thread Jonathan Riddell
On Wed, Dec 17, 2014 at 11:47:13AM +0100, Martin Klapetek wrote: >Hey, >so I'm about to move kglobalacceld from plasma-workspace to the >kglobalaccel framework. >However, this will mean that plasma 5.2 will not have global shortcuts >with frameworks >< 5.6. >Will plasma

Moving kglobalacceld and framworks < 5.6

2014-12-17 Thread Martin Klapetek
Hey, so I'm about to move kglobalacceld from plasma-workspace to the kglobalaccel framework. However, this will mean that plasma 5.2 will not have global shortcuts with frameworks < 5.6. Will plasma 5.2 hard-depend on frameworks 5.6? If not, how this should be handled? Maybe leave the daemon in

Re: Feedback on xdg-shell from Plasma crew

2014-12-17 Thread Pekka Paalanen
On Mon, 15 Dec 2014 13:16:24 -0800 "Jasper St. Pierre" wrote: > On Mon, Dec 15, 2014 at 5:30 AM, Martin Gräßlin wrote: > > ... > GNOME's view is that window decorations are a part of the application and > part of the application's design space. This matches what most new > applications are doi