Re: Review Request 121424: [GCI2014]Porting Accessibility Config Module away from KDELibs4Support

2014-12-11 Thread Toby Chen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121424/ --- (Updated Dec. 11, 2014, 7:10 p.m.) Status -- This change has been ma

Re: Review Request 121449: Rename "Human Input Devices" to just "Input Devices"

2014-12-11 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121449/#review71835 --- Ship it! Ship It! - Thomas Pfeiffer On Dez. 11, 2014, 2:43

Re: Review Request 121449: Rename "Human Input Devices" to just "Input Devices"

2014-12-11 Thread Thomas Pfeiffer
> On Dez. 11, 2014, 3:57 nachm., Thomas Pfeiffer wrote: > > I'll just comment here to let you know that you're not being ignored. > > From my perspective, just "Input Devices" - while less precise - would work > > as well. I'd like to give Heiko, who came up with the "Human" in the name, > > th

Re: Review Request 121449: Rename "Human Input Devices" to just "Input Devices"

2014-12-11 Thread Martin Klapetek
> On Dec. 11, 2014, 4:57 p.m., Thomas Pfeiffer wrote: > > I'll just comment here to let you know that you're not being ignored. > > From my perspective, just "Input Devices" - while less precise - would work > > as well. I'd like to give Heiko, who came up with the "Human" in the name, > > the

Re: Review Request 121453: Cache QTimeZone for the lifespan of the TimeSource don't recreate every minute

2014-12-11 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121453/#review71832 --- Ship it! Even worse when seconds are on... - Martin Klapetek

Re: Review Request 121453: Cache QTimeZone for the lifespan of the TimeSource don't recreate every minute

2014-12-11 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121453/#review71827 --- Ship it! Ship It! - Jeremy Whiting On Dec. 11, 2014, 2:30

Re: Review Request 121453: Cache QTimeZone for the lifespan of the TimeSource don't recreate every minute

2014-12-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121453/ --- (Updated Dec. 11, 2014, 9:30 p.m.) Review request for Plasma. Repositor

Review Request 121453: Cache QTimeZone for the lifespan of the TimeSource don't recreate every minute

2014-12-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121453/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 121424: [GCI2014]Porting Accessibility Config Module away from KDELibs4Support

2014-12-11 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121424/#review71826 --- Ship it! Ship It! - Jeremy Whiting On Dec. 11, 2014, 1:52

Re: Review Request 121424: [GCI2014]Porting Accessibility Config Module away from KDELibs4Support

2014-12-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121424/#review71825 --- Ship it! - David Edmundson On Dec. 11, 2014, 8:52 p.m., Tob

Re: Review Request 121424: [GCI2014]Porting Accessibility Config Module away from KDELibs4Support

2014-12-11 Thread Toby Chen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121424/ --- (Updated Dec. 11, 2014, 3:52 p.m.) Review request for Plasma and David Ed

Re: Review Request 121424: [GCI2014]Porting Accessibility Config Module away from KDELibs4Support

2014-12-11 Thread Toby Chen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121424/ --- (Updated Dec. 11, 2014, 3:51 p.m.) Review request for Plasma and David Ed

Review Request 121452: Call matchSessionComplete of RunnerManager in milou

2014-12-11 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121452/ --- Review request for Plasma and Vishesh Handa. Bugs: 339972 http://bugs

Re: Review Request 121411: Don't trigger animation if size changed.

2014-12-11 Thread David Edmundson
> On Dec. 9, 2014, 6:11 p.m., Kai Uwe Broulik wrote: > > Wasn't that part of the idea? Having it scale up the pixmap first when > > resizing and then re-rendering it later? > > Xuetian Weng wrote: > 1. icon size (the widget size) doesn't change frequently. Usually it only > happens when us

Re: Review Request 121411: Don't trigger animation if size changed.

2014-12-11 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121411/ --- (Updated Dec. 11, 2014, 7:49 p.m.) Status -- This change has been ma

Re: Plasma 5.2 parts

2014-12-11 Thread Jonathan Riddell
It was poinsted out that sddm-kcm is to be added, it's gone through kdereview and I've filed a ticket with sysadmin to move to kde/workspace https://sysadmin.kde.org/tickets/index.php?page=tickets&act=doadd http://thread.gmane.org/gmane.comp.kde.devel.core/84629 Jonathan On 11 December 2014 at

Re: Review Request 121449: Rename "Human Input Devices" to just "Input Devices"

2014-12-11 Thread Lukáš Tinkl
> On Pro. 11, 2014, 6:01 odp., Heiko Tietze wrote: > > Isn't the term HID very common? "Human interface device" (or input) to > > distinguish it from network cable, or the like, that are rather for the > > pets to play with. But I don't stick to the name. > > Aleix Pol Gonzalez wrote: > To

Re: Review Request 121449: Rename "Human Input Devices" to just "Input Devices"

2014-12-11 Thread Aleix Pol Gonzalez
> On Dec. 11, 2014, 5:01 p.m., Heiko Tietze wrote: > > Isn't the term HID very common? "Human interface device" (or input) to > > distinguish it from network cable, or the like, that are rather for the > > pets to play with. But I don't stick to the name. To me HID is mostly a technical term.

Re: Plasma 5.2 parts

2014-12-11 Thread Jonathan Riddell
On Thu, Dec 11, 2014 at 03:10:46PM +0100, Jan Grulich wrote: > I think print-manager can be included, it works and I didn't notice any > problem yet, at least with the applet. I just tried it, all good except for one bug I filed https://bugs.kde.org/show_bug.cgi?id=341780 CCing dantii incase he

Re: Qt 5.4

2014-12-11 Thread Aleix Pol
On Wed, Dec 10, 2014 at 4:26 PM, Eike Hein wrote: > > > On 12/10/2014 04:14 PM, Aleix Pol wrote: >> >> On Wed, Dec 10, 2014 at 4:10 PM, Eike Hein > > wrote: >> >> >> There's a bunch of unsolved new regressions (e.g. DND of files is >> broken on 5.4) but nothing out of

Re: Review Request 121449: Rename "Human Input Devices" to just "Input Devices"

2014-12-11 Thread Heiko Tietze
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121449/#review71816 --- Isn't the term HID very common? "Human interface device" (or i

Plasma 5.1.2 tars up

2014-12-11 Thread Jonathan Riddell
Plasma 5.1.2 tars are up http://starsky.19inch.net/~jr/tmp/plasma-5.1.2/ and coming soon to depot. Please check them for sanity. Release is due on Tuesday. Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/lis

[Powerdevil] [Bug 341775] New: Powerdevil kded triggers kded5 loop

2014-12-11 Thread Hrvoje Senjan
https://bugs.kde.org/show_bug.cgi?id=341775 Bug ID: 341775 Summary: Powerdevil kded triggers kded5 loop Product: Powerdevil Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severity: grav

Re: Review Request 121449: Rename "Human Input Devices" to just "Input Devices"

2014-12-11 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121449/#review71814 --- I'll just comment here to let you know that you're not being i

Re: Review Request 121449: Rename "Human Input Devices" to just "Input Devices"

2014-12-11 Thread Martin Gräßlin
> On Dec. 11, 2014, 4:19 p.m., Martin Gräßlin wrote: > > -1: there was probably a good reason to name it like that as the renaming > > process was done by our usability experts. We shouldn't dismiss their > > feedback just because we think it sounds strange. > > Eike Hein wrote: > At the s

Re: Review Request 121449: Rename "Human Input Devices" to just "Input Devices"

2014-12-11 Thread Martin Klapetek
> On Dec. 11, 2014, 4:19 p.m., Martin Gräßlin wrote: > > -1: there was probably a good reason to name it like that as the renaming > > process was done by our usability experts. We shouldn't dismiss their > > feedback just because we think it sounds strange. > > Eike Hein wrote: > At the s

Re: Plasma 5.2 parts

2014-12-11 Thread Jeremy Whiting
Also possibly ksshaskpass, which has been in kdereview since early november. On Thu, Dec 11, 2014 at 7:11 AM, Jonathan Riddell wrote: > On Thu, Dec 11, 2014 at 03:09:10PM +0100, Daniel Vrátil wrote: > > Yes. I'll submit kscreen and libkscreen for review and move it to > workspace, > > as we disc

Re: Review Request 121449: Rename "Human Input Devices" to just "Input Devices"

2014-12-11 Thread Eike Hein
> On Dec. 11, 2014, 3:25 p.m., Lukáš Tinkl wrote: > > +1 > > > > And I actually wonder how the thing is translated in other languages > > because in Czech, I omitted the word "Human" on purpose as there is no way > > I could make it meaningful w/o looking like an alien word. Looking at the .

Re: Review Request 121449: Rename "Human Input Devices" to just "Input Devices"

2014-12-11 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121449/#review71810 --- +1 And I actually wonder how the thing is translated in othe

Re: Re: kcm-touchpad in plasma 5.2?

2014-12-11 Thread David Edmundson
In general this looks OK, there's some useful features and I can see myself using this. I'd very much like it to become part of Plasma. I gave it a review and made some notes below. kded.cpp The touchpad backend leaks? There are blocking calls in the constructor using isServiceRegistered combine

Re: Review Request 121449: Rename "Human Input Devices" to just "Input Devices"

2014-12-11 Thread Eike Hein
> On Dec. 11, 2014, 3:19 p.m., Martin Gräßlin wrote: > > -1: there was probably a good reason to name it like that as the renaming > > process was done by our usability experts. We shouldn't dismiss their > > feedback just because we think it sounds strange. At the same time it's clear that KD

Re: Review Request 121449: Rename "Human Input Devices" to just "Input Devices"

2014-12-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121449/#review71808 --- -1: there was probably a good reason to name it like that as t

Fwd: Re: kcm-touchpad in plasma 5.2?

2014-12-11 Thread Jonathan Riddell
- Forwarded message from Alexander Mezin - Date: Thu, 11 Dec 2014 21:15:53 +0600 Subject: Re: kcm-touchpad in plasma 5.2? From: Alexander Mezin To: Jonathan Riddell Cc: Rajeesh K Nambiar Hi. I had plans on rewriting kcm-touchpad from scratch, but now it seems I won't have time for it

Re: Review Request 121449: Rename "Human Input Devices" to just "Input Devices"

2014-12-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121449/#review71807 --- +1 - Aleix Pol Gonzalez On Dec. 11, 2014, 2:43 p.m., Martin

Re: Review Request 121449: Rename "Human Input Devices" to just "Input Devices"

2014-12-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121449/#review71806 --- +1 - David Edmundson On Dec. 11, 2014, 2:43 p.m., Martin Kl

Review Request 121449: Rename "Human Input Devices" to just "Input Devices"

2014-12-11 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121449/ --- Review request for Plasma and KDE Usability. Repository: systemsettings

kcm-touchpad in plasma 5.2?

2014-12-11 Thread Jonathan Riddell
Morning, I'm looking at the requirements for Plasma to become a complete desktop and touchpad configuration is currently missing. You've done the port of kcm-touchpad to KF5, do you think it should be included with Plasma 5.2 ? Jonathan ___ Plasma-devel

Re: Plasma 5.2 parts

2014-12-11 Thread Jonathan Riddell
On Thu, Dec 11, 2014 at 03:09:10PM +0100, Daniel Vrátil wrote: > Yes. I'll submit kscreen and libkscreen for review and move it to workspace, > as we discussed. libkscreen is in already, just kscreen to review/move Jonathan ___ Plasma-devel mailing lis

Re: Plasma 5.2 parts

2014-12-11 Thread Jan Grulich
Hi, On Thursday 11 of December 2014 15:07 Jonathan Riddell wrote: > 5.1.2 tars are made so it's time to be thinking about what needs included > in Plasma 5.2 > > New in will be Muon package manager and gtk-config, these have already gone > through review. > > polkit-kde is currently going throug

Re: Plasma 5.2 parts

2014-12-11 Thread Daniel Vrátil
On Thursday, December 11, 2014 03:07:04 PM Jonathan Riddell wrote: > 5.1.2 tars are made so it's time to be thinking about what needs included > in Plasma 5.2 > > New in will be Muon package manager and gtk-config, these have already gone > through review. > > polkit-kde is currently going throug

Plasma 5.2 parts

2014-12-11 Thread Jonathan Riddell
5.1.2 tars are made so it's time to be thinking about what needs included in Plasma 5.2 New in will be Muon package manager and gtk-config, these have already gone through review. polkit-kde is currently going through review and if nobody objects can go into kde-workspace next week. Please revie

Change in plasma-framework[master]: Use the same text colour for comboboxes as buttons

2014-12-11 Thread David Edmundson (Code Review)
David Edmundson has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/219 Change subject: Use the same text colour for comboboxes as buttons .. Use the same text colour for comboboxes as buttons Given comb

Re: [plasma-devel] Qt 5.4

2014-12-11 Thread Jonathan Riddell
No objections to this so I'll switch it over Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121402: Allow user to customise wallpaper used in the lock screen.

2014-12-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121402/ --- (Updated Dec. 11, 2014, 1:24 p.m.) Status -- This change has been ma

Re: Re: PlasmaCore::Dialog and QQuickRenderControl

2014-12-11 Thread Martin Gräßlin
On Thursday 11 December 2014 14:07:30 Marco Martin wrote: > On Thursday 11 December 2014, Martin Gräßlin wrote: > > > you mean it would still be possible to use qwindows as dialogs, but just > > > create them in a different way? > > > > yes > > ah, internal api... splendid > > > > > Any ideas ho

Re: PlasmaCore::Dialog and QQuickRenderControl

2014-12-11 Thread Marco Martin
On Thursday 11 December 2014, Martin Gräßlin wrote: > > you mean it would still be possible to use qwindows as dialogs, but just > > create them in a different way? > > yes ah, internal api... splendid > > > Any ideas how we could solve this problem? Could we make Dialog > > > wrapping a QQuickW

Re: Re: PlasmaCore::Dialog and QQuickRenderControl

2014-12-11 Thread Martin Gräßlin
On Thursday 11 December 2014 13:51:06 Marco Martin wrote: > On Thursday 11 December 2014, Martin Gräßlin wrote: > > Unfortunately one can only use the QQuickRenderControl if one creates the > > QQuickWindow with the ctor taking a QQuickRenderControl* argument. So for > > all cases where a PlasmaCor

Re: PlasmaCore::Dialog and QQuickRenderControl

2014-12-11 Thread Marco Martin
On Thursday 11 December 2014, Martin Gräßlin wrote: > Unfortunately one can only use the QQuickRenderControl if one creates the > QQuickWindow with the ctor taking a QQuickRenderControl* argument. So for > all cases where a PlasmaCore.Dialog is instantiated in QML this cannot > work. you mean it w

PlasmaCore::Dialog and QQuickRenderControl

2014-12-11 Thread Martin Gräßlin
Hi, I'm currently hitting a problem where I don't know what to do about it. In KWin we use PlasmaCore::Dialog a lot (e.g. in Alt+Tab). Now with Qt 5.4 I would like to get all QQuickWindows to use QQuickRenderControl. The reason for this is that it would allow us the following: * make KWin's Ope

Re: Review Request 121439: systemtrayicon: pass icon’s name(), not themeName() to showMessage

2014-12-11 Thread Dmitry Shachnev
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121439/ --- (Updated Dec. 11, 2014, 12:32 p.m.) Status -- This change has been m

Re: Review Request 121439: systemtrayicon: pass icon’s name(), not themeName() to showMessage

2014-12-11 Thread Dmitry Shachnev
> On Dez. 11, 2014, 12:18 nachm., Martin Klapetek wrote: > > Btw. do you have an actual bug where this can be seen/tested? Good spot > > otherwise! > > Martin Gräßlin wrote: > I had seen something which I did not understand in the past: owncloud > sync client was for a short time Qt 5.3 ba

Re: Review Request 121439: systemtrayicon: pass icon’s name(), not themeName() to showMessage

2014-12-11 Thread Dmitry Shachnev
> On Dez. 11, 2014, 10:42 vorm., Dmitry Shachnev wrote: > > Ship It! > > Martin Gräßlin wrote: > do you have commit rights or should someone push the change for you? No, I don't have rights. Actually this is my first contribution to KDE :) So please push it for me (and sorry for useless no

Re: Review Request 121439: systemtrayicon: pass icon’s name(), not themeName() to showMessage

2014-12-11 Thread Martin Gräßlin
> On Dec. 11, 2014, 1:18 p.m., Martin Klapetek wrote: > > Btw. do you have an actual bug where this can be seen/tested? Good spot > > otherwise! I had seen something which I did not understand in the past: owncloud sync client was for a short time Qt 5.3 based and the icon was just broken and

Re: Review Request 121439: systemtrayicon: pass icon’s name(), not themeName() to showMessage

2014-12-11 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121439/#review71793 --- Btw. do you have an actual bug where this can be seen/tested?

Re: Review Request 121439: systemtrayicon: pass icon’s name(), not themeName() to showMessage

2014-12-11 Thread Martin Gräßlin
> On Dec. 11, 2014, 11:42 a.m., Dmitry Shachnev wrote: > > Ship It! do you have commit rights or should someone push the change for you? - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kd

Re: Review Request 121439: systemtrayicon: pass icon’s name(), not themeName() to showMessage

2014-12-11 Thread Dmitry Shachnev
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121439/#review71787 --- Ship it! Ship It! - Dmitry Shachnev On Dez. 11, 2014, 8:26

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-12-11 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/#review71785 --- what's the status of this? - Marco Martin On Oct. 17, 2014,

Re: Review Request 121411: Don't trigger animation if size changed.

2014-12-11 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121411/#review71784 --- Ship it! Ship It! - Marco Martin On Dec. 11, 2014, 3:55 a.

Re: Review Request 121439: systemtrayicon: pass icon’s name(), not themeName() to showMessage

2014-12-11 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121439/#review71783 --- Ship it! Ship It! - Marco Martin On Dec. 11, 2014, 8:26 a.

Change in plasma-framework[master]: Different themes between desktop and dialogs

2014-12-11 Thread Marco Martin (Code Review)
Marco Martin has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/218 Change subject: Different themes between desktop and dialogs .. Different themes between desktop and dialogs different themes betwee

Re: Review Request 121402: Allow user to customise wallpaper used in the lock screen.

2014-12-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121402/#review71782 --- Ship it! Ship It! - Martin Gräßlin On Dec. 10, 2014, 3:47

[Breeze] [Bug 341762] When utilizing the Breeze theme for SDDM, it takes ages for SDDM to startup.

2014-12-11 Thread Raymond Wooninck
https://bugs.kde.org/show_bug.cgi?id=341762 Raymond Wooninck changed: What|Removed |Added Resolution|WAITINGFORINFO |--- Status|NEEDSINFO

[Breeze] [Bug 341762] When utilizing the Breeze theme for SDDM, it takes ages for SDDM to startup.

2014-12-11 Thread Raymond Wooninck
https://bugs.kde.org/show_bug.cgi?id=341762 --- Comment #3 from Raymond Wooninck --- Created attachment 89916 --> https://bugs.kde.org/attachment.cgi?id=89916&action=edit journalctl -b output with Maldives theme active for SDDM -- You are receiving this mail because: You are the assignee for

[Breeze] [Bug 341762] When utilizing the Breeze theme for SDDM, it takes ages for SDDM to startup.

2014-12-11 Thread Raymond Wooninck
https://bugs.kde.org/show_bug.cgi?id=341762 --- Comment #2 from Raymond Wooninck --- Created attachment 89915 --> https://bugs.kde.org/attachment.cgi?id=89915&action=edit journalctl -b output with Breeze theme active for SDDM -- You are receiving this mail because: You are the assignee for th

Re: Review Request 121439: systemtrayicon: pass icon’s name(), not themeName() to showMessage

2014-12-11 Thread Dmitry Shachnev
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121439/ --- (Updated Dec. 11, 2014, 9:26 a.m.) Review request for Plasma and Martin G