date:20141208

Re: Review Request 121396: fix touchpad scrolling on task manager

2014-12-08 Thread Xuetian Weng

> On Dec. 9, 2014, 12:36 a.m., Aleix Pol Gonzalez wrote: > > applets/taskmanager/package/contents/code/tools.js, line 22 > > > > > > so why don't you use the angleDelta? It's not WheelEvent produced by MouseArea.

Re: Review Request 121396: fix touchpad scrolling on task manager

2014-12-08 Thread Aleix Pol Gonzalez

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121396/#review71604 --- applets/taskmanager/package/contents/code/tools.js

Re: Review Request 121219: Load IconItem immediately upon componentComplete()

2014-12-08 Thread Aleix Pol Gonzalez

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121219/#review71601 --- +1 Looks good to me - Aleix Pol Gonzalez On Dec. 5, 2014,

Review Request 121398: Drop configuration page that does nothing

2014-12-08 Thread Albert Astals Cid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121398/ --- Review request for Plasma, David Edmundson and Martin Klapetek. Repositor

Re: Review Request 121357: Don't allow changing the volume when playing a notification

2014-12-08 Thread Albert Astals Cid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121357/ --- (Updated des. 8, 2014, 10:42 p.m.) Status -- This change has been di

Re: Review Request 121396: fix touchpad scrolling on task manager

2014-12-08 Thread Xuetian Weng

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121396/ --- (Updated Dec. 8, 2014, 9:44 p.m.) Review request for Plasma, Aleix Pol Go

Review Request 121396: fix touchpad scrolling on task manager

2014-12-08 Thread Xuetian Weng

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121396/ --- Review request for Plasma and Aleix Pol Gonzalez. Repository: plasma-desk

Change in plasma-framework[master]: Make tooltipEnabledGlobally public property

2014-12-08 Thread Bhushan Shah (Code Review)

Bhushan Shah has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/207 Change subject: Make tooltipEnabledGlobally public property .. Make tooltipEnabledGlobally public property This is case when some user

Re: Review Request 121365: Update brightness availability at runtime

2014-12-08 Thread Sebastian Kügler

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121365/#review71552 --- Ship it! It *looks* sane to me, but I'm not 100% comfortable