Re: Review Request 121057: Refactor JobDelegate

2014-11-10 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121057/ --- (Updated Nov. 10, 2014, 9:01 p.m.) Status -- This change has been ma

Re: Review Request 121085: Migrate ProgressBar to QtQuick.Controls

2014-11-10 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121085/ --- (Updated Nov. 10, 2014, 9:11 p.m.) Status -- This change has been ma

[Breeze] [Bug 340580] KDE Apps' toolbars and dialog options don't have icons just empty spaces.

2014-11-10 Thread donniezazen
https://bugs.kde.org/show_bug.cgi?id=340580 donniezazen changed: What|Removed |Added Status|RESOLVED|UNCONFIRMED Resolution|WORKSFORME

Re: KPackage framework

2014-11-10 Thread Marco Martin
On Monday 10 November 2014, Marco Martin wrote: > * porting all the internal and api use of KPluginInfo to KPluginMetadata > * removing all the query functionality, (since it needs > KPluginTrader::applyConstraints) and making instead KPluginTrader able to > find packages as well > > Opinions? com

Review Request 121097: Add a FileDialog to choose the image for fifteenpuzzle.

2014-11-10 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121097/ --- Review request for Plasma, David Edmundson, Eike Hein, and Marco Martin.

Re: Review Request 120949: Add imageprovider to fifteenpuzzle.

2014-11-10 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120949/ --- (Updated Nov. 10, 2014, 5:57 p.m.) Status -- This change has been ma

Re: Review Request 120949: Add imageprovider to fifteenpuzzle.

2014-11-10 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120949/#review70207 --- Ship it! Inviala! - Marco Martin On Nov. 6, 2014, 2:23 a.m

Re: Review Request 120949: Add imageprovider to fifteenpuzzle.

2014-11-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120949/#review70206 --- Ship it! Fine with me. Check Marco is happy as he didn't se

Re: Review Request 121057: Refactor JobDelegate

2014-11-10 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121057/#review70201 --- Ship it! Looks good! applets/notifications/package/contents

Re: Review Request 121031: keep libmolletnetwork private

2014-11-10 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121031/ --- (Updated Nov. 10, 2014, 2:38 p.m.) Status -- This change has been ma

Re: Review Request 121031: keep libmolletnetwork private

2014-11-10 Thread Harald Sitter
> On Nov. 10, 2014, 2:02 p.m., Aleix Pol Gonzalez wrote: > > In fact, I have the feeling this could be done in other places as well... There were already a bunch of these changes. Looking at the Kubuntu packaging (i.e. assuming the packaging is correctly not packaging private .so links) this

Re: plasma-mediacenter: master going Qt5/KF5 based

2014-11-10 Thread Aleix Pol
On Mon, Nov 10, 2014 at 2:44 PM, Bhushan Shah wrote: > Hello! > > Plasma mediacenter team have decided to > > - branch 1.4 from master branch and it will be last kdelibs4 based release > [1] > - merge frameworks to master, so that master branch becomes KF5/Qt5 based > > If you have any questions,

Re: Review Request 121031: keep libmolletnetwork private

2014-11-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121031/#review70184 --- Ship it! In fact, I have the feeling this could be done in o

Re: Review Request 121031: keep libmolletnetwork private

2014-11-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121031/#review70183 --- Ship it! Ship It! - David Edmundson On Nov. 7, 2014, 11:42

plasma-mediacenter: master going Qt5/KF5 based

2014-11-10 Thread Bhushan Shah
Hello! Plasma mediacenter team have decided to - branch 1.4 from master branch and it will be last kdelibs4 based release [1] - merge frameworks to master, so that master branch becomes KF5/Qt5 based If you have any questions, objection please ask.. Thanks [1] https://community.kde.org/Plasma/

Re: Minutes Monday Plasma Hangout

2014-11-10 Thread David Edmundson
Sorry I didn't make it to the meeting. My week: - Monday-Wednesday fixing all the things in SystemSettings 5.x. Done most, about ~15 open reports remain. - Fixed a security issue - Thursday-Friday creating a super secret logind dbus API wrapper: http://quickgit.kde.org/?p=scratch%2Fdavidedmu

KPackage framework

2014-11-10 Thread Marco Martin
Hi all, since at akademy there seemed the interest in it, I have been working on some classes i extracted from libplasma to be on their own, those related to Plasma::Package, since several applications have the interest of having scriptable or anyways non-binary content shippable over ghns. you

Minutes Monday Plasma Hangout

2014-11-10 Thread Marco Martin
Minutes Plasma Hangout, 10-11-2014 Present: Kai Uve, Martin, Sebas, Jens, Marco -Kai Uve * busyIndicator and ProgressBar ported to QtQuickControls * imporovements to panelcontroller * overhaul of notifications and osd: OSD will need a window type: is using noticiation type that does not work

Re: Review Request 121071: Give undo notification a title

2014-11-10 Thread Sebastian Kügler
> On Nov. 10, 2014, 9:45 a.m., Sebastian Kügler wrote: > > src/plasma/private/applet_p.cpp, line 248 > > > > > > panel lowercase? > > Kai Uwe Broulik wrote: > Actually Removed should be uppercase too, it sho

Re: Review Request 121071: Give undo notification a title

2014-11-10 Thread Kai Uwe Broulik
> On Nov. 10, 2014, 9:45 vorm., Sebastian Kügler wrote: > > src/plasma/private/applet_p.cpp, line 248 > > > > > > panel lowercase? Actually Removed should be uppercase too, it should be title capitalization but

Re: Review Request 121071: Give undo notification a title

2014-11-10 Thread Kai Uwe Broulik
> On Nov. 10, 2014, 8:39 vorm., Marco Martin wrote: > > better than nothing.. i think this is one of the cases it would be better > > to not have titles > > Kai Uwe Broulik wrote: > Indeed, the notification would look super sleek without a title, however > there might be broken (especially

Re: Review Request 121071: Give undo notification a title

2014-11-10 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121071/#review70172 --- src/plasma/private/applet_p.cpp

Re: Review Request 121071: Give undo notification a title

2014-11-10 Thread Marco Martin
> On Nov. 10, 2014, 8:39 a.m., Marco Martin wrote: > > better than nothing.. i think this is one of the cases it would be better > > to not have titles > > Kai Uwe Broulik wrote: > Indeed, the notification would look super sleek without a title, however > there might be broken (especially

Re: Review Request 121071: Give undo notification a title

2014-11-10 Thread Kai Uwe Broulik
> On Nov. 10, 2014, 8:39 vorm., Marco Martin wrote: > > better than nothing.. i think this is one of the cases it would be better > > to not have titles Indeed, the notification would look super sleek without a title, however there might be broken (especially third party apps) apps and scripts

Re: Review Request 121085: Migrate ProgressBar to QtQuick.Controls

2014-11-10 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121085/#review70165 --- Ship it! good to go after the notes you already taken (like r

Re: Review Request 121071: Give undo notification a title

2014-11-10 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121071/#review70162 --- Ship it! better than nothing.. i think this is one of the cas