Re: Review Request 120471: Add Registry::sync() signal

2014-10-06 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120471/#review68034 --- src/client/registry.cpp

Re: Review Request 120471: Add Registry::sync() signal

2014-10-06 Thread Martin Gräßlin
> On Oct. 6, 2014, 12:25 p.m., Martin Gräßlin wrote: > > src/client/registry.h, line 407 > > > > > > I would recommend to move it to ConnectionThread as it's more > > connection related then registry related. >

Re: Review Request 120516: introduce bool applicationMode for standalone application mode

2014-10-06 Thread Bhushan Shah
> On Oct. 6, 2014, 11:11 p.m., Marco Martin wrote: > > drkonqi/data/debuggers/internal/gdbrc, line 76 > > > > > > this seems to be unrelated Sorry this is patch to get my drkonqi working.. removed. > On Oct. 6,

Re: Review Request 120516: introduce bool applicationMode for standalone application mode

2014-10-06 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120516/ --- (Updated Oct. 7, 2014, 9:54 a.m.) Review request for Plasma and Marco Mar

Re: Review Request 120471: Add Registry::sync() signal

2014-10-06 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120471/ --- (Updated Oct. 7, 2014, 1:56 a.m.) Review request for kwin, Plasma and Mar

Re: Review Request 120471: Add Registry::sync() signal

2014-10-06 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120471/ --- (Updated Oct. 7, 2014, 1:37 a.m.) Review request for kwin, Plasma and Mar

Re: Review Request 120471: Add Registry::sync() signal

2014-10-06 Thread Sebastian Kügler
> On Oct. 6, 2014, 10:25 a.m., Martin Gräßlin wrote: > > src/client/registry.h, line 407 > > > > > > I would recommend to move it to ConnectionThread as it's more > > connection related then registry related. >

Re: Review Request 120441: [libksysguard] Get rid of KDELibs4Support

2014-10-06 Thread Hrvoje Senjan
> On Oct. 7, 2014, 12:23 a.m., Martin Klapetek wrote: > > Minor issues and +1 to Martin G's note about commented out debugs...imo > > they should just go ok, will remove it in final revision > On Oct. 7, 2014, 12:23 a.m., Martin Klapetek wrote: > > tests/CMakeLists.txt, line 7 > >

Re: Review Request 120441: [libksysguard] Get rid of KDELibs4Support

2014-10-06 Thread Lukáš Tinkl
> On Říj. 7, 2014, 12:23 dop., Martin Klapetek wrote: > > tests/CMakeLists.txt, line 7 > > > > > > Is the I18n still needed here in the tests linkage? I see only the > > signalplottertest.cpp using i18n (and even

Re: Review Request 120441: [libksysguard] Get rid of KDELibs4Support

2014-10-06 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120441/#review68025 --- Minor issues and +1 to Martin G's note about commented out deb

Re: Muon and kde-gtk-config moved to kde/workspace - was - Re: Moving repositories in the module structure

2014-10-06 Thread Albert Astals Cid
El Diumenge, 5 d'octubre de 2014, a les 20:30:33, Albert Astals Cid va escriure: > El Divendres, 3 d'octubre de 2014, a les 03:28:44, Aleix Pol va escriure: > > Changes: > > - kde-gtk-config was moved from extragear/base to kde/workspace. > > - muon was moved from extragear/sysadmin to kde/workspa

Re: Muon and kde-gtk-config moved to kde/workspace - was - Re: Moving repositories in the module structure

2014-10-06 Thread Matthias Klumpp
2014-10-06 19:57 GMT+02:00 Albert Astals Cid : > El Dilluns, 6 d'octubre de 2014, a les 01:30:47, Aleix Pol va escriure: >> [...] >> I don't expect to compete with Apper. Muon Discover is a software center >> and that's the main solution I'm pushing here, as I explained in Plasma. >> Apper is a pac

Re: Review Request 120513: Set the shortcut for running ksysguard as global

2014-10-06 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120513/ --- (Updated Oct. 6, 2014, 7:09 p.m.) Status -- This change has been mar

Re: Review Request 120513: Set the shortcut for running ksysguard as global

2014-10-06 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120513/#review68018 --- Ship it! Ship It! - Martin Gräßlin On Oct. 6, 2014, 7:41 p

Re: Muon and kde-gtk-config moved to kde/workspace - was - Re: Moving repositories in the module structure

2014-10-06 Thread Albert Astals Cid
El Dilluns, 6 d'octubre de 2014, a les 01:30:47, Aleix Pol va escriure: > On Sun, Oct 5, 2014 at 8:30 PM, Albert Astals Cid wrote: > > El Divendres, 3 d'octubre de 2014, a les 03:28:44, Aleix Pol va escriure: > > > On Fri, Oct 3, 2014 at 1:52 AM, Albert Astals Cid wrote: > > > > El Divendres, 3 d

Re: Review Request 120516: introduce bool applicationMode for standalone application mode

2014-10-06 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120516/#review68016 --- I would go for it, but I would flip the logic, instead of an a

Re: Review Request 120513: Set the shortcut for running ksysguard as global

2014-10-06 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120513/ --- (Updated Oct. 6, 2014, 7:41 p.m.) Review request for Plasma and Martin Gr

Re: Review Request 120516: introduce bool applicationMode for standalone application mode

2014-10-06 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120516/#review68014 --- I am not sure i like exposing a bool, may be the only way. fo

Review Request 120516: introduce bool applicationMode for standalone application mode

2014-10-06 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120516/ --- Review request for Plasma and Marco Martin. Repository: plasma-workspace

Re: Review Request 120441: [libksysguard] Get rid of KDELibs4Support

2014-10-06 Thread Martin Gräßlin
> On Oct. 6, 2014, 5:21 p.m., Martin Gräßlin wrote: > > processui/ProcessModel.cpp, line 568 > > > > > > why change in the comment? > > Hrvoje Senjan wrote: > someone might uncomment this without realizing t

Re: Review Request 120441: [libksysguard] Get rid of KDELibs4Support

2014-10-06 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120441/ --- (Updated Oct. 6, 2014, 6:29 p.m.) Review request for Plasma. Changes --

Re: Review Request 120441: [libksysguard] Get rid of KDELibs4Support

2014-10-06 Thread Lukáš Tinkl
> On Říj. 6, 2014, 5:21 odp., Martin Gräßlin wrote: > > processui/ProcessModel.cpp, lines 91-106 > > > > > > you seem to be losing the precision here. > > Hrvoje Senjan wrote: > that's true, but i haven't fou

Re: Review Request 120441: [libksysguard] Get rid of KDELibs4Support

2014-10-06 Thread Hrvoje Senjan
> On Oct. 6, 2014, 5:28 p.m., Martin Klapetek wrote: > > processui/ProcessModel.cpp, line 146 > > > > > > How is this sorted out instead? should be substituted with add_definitions(-DTRANSLATION_DOMAIN=\"process

Re: Review Request 120441: [libksysguard] Get rid of KDELibs4Support

2014-10-06 Thread Hrvoje Senjan
> On Oct. 6, 2014, 5:21 p.m., Martin Gräßlin wrote: > > processui/ProcessModel.cpp, line 568 > > > > > > why change in the comment? someone might uncomment this without realizing there's no KDELibs4Support here

Re: Review Request 120441: [libksysguard] Get rid of KDELibs4Support

2014-10-06 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120441/#review68007 --- Ship it! Looks good, couple remarks below processui/Process

Re: Review Request 120441: [libksysguard] Get rid of KDELibs4Support

2014-10-06 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120441/#review68006 --- processui/ProcessModel.cpp

Re: Review Request 120515: Use QLineEdit rather than KLineEdit in libksysguard

2014-10-06 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120515/ --- (Updated Oct. 6, 2014, 3:16 p.m.) Status -- This change has been mar

Re: Review Request 120441: [libksysguard] Get rid of KDELibs4Support

2014-10-06 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120441/#review68004 --- ping.. - Hrvoje Senjan On Sept. 30, 2014, 7:40 p.m., Hrvoje

Re: Review Request 120515: Use QLineEdit rather than KLineEdit in libksysguard

2014-10-06 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120515/#review68003 --- Ship it! Ship It! - Martin Gräßlin On Oct. 6, 2014, 5 p.m.

Review Request 120515: Use QLineEdit rather than KLineEdit in libksysguard

2014-10-06 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120515/ --- Review request for Plasma. Repository: libksysguard Description ---

Re: black window on qml kcms

2014-10-06 Thread David Edmundson
Short term: sure. Make sure it's documented as to why in the code. According to aleix and andreas its mostly fixed in qt 5.4, so we should be able to revert it for plasma 5.2. On 6 Oct 2014 14:04, "Marco Martin" wrote: > Hi all, > > since i'm growing a bit tired about those black screens in kc

Re: Review Request 120513: Set the shortcut for running ksysguard as global

2014-10-06 Thread Martin Gräßlin
> On Okt. 6, 2014, 4:18 nachm., Lukáš Tinkl wrote: > > systemmonitor/kdedksysguard.cpp, line 57 > > > > > > It doesn't have to be a QList() even if it were a list I would recommend to use the initializer list ins

Re: Review Request 120513: Set the shortcut for running ksysguard as global

2014-10-06 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120513/#review67994 --- systemmonitor/kdedksysguard.cpp

Review Request 120513: Set the shortcut for running ksysguard as global

2014-10-06 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120513/ --- Review request for Plasma and Martin Gräßlin. Repository: plasma-workspac

Re: black window on qml kcms

2014-10-06 Thread Marco Martin
On Monday 06 October 2014, Martin Gräßlin wrote: > On Monday 06 October 2014 14:04:16 Marco Martin wrote: > > Hi all, > > > > since i'm growing a bit tired about those black screens in kcms that use > > qml, i was thinking for the time being to switch to the newer (and > > supposedly better) QQuic

Jenkins build became unstable: plasma-desktop_master_qt5 #684

2014-10-06 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: black window on qml kcms

2014-10-06 Thread Marco Martin
On Monday 06 October 2014, Sebastian Kügler wrote: > On Monday, October 06, 2014 14:04:16 Marco Martin wrote: > > since i'm growing a bit tired about those black screens in kcms that use > > qml, i was thinking for the time being to switch to the newer (and > > supposedly better) QQuickWidget to th

Re: black window on qml kcms

2014-10-06 Thread Marco Martin
On Monday 06 October 2014, Martin Gräßlin wrote: > On Monday 06 October 2014 14:04:16 Marco Martin wrote: > > Hi all, > > > > since i'm growing a bit tired about those black screens in kcms that use > > qml, i was thinking for the time being to switch to the newer (and > > supposedly better) QQuic

Re: black window on qml kcms

2014-10-06 Thread Sebastian Kügler
On Monday, October 06, 2014 14:04:16 Marco Martin wrote: > since i'm growing a bit tired about those black screens in kcms that use > qml, i was thinking for the time being to switch to the newer (and > supposedly better) QQuickWidget to the old (and hack-y xembed-y) > QWidget::createWindowContaine

Re: black window on qml kcms

2014-10-06 Thread Martin Gräßlin
On Monday 06 October 2014 14:04:16 Marco Martin wrote: > Hi all, > > since i'm growing a bit tired about those black screens in kcms that use > qml, i was thinking for the time being to switch to the newer (and > supposedly better) QQuickWidget to the old (and hack-y xembed-y) > QWidget::createWin

black window on qml kcms

2014-10-06 Thread Marco Martin
Hi all, since i'm growing a bit tired about those black screens in kcms that use qml, i was thinking for the time being to switch to the newer (and supposedly better) QQuickWidget to the old (and hack-y xembed-y) QWidget::createWindowContainer will be slower, hackier, but i don't think we can r

[Breeze] [Bug 338979] Breeze window decoration adds spacing around the windeco

2014-10-06 Thread Martin Gräßlin
https://bugs.kde.org/show_bug.cgi?id=338979 Martin Gräßlin changed: What|Removed |Added Assignee|kwin-bugs-n...@kde.org |plasma-devel@kde.org Component|aurora

[Breeze] [Bug 339725] Breeze window decoration adds spacing around the window

2014-10-06 Thread Martin Klapetek
https://bugs.kde.org/show_bug.cgi?id=339725 Martin Klapetek changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

[Breeze] [Bug 339725] New: Breeze window decoration adds spacing around the window

2014-10-06 Thread donniezazen
https://bugs.kde.org/show_bug.cgi?id=339725 Bug ID: 339725 Summary: Breeze window decoration adds spacing around the window Product: Breeze Version: 5.0.1 Platform: Fedora RPMs OS: Linux Status:

Re: Review Request 120471: Add Registry::sync() signal

2014-10-06 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120471/#review67980 --- src/client/registry.h

Minutes Monday Plasma Hangout

2014-10-06 Thread Sebastian Kügler
Minutes Plasma Hangout, 6-10-2014 Present: Antonis, Kai Uwe, Jonathan, Martin K, Marco, Martin G, Harald, Sebastian For updates on TODO/status, see also Kanban board at: https://todo.kde.org/?controller=board&action=show&project_id=13 Antonis: - Finished exams - Now planning to work on Plasma

Re: Re: Collecting new/improved stuff in 5.1 for promo

2014-10-06 Thread Martin Gräßlin
On Tuesday 30 September 2014 01:04:12 David Edmundson wrote: > we'll want a sentence or 2 about Wayland to show progress (kwayland lib > etc.) * new binary kwin_wayland * kwin_wayland supports starting the X-Server it needs to connect to * Wayland (client) connection is hold in a thread * Support

Re: Review Request 120500: Remove VLC workaround

2014-10-06 Thread Martin Klapetek
> On Oct. 5, 2014, 3:11 p.m., Martin Klapetek wrote: > > > VLC no longer seems to be exposing multiple mpris interfaces > > > > Kubuntu 14.04, VLC 2.1.4 and I still see two mpris interfaces. I'll try the > > patch out in the evening. > > Kai Uwe Broulik wrote: > Kubuntu 14.10, VLC 2.2.0-pr