Review Request 120471: Add Registry::sync() signal

2014-10-02 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120471/ --- Review request for kwin, Plasma and Martin Gräßlin. Repository: kwayland

Re: Moving repositories in the module structure

2014-10-02 Thread Aleix Pol
On Fri, Oct 3, 2014 at 1:52 AM, Albert Astals Cid wrote: > El Divendres, 3 d'octubre de 2014, a les 00:04:42, Aleix Pol va escriure: > > On Thu, Oct 2, 2014 at 11:34 PM, Ben Cooksley wrote: > > > Hi all, > > > > > > It seems there has been a recent outbreak of repository moves which > > > have b

Re: Moving repositories in the module structure

2014-10-02 Thread Albert Astals Cid
El Divendres, 3 d'octubre de 2014, a les 00:04:42, Aleix Pol va escriure: > On Thu, Oct 2, 2014 at 11:34 PM, Ben Cooksley wrote: > > Hi all, > > > > It seems there has been a recent outbreak of repository moves which > > have been extremely poorly co-ordinated by those doing the requests. > > >

Re: Moving repositories in the module structure

2014-10-02 Thread Víctor Blázquez
I'm sorry for doing the move that fast, I should have realized it was sent only to plasma-devel Víctor Blázquez On Fri, Oct 3, 2014 at 12:04 AM, Aleix Pol wrote: > On Thu, Oct 2, 2014 at 11:34 PM, Ben Cooksley wrote: > >> Hi all, >> >> It seems there has been a recent outbreak of repository mo

Re: Moving repositories in the module structure

2014-10-02 Thread Aleix Pol
On Thu, Oct 2, 2014 at 11:34 PM, Ben Cooksley wrote: > Hi all, > > It seems there has been a recent outbreak of repository moves which > have been extremely poorly co-ordinated by those doing the requests. > > In addition, it is actually a requirement that modules moving from > Extragear into (wh

Re: 10000 lines change in kdeplasma-addons 4.14 branch

2014-10-02 Thread Albert Astals Cid
El Dijous, 2 d'octubre de 2014, a les 16:41:38, Weng Xuetian va escriure: > Hi, > Sorry for all the trouble. > > Sho on irc asked me that he want to test the ibus 1.5 support easier so I > get it merged for kde4. Unfortunately there's no further kdeplamsa-addons > for kde4 and I didn't finish this

Moving repositories in the module structure

2014-10-02 Thread Ben Cooksley
Hi all, It seems there has been a recent outbreak of repository moves which have been extremely poorly co-ordinated by those doing the requests. In addition, it is actually a requirement that modules moving from Extragear into (what was at least) the SC need to re-transit through KDE Review.It is

Re: 10000 lines change in kdeplasma-addons 4.14 branch

2014-10-02 Thread Weng Xuetian
Hi, Sorry for all the trouble. Sho on irc asked me that he want to test the ibus 1.5 support easier so I get it merged for kde4. Unfortunately there's no further kdeplamsa-addons for kde4 and I didn't finish this before 4.14, so it's also either leave it broken in kde4 or add a usable version. Th

10000 lines change in kdeplasma-addons 4.14 branch

2014-10-02 Thread Albert Astals Cid
Hi Weng, I have been just told you just merged your origin/xuetianweng/kimpanel-ibus-1.5 into KDE/4.14 in the kdeplasma-addons repo That brings 27 files changed, 10677 insertions(+), 1424 deletions(-) Has this been discussed anywhere? Because honestly this seems quite a big change for a

Re: Breeze dark theme white edge outlines

2014-10-02 Thread Andrew Lake
Cool Marco! I'm totally fine with that as a solution instead of separate svgs. :-) Of course, you'll still have to decide if you like the white outlines on the dark theme or more subtle edge outlines. The decision is in your hands. muwahahaha! Seriously though, while I wouldn't have proposed th

Re: Breeze dark theme white edge outlines

2014-10-02 Thread Marco Martin
On Thursday 02 October 2014 10:19:52 Andrew Lake wrote: > Thanks for the feedback. Given the collection of responses so far, I'll go > ahead and leave the white outlines as they are. > > Regarding duplication of svgs. Yes, the changes I prepared had separate > panel-background, dialog and tooltip

Re: Moving kde:muon repository to kde/workspaces

2014-10-02 Thread Lukáš Tinkl
Dne 2.10.2014 v 19:28 Jens Reuterberg napsal(a): [silently cheering you on!] On Thursday 02 October 2014 19.23.17 Aleix Pol wrote: On Fri, Sep 26, 2014 at 4:44 PM, Aleix Pol wrote: Hi, I'd like to have it moved to get it released with the Plasma 5.2 release, so no rush. I think though it's a

Re: Moving kde:muon repository to kde/workspaces

2014-10-02 Thread Jens Reuterberg
[silently cheering you on!] On Thursday 02 October 2014 19.23.17 Aleix Pol wrote: > On Fri, Sep 26, 2014 at 4:44 PM, Aleix Pol wrote: > > Hi, > > I'd like to have it moved to get it released with the Plasma 5.2 release, > > so no rush. I think though it's a good match as I think KDE has had a nee

Re: Moving kde:muon repository to kde/workspaces

2014-10-02 Thread Aleix Pol
On Fri, Sep 26, 2014 at 4:44 PM, Aleix Pol wrote: > Hi, > I'd like to have it moved to get it released with the Plasma 5.2 release, > so no rush. I think though it's a good match as I think KDE has had a need > for offering resources that are not part of the actual release and also > Muon could r

Re: Breeze dark theme white edge outlines

2014-10-02 Thread Andrew Lake
Thanks for the feedback. Given the collection of responses so far, I'll go ahead and leave the white outlines as they are. Regarding duplication of svgs. Yes, the changes I prepared had separate panel-background, dialog and tooltip svgs specifically for the dark theme. The main reason is that refl

Re: Review Request 120461: Refactor DigitalClock applet to use multiple labels and states

2014-10-02 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120461/ --- (Updated Oct. 2, 2014, 5:05 p.m.) Review request for Plasma. Changes --

Re: Review Request 120461: Refactor DigitalClock applet to use multiple labels and states

2014-10-02 Thread Martin Klapetek
> On Oct. 2, 2014, 4:04 p.m., Kai Uwe Broulik wrote: > > File Attachment: Variants in vertical panel - digital-clock2.png > > > > > > Is it the panel which makes it not look horizontally centered? I think so, the vertical variant has "L

Re: Review Request 120461: Refactor DigitalClock applet to use multiple labels and states

2014-10-02 Thread Martin Klapetek
> On Oct. 2, 2014, 3:57 p.m., Sebastian Kügler wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 216 > > > > > > There may be a corner case here, when the formfactor changes to Planar >

Re: Review Request 120461: Refactor DigitalClock applet to use multiple labels and states

2014-10-02 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120461/#review67813 --- Ship it! Ship It! - Kai Uwe Broulik On Okt. 2, 2014, 1:27

Re: Review Request 120461: Refactor DigitalClock applet to use multiple labels and states

2014-10-02 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120461/#review67812 --- File Attachment: Variants in vertical panel - digital-clock2.

Re: Review Request 120461: Refactor DigitalClock applet to use multiple labels and states

2014-10-02 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120461/#review67811 --- Ship it! Nice work! applets/digital-clock/package/contents/

Re: Review Request 120461: Refactor DigitalClock applet to use multiple labels and states

2014-10-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120461/#review67810 --- Ship it! I tried it a bit, it seems to work fine - Marco Mar

Re: Review Request 120461: Refactor DigitalClock applet to use multiple labels and states

2014-10-02 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120461/ --- (Updated Oct. 2, 2014, 3:27 p.m.) Review request for Plasma. Changes --

Review Request 120461: Refactor DigitalClock applet to use multiple labels and states

2014-10-02 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120461/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Jenkins build is back to stable : plasma-workspace_master_qt5 #946

2014-10-02 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Breeze dark theme white edge outlines

2014-10-02 Thread Marco Martin
On Wednesday 01 October 2014 16:21:03 Andrew Lake wrote: > For anyone using the breeze dark theme, I've been meaning for a while to > make some adjustments so that the edges aren't quite so pronounced and high > contrast. It looks this way because it's currently using the same svgs (and > edge high

Re: Breeze dark theme white edge outlines

2014-10-02 Thread Martin Klapetek
On Thu, Oct 2, 2014 at 11:10 AM, Eike Hein wrote: > > > On 02.10.2014 01:21, Andrew Lake wrote: > >> Holler if anyone has any objections. :-) >> > > Personally I kind of like the white outlines. Not sure how to > put it, they give kind of a cool retro-y vibe perhaps ;). I > think they might actua

Re: Breeze dark theme white edge outlines

2014-10-02 Thread Eike Hein
On 02.10.2014 01:21, Andrew Lake wrote: Holler if anyone has any objections. :-) Personally I kind of like the white outlines. Not sure how to put it, they give kind of a cool retro-y vibe perhaps ;). I think they might actually fall into happy-accident territory, but I'm not married to them

Jenkins build became unstable: plasma-workspace_master_qt5 #945

2014-10-02 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Breeze dark theme white edge outlines

2014-10-02 Thread Jens Reuterberg
No objections just a massive thumbs up! On Wednesday 01 October 2014 16.21.03 Andrew Lake wrote: > For anyone using the breeze dark theme, I've been meaning for a while to > make some adjustments so that the edges aren't quite so pronounced and high > contrast. It looks this way because it's cur