Re: Review Request 120358: DigitalClock: Add timezone information to digital clock tooltip.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120358/ --- (Updated Sept. 24, 2014, 8:12 p.m.) Review request for Plasma, Kai Uwe Br

Review Request 120358: DigitalClock: Add timezone information to digital clock tooltip.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120358/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 120353: Add timezones i18n stuff

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120353/#review67398 --- Ship it! We need the strings to go in for the message freeze,

Re: Review Request 120353: Add timezones i18n stuff

> On Sept. 24, 2014, 12:42 p.m., Sebastian Kügler wrote: > > applets/digital-clock/plugin/timezonesi18n.cpp, line 418 > > > > > > Does it really make sense to have translations added for UTC offsets, > > and UTC

Re: Review Request 120314: Add timezones support into clock applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/ --- (Updated Sept. 24, 2014, 9:02 p.m.) Status -- This change has been m

Re: Review Request 120314: Add timezones support into clock applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/#review67393 --- Ship it! Summing up from IRC: a) The new message widget appr

Re: Review Request 120314: Add timezones support into clock applet

> On Sept. 24, 2014, 2:42 nachm., Eike Hein wrote: > > Doesn't always keeping Local enabled create an awkward situation if you > > want to default a clock to a non-Local timezone but want wheel scrolling > > disabled for accident-safety a la sebas? > > > > Then you need to: > > > > 1. Enable

Re: Review Request 120314: Add timezones support into clock applet

> On Sept. 24, 2014, 2:42 nachm., Eike Hein wrote: > > Doesn't always keeping Local enabled create an awkward situation if you > > want to default a clock to a non-Local timezone but want wheel scrolling > > disabled for accident-safety a la sebas? > > > > Then you need to: > > > > 1. Enable

Re: Review Request 120314: Add timezones support into clock applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/ --- (Updated Sept. 24, 2014, 10:40 p.m.) Review request for Plasma. Changes

Re: Review Request 120353: Add timezones i18n stuff

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120353/#review67386 --- applets/digital-clock/plugin/timezonesi18n.cpp

Re: Review Request 120329: PlasmaShell and PlasmaSurface interfaces

> On Sept. 23, 2014, 5:51 a.m., Martin Gräßlin wrote: > > src/client/plasma_shell.h, line 162 > > > > > > why is this in PlasmaShell? Shouldn't it be in the PlasmaSurface? > > Pier Luigi Fiorini wrote: > Thi

Re: Review Request 120329: PlasmaShell and PlasmaSurface interfaces

> On Sept. 23, 2014, 5:39 a.m., Martin Gräßlin wrote: > > I am not comfortable with this going into the master branch yet. I do want > > master to get into the state where we can provide API and ABI stability. By > > adding development code it would become difficult to reach this state. > > >

Re: Review Request 120353: Add timezones i18n stuff

> On Септ. 24, 2014, 2:42 по п., Sebastian Kügler wrote: > > I wonder if it's enough to just have a file with the i18n("City") in there, > > so it sends up in the .po file, and then wrap the untranslated city name > > into it. This way, we can avoid putting a huge Hash into the .cpp file, and

Re: Review Request 120325: port of the kde4 c++ based binary clock to kf5/qml only. It works on the desktop, but some sizing/dot sizeing issues exist in the panels. At least it is a start

> On Sept. 23, 2014, 11:22 a.m., David Edmundson wrote: > > applets/binary-clock/package/contents/ui/configGeneral.qml, line 58 > > > > > > in general ColumnLayout is better than Columns > > (from QtQuick.Layo

Re: Review Request 120316: standalone application mode for plasmashell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120316/ --- (Updated Sept. 24, 2014, 3:43 p.m.) Status -- This change has been m

Re: Review Request 120279: Port to KWayland client library

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120279/ --- (Updated Sept. 24, 2014, 3:22 p.m.) Status -- This change has been m

Re: Review Request 120353: Add timezones i18n stuff

> On Sept. 24, 2014, 4:55 p.m., Lukáš Tinkl wrote: > > This should either be fixed in QTimezone or we can just use > > KLocale/KTimezone to get the stuff we need meanwhile, no need to reinvent > > the wheel. Users don't care KTimezone does not implement the city either as far as I can see, no

Re: Review Request 120353: Add timezones i18n stuff

On Wed, Sep 24, 2014 at 5:03 PM, wrote: > Using the city name is kinda offensive. > Many people in my country, Denmark, think that > the capital, Copenhagen, is dominating them. > It gets even worse if the time is given as a foreign city, > for exampe, Berlin, Paris or Amsterdam. > > It is much b

Re: Review Request 120353: Add timezones i18n stuff

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120353/#review67364 --- This should either be fixed in QTimezone or we can just use KL

Re: Review Request 120353: Add timezones i18n stuff

> On Sept. 24, 2014, 2:42 p.m., Sebastian Kügler wrote: > > applets/digital-clock/plugin/timezonesi18n.cpp, line 418 > > > > > > Does it really make sense to have translations added for UTC offsets, > > and UTC

Re: Review Request 120353: Add timezones i18n stuff

> On Zář. 24, 2014, 2:42 odp., Sebastian Kügler wrote: > > applets/digital-clock/plugin/timezonesi18n.cpp, line 418 > > > > > > Does it really make sense to have translations added for UTC offsets, > > and UTC i

Re: Review Request 120314: Add timezones support into clock applet

> On Zář. 24, 2014, 4:33 odp., Lukáš Tinkl wrote: > > Please put the city as the 2nd column, otherwise a ship it from me > > definitely, great work! For the record, the tooltip can be wrong for certain TZs (yesterday/tomorrow with the correct day name should be shown instead) - Lukáš -

Re: Review Request 120314: Add timezones support into clock applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/#review67360 --- Doesn't always keeping Local enabled create an awkward situati

Re: Review Request 120353: Add timezones i18n stuff

> On Sept. 24, 2014, 12:42 p.m., Sebastian Kügler wrote: > > I wonder if it's enough to just have a file with the i18n("City") in there, > > so it sends up in the .po file, and then wrap the untranslated city name > > into it. This way, we can avoid putting a huge Hash into the .cpp file, and

Re: Review Request 120314: Add timezones support into clock applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/#review67357 --- Ship it! Please put the city as the 2nd column, otherwise a s

Re: Review Request 120353: Add timezones i18n stuff

> On Sept. 24, 2014, 2:42 p.m., Sebastian Kügler wrote: > > I wonder if it's enough to just have a file with the i18n("City") in there, > > so it sends up in the .po file, and then wrap the untranslated city name > > into it. This way, we can avoid putting a huge Hash into the .cpp file, and >

Re: Review Request 120353: Add timezones i18n stuff

> On Sept. 24, 2014, 2:42 p.m., Sebastian Kügler wrote: > > I wonder if it's enough to just have a file with the i18n("City") in there, > > so it sends up in the .po file, and then wrap the untranslated city name > > into it. This way, we can avoid putting a huge Hash into the .cpp file, and >

Re: Review Request 120353: Add timezones i18n stuff

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120353/#review67347 --- I wonder if it's enough to just have a file with the i18n("Cit

Re: Review Request 120353: Add timezones i18n stuff

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120353/ --- (Updated Sept. 24, 2014, 2:02 p.m.) Review request for Localization and T

Review Request 120353: Add timezones i18n stuff

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120353/ --- Review request for Localization and Translation (l10n) and Plasma. Reposi

Re: Review Request 120314: Add timezones support into clock applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120314/ --- (Updated Sept. 24, 2014, 11:43 a.m.) Review request for Plasma. Changes

Re: Review Request 120352: Remove keyboard click volume setting

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120352/#review67344 --- i can't see what the use could be either, but wasn't perhaps s

Re: Review Request 120352: Remove keyboard click volume setting

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120352/#review67343 --- I could imagine that it is an accessibility feature. Though I

Re: Review Request 120351: Only show keyboard layout OSD on key pressed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120351/#review67340 --- Ship it! kcms/keyboard/keyboard_daemon.cpp

Review Request 120352: Remove keyboard click volume setting

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120352/ --- Review request for Plasma. Repository: plasma-desktop Description -

Review Request 120351: Only show keyboard layout OSD on key pressed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120351/ --- Review request for Plasma. Repository: plasma-desktop Description -