Re: Review Request 120050: Wallpaper package structure fixes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120050/#review67019 --- This causes a regression: normal images can no longer be loade

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

> On Sept. 19, 2014, 9:33 p.m., Martin Klapetek wrote: > > dataengines/comic/comic_package.cpp, line 49 > > > > > > You're building this class as MODULE (ie. a plugin) but you don't > > define any plugin macro (K

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

> On Sept. 19, 2014, 10:33 p.m., Martin Klapetek wrote: > > dataengines/comic/comic_package.cpp, line 49 > > > > > > You're building this class as MODULE (ie. a plugin) but you don't > > define any plugin macro (

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

> On Sept. 19, 2014, 10:33 p.m., Martin Klapetek wrote: > > dataengines/comic/comic_package.cpp, line 49 > > > > > > You're building this class as MODULE (ie. a plugin) but you don't > > define any plugin macro (

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/#review66979 --- Progressing nicely. A piece of advice - leave the codestyle ch

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

> On Sept. 19, 2014, 10:17 p.m., Martin Klapetek wrote: > > You need to select the "Update diff" to update the diff, not "Add file" ;) Done :) - Andrei --- This is an automatically generated e-mail. To reply, visit: https://git.reviewbo

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Sept. 19, 2014, 10:17 p.m.) Review request for Plasma, David Edm

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Sept. 19, 2014, 10:17 p.m.) Review request for Plasma, David Edm

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/#review66978 --- You need to select the "Update diff" to update the diff, not "

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Sept. 19, 2014, 10:15 p.m.) Review request for Plasma, David Edm

Re: Review Request 120050: Wallpaper package structure fixes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120050/ --- (Updated Sept. 19, 2014, 2:28 p.m.) Status -- This change has been m

Re: Review Request 120050: Wallpaper package structure fixes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120050/#review66959 --- Ship it! Ship It! - Marco Martin On Sept. 19, 2014, 2:08 p

Re: Review Request 120284: sanity checking in desktops/activities scripting

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120284/ --- (Updated Sept. 19, 2014, 2:04 p.m.) Status -- This change has been m

Re: Review Request 120050: Wallpaper package structure fixes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120050/ --- (Updated Sept. 19, 2014, 2:08 p.m.) Review request for Plasma. Reposito

Re: Review Request 119764: Fix BUG#105797: inappropriate fontconfig settings are saved when kcontrol/fonts is shown and no way to revert them

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119764/#review66956 --- Ship it! Makes sense to me and seems to work well in testing.

Re: Review Request 120284: sanity checking in desktops/activities scripting

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120284/#review66954 --- Ship it! Ship It! - Marco Martin On Sept. 19, 2014, 1:19 p

Re: Review Request 120284: sanity checking in desktops/activities scripting

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120284/ --- (Updated Sept. 19, 2014, 1:19 p.m.) Review request for Plasma. Changes

Re: Review Request 120050: Wallpaper package structure fixes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120050/ --- (Updated Sept. 19, 2014, 12:53 p.m.) Review request for Plasma. Changes

Re: Review Request 120284: sanity checking in desktops/activities scripting

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120284/#review66950 --- Ship it! Good catch, just a detail I would do differently.

Review Request 120284: sanity checking in desktops/activities scripting

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120284/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Announcing KWayland library

Martin GräßlinOn Friday 19 September 2014 11:06:56 wrote: > Hi plasma-devs, > Once the CI system is in place for the new library I will migrate KWin over > to it. this is now done [1]: 62 files changed, 106 insertions(+), 8831 deletions(-) Cheers Martin [1] http://commits.kde.org/kwin/237ee7fc

KPackage framework in playground

Hi all, After the discussions done at akademy and here about a standalone framework for Package, due to the potential interest by other applications in order to ship their own scripts/extensions/themes/graphics assets i did the surgical operation, after living for a while in scratch it's now in

Re: Review Request 120279: Port to KWayland client library

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120279/ --- (Updated Sept. 19, 2014, 12:49 p.m.) Review request for Plasma. Changes

Re: Review Request 120270: full shell mode for plasma-windowed

> On Sept. 19, 2014, 4:30 a.m., Bhushan Shah wrote: > > plasma-windowed/simpleshellview.cpp, line 36 > > > > > > This should come from arguments maybe? and should not be Plasma > > mediacenter obviously.. :p eww

Re: Review Request 120270: full shell mode for plasma-windowed

> On Sept. 18, 2014, 10:11 p.m., Aleix Pol Gonzalez wrote: > > Shouldn't it be called SimpleCorona? Or maybe WindowedCorona? > > It's not a shell anymore, in this case. hmm, maybe. technically it is since it loads plasmoids. but yeah, windowedcorona sounds good, +1 - Marco --

Re: Review Request 120279: Port to KWayland client library

> On Sept. 19, 2014, 11:53 a.m., David Edmundson wrote: > > Modules/base/info_wayland.cpp, line 194 > > > > > > aren't we doing this in the ctor too? good spot, I moved the code later-on to the class and oversaw

Re: Review Request 120279: Port to KWayland client library

> On Sept. 19, 2014, 11:37 a.m., David Edmundson wrote: > > Modules/base/info_wayland.cpp, line 236 > > > > > > This will add a row when the keyboard is added, but won't delete it > > when you remove it. > >

Re: Review Request 120279: Port to KWayland client library

> On Sept. 19, 2014, 11:37 a.m., David Edmundson wrote: > > Modules/base/info_wayland.cpp, line 236 > > > > > > This will add a row when the keyboard is added, but won't delete it > > when you remove it. > >

Re: Review Request 120279: Port to KWayland client library

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120279/#review66928 --- Modules/base/info_wayland.cpp

Re: Review Request 120279: Port to KWayland client library

> On Sept. 19, 2014, 9:37 a.m., David Edmundson wrote: > > Modules/base/info_wayland.cpp, line 236 > > > > > > This will add a row when the keyboard is added, but won't delete it > > when you remove it. > >

Re: Review Request 120279: Port to KWayland client library

> On Sept. 19, 2014, 11:37 a.m., David Edmundson wrote: > > Modules/base/info_wayland.cpp, line 236 > > > > > > This will add a row when the keyboard is added, but won't delete it > > when you remove it. > >

Re: Review Request 120279: Port to KWayland client library

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120279/#review66922 --- Modules/base/info_wayland.cpp

Review Request 120279: Port to KWayland client library

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120279/ --- Review request for Plasma. Repository: kinfocenter Description ---

Announcing KWayland library

Hi plasma-devs, as discussed on Monday's hangout I split out KWin's Wayland handling code into a dedicated repository and library: git clone kde:kwayland The repository provides two libraries: * Client * Server At the moment Server doesn't get installed, but is used for the auto-tests of the

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

> On Sept. 19, 2014, 10:24 a.m., Martin Klapetek wrote: > > dataengines/comic/comicprovider.h, lines 37-39 > > > > > > Let's remove this macro, it's not just a substitute for > > K_PLUGIN_FACTORY. So remove and r

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/#review66919 --- Hey, thanks for working on this! Couple remarks below, but pre