Re: Minutes Monday Plasma Hangout

2014-09-17 Thread Jonathan Riddell
On Wed, Sep 17, 2014 at 09:20:49PM +0200, Eike Hein wrote: > > > On 15.09.2014 13:11, Sebastian K?gler wrote: > >Announcement: > > Freeze coming up: https://techbase.kde.org/Schedules/Plasma_5 > > [...] > >Marco: > > [...] > >- will send email about freeze and -related process > > Just for c

Re: Minutes Monday Plasma Hangout

2014-09-17 Thread Eike Hein
On 15.09.2014 13:11, Sebastian Kügler wrote: Announcement: Freeze coming up: https://techbase.kde.org/Schedules/Plasma_5 > [...] Marco: > [...] - will send email about freeze and -related process Just for clarification: There seems to be some confusion over whether the freeze for 5.1

Re: Review Request 120248: Override the implicitSizes in the ruler completley

2014-09-17 Thread David Edmundson
> On Sept. 17, 2014, 6:35 p.m., Marco Martin wrote: > > hmm, not sure is the correct way, setting implicitsizes should be expected > > to work correctly and not be rewrittten by the component. > > > > maybe it should check at componentcomplete if at that point impolicitWidth > > has been set b

Re: Review Request 120248: Override the implicitSizes in the ruler completley

2014-09-17 Thread Marco Martin
> On Sept. 17, 2014, 6:35 p.m., Marco Martin wrote: > > hmm, not sure is the correct way, setting implicitsizes should be expected > > to work correctly and not be rewrittten by the component. > > > > maybe it should check at componentcomplete if at that point impolicitWidth > > has been set b

Re: Review Request 120248: Override the implicitSizes in the ruler completley

2014-09-17 Thread David Edmundson
> On Sept. 17, 2014, 6:35 p.m., Marco Martin wrote: > > hmm, not sure is the correct way, setting implicitsizes should be expected > > to work correctly and not be rewrittten by the component. > > > > maybe it should check at componentcomplete if at that point impolicitWidth > > has been set b

Re: Review Request 120248: Override the implicitSizes in the ruler completley

2014-09-17 Thread Marco Martin
> On Sept. 17, 2014, 6:35 p.m., Marco Martin wrote: > > hmm, not sure is the correct way, setting implicitsizes should be expected > > to work correctly and not be rewrittten by the component. > > > > maybe it should check at componentcomplete if at that point impolicitWidth > > has been set b

Re: Review Request 120248: Override the implicitSizes in the ruler completley

2014-09-17 Thread David Edmundson
> On Sept. 17, 2014, 6:35 p.m., Marco Martin wrote: > > hmm, not sure is the correct way, setting implicitsizes should be expected > > to work correctly and not be rewrittten by the component. > > > > maybe it should check at componentcomplete if at that point impolicitWidth > > has been set b

Re: Review Request 120248: Override the implicitSizes in the ruler completley

2014-09-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120248/#review66766 --- hmm, not sure is the correct way, setting implicitsizes should

Review Request 120248: Override the implicitSizes in the ruler completley

2014-09-17 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120248/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 120141: Cleanup Applet Configuration sidebar

2014-09-17 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120141/ --- (Updated Sept. 17, 2014, 5:48 nachm.) Status -- This change has been

Re: Review Request 120235: restore ResizeOrigin

2014-09-17 Thread Marco Martin
> On Sept. 17, 2014, 4:28 p.m., Vishesh Handa wrote: > > Do all of the tests now pass? yes. also without resizeorigin but by disconnecting/reconnecting (i tend to like more using a variable as semaphore rather than have to manually rebuild the connection status as it being actually more error

Re: Review Request 120235: restore ResizeOrigin

2014-09-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120235/ --- (Updated Sept. 17, 2014, 4:53 p.m.) Review request for Plasma. Reposito

Re: Review Request 120235: restore ResizeOrigin

2014-09-17 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120235/#review66756 --- Do all of the tests now pass? src/plasmaquick/dialog.cpp

Re: Review Request 120235: restore ResizeOrigin

2014-09-17 Thread Vishesh Handa
> On Sept. 17, 2014, 2:54 p.m., Vishesh Handa wrote: > > src/plasmaquick/dialog.cpp, line 301 > > > > > > Would this actually do anything? > > > > resizeOrigin = MainItem; > > // do stuff which chang

Re: Review Request 120235: restore ResizeOrigin

2014-09-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120235/ --- (Updated Sept. 17, 2014, 4:03 p.m.) Review request for Plasma. Reposito

Re: Review Request 120235: restore ResizeOrigin

2014-09-17 Thread Marco Martin
> On Sept. 17, 2014, 2:54 p.m., Vishesh Handa wrote: > > The following tests are broken - > > > > 1. dialog_positioning.qml > > 2. dialog_positioning2.qml - The animation seems incorrect. Maybe that was > > always different and I did not notice? > > 3. dialog_visualParentChange.qml 1 and 3 wer

Re: Initial standalone Plasma::Package repository

2014-09-17 Thread Vishesh Handa
On Tue, Sep 16, 2014 at 2:19 PM, Marco Martin wrote: > right now all the classes are still under the Plasma namespace, and should > probably be renamed and cmakes to be cleaned up (especially because it > would > be used by plasma too to the two identically named classes, new and > deprecated > w

Re: Review Request 120235: restore ResizeOrigin

2014-09-17 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120235/#review66744 --- The following tests are broken - 1. dialog_positioning.qml 2.

Re: Review Request 120235: restore ResizeOrigin

2014-09-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120235/ --- (Updated Sept. 17, 2014, 2:32 p.m.) Review request for Plasma. Reposito

Re: Review Request 120235: restore ResizeOrigin

2014-09-17 Thread Marco Martin
> On Sept. 17, 2014, 11:24 a.m., Vishesh Handa wrote: > > src/plasmaquick/dialog.cpp, line 922 > > > > > > I'm really not sure what is going to happen in this case - > > > > We set the resizeOrigin to Wi

Re: Re: Re: Re: Minutes Monday Plasma Hangout

2014-09-17 Thread Martin Gräßlin
On Wednesday 17 September 2014 14:05:07 Pier Luigi Fiorini wrote: > 2014-09-17 13:31 GMT+02:00 Martin Gräßlin : > > Martin GräßlinOn Wednesday 17 September 2014 08:41:49 wrote: > > > I'll split out my code from kwin using git-filter branch. I think that's > > > > the > > > > > only sane approach

Re: Re: Re: Minutes Monday Plasma Hangout

2014-09-17 Thread Pier Luigi Fiorini
2014-09-17 13:31 GMT+02:00 Martin Gräßlin : > Martin GräßlinOn Wednesday 17 September 2014 08:41:49 wrote: > > I'll split out my code from kwin using git-filter branch. I think that's > the > > only sane approach to have the complete history and in the end do a > > relicence commit. > > Just did

Re: Initial standalone Plasma::Package repository

2014-09-17 Thread Sebastian Kügler
On Wednesday, September 17, 2014 11:20:10 Marco Martin wrote: > On Wednesday 17 September 2014 11:06:50 Martin Gräßlin wrote: > > > Is the name ok for everybody? potential name clashes? > > > > as it used to be namespaces before, what about using a namespace KPackage > > and just call the classes:

Re: Re: Re: Minutes Monday Plasma Hangout

2014-09-17 Thread Martin Gräßlin
Martin GräßlinOn Wednesday 17 September 2014 08:41:49 wrote: > I'll split out my code from kwin using git-filter branch. I think that's the > only sane approach to have the complete history and in the end do a > relicence commit. Just did the split and pushed the code to a new repository at [1].

Re: Review Request 120235: restore ResizeOrigin

2014-09-17 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120235/#review66724 --- src/plasmaquick/dialog.cpp

Re: Initial standalone Plasma::Package repository

2014-09-17 Thread Marco Martin
On Wednesday 17 September 2014 11:06:50 Martin Gräßlin wrote: > > Is the name ok for everybody? potential name clashes? > > as it used to be namespaces before, what about using a namespace KPackage > and just call the classes: > KPackage::Package > KPackage::PackageStructure > KPackage::PackageTra

Re: Re: Initial standalone Plasma::Package repository

2014-09-17 Thread Martin Gräßlin
On Wednesday 17 September 2014 10:40:35 Marco Martin wrote: > On Tuesday 16 September 2014 14:19:44 Marco Martin wrote: > > right now all the classes are still under the Plasma namespace, and should > > probably be renamed and cmakes to be cleaned up (especially because it > > would be used by plas

Re: Initial standalone Plasma::Package repository

2014-09-17 Thread Marco Martin
On Tuesday 16 September 2014 14:19:44 Marco Martin wrote: > right now all the classes are still under the Plasma namespace, and should > probably be renamed and cmakes to be cleaned up (especially because it would > be used by plasma too to the two identically named classes, new and > deprecated wo