Re: Re: Minutes Monday Plasma Hangout

2014-09-16 Thread Martin Gräßlin
On Wednesday 17 September 2014 08:36:53 Pier Luigi Fiorini wrote: > 2014-09-15 13:11 GMT+02:00 Sebastian Kügler : > > Minutes Plasma Hangout, 15-9-2014 > > [cut] > > > Martin G: > > - will add a dependency on Frameworks 5.3 (will be out in time for Plasma > > 5.1) - ambiguity with window states,

Re: Minutes Monday Plasma Hangout

2014-09-16 Thread Pier Luigi Fiorini
2014-09-15 13:11 GMT+02:00 Sebastian Kügler : > Minutes Plasma Hangout, 15-9-2014 > [cut] > Martin G: > - will add a dependency on Frameworks 5.3 (will be out in time for Plasma 5.1) > - ambiguity with window states, working on fix (debugging / writing unit > tests) > - Will travel to XDC and lik

Re: Review Request 120235: restore ResizeOrigin

2014-09-16 Thread Marco Martin
> On Sept. 16, 2014, 4:08 p.m., Vishesh Handa wrote: > > We currently have the following ways of changing the dialog size > > > > 1. By changing the mainItem size > > 2. By actually changing the size of the dialog via QML > > 3. Window Managers > > > > (3) is not something that is exposed to th

Re: Review Request 120235: restore ResizeOrigin

2014-09-16 Thread Vishesh Handa
> On Sept. 16, 2014, 4:08 p.m., Vishesh Handa wrote: > > We currently have the following ways of changing the dialog size > > > > 1. By changing the mainItem size > > 2. By actually changing the size of the dialog via QML > > 3. Window Managers > > > > (3) is not something that is exposed to th

Re: Review Request 120225: Draw lineedit frames as long as there is just enough space

2014-09-16 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120225/ --- (Updated Sept. 16, 2014, 4:25 p.m.) Status -- This change has been m

Re: Review Request 120234: Add option to enable high DPI pixmaps in oxygen-demo

2014-09-16 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120234/ --- (Updated Sept. 16, 2014, 4:23 p.m.) Status -- This change has been m

Re: Review Request 120235: restore ResizeOrigin

2014-09-16 Thread Marco Martin
> On Sept. 16, 2014, 4:08 p.m., Vishesh Handa wrote: > > We currently have the following ways of changing the dialog size > > > > 1. By changing the mainItem size > > 2. By actually changing the size of the dialog via QML > > 3. Window Managers > > > > (3) is not something that is exposed to th

Re: Review Request 120234: Add option to enable high DPI pixmaps in oxygen-demo

2014-09-16 Thread Hugo Pereira Da Costa
> On Sept. 16, 2014, 4:01 p.m., Hugo Pereira Da Costa wrote: > > ok, ship it, then :) > > in the meanwhile I'll try compile a more recent Qt5 version (which branch > > do you use ? stable ?) > > and then I'll go debug breeze and oxygen (I'm actually eager to) > > David Edmundson wrote: > "s

Re: Review Request 120234: Add option to enable high DPI pixmaps in oxygen-demo

2014-09-16 Thread David Edmundson
> On Sept. 16, 2014, 4:01 p.m., Hugo Pereira Da Costa wrote: > > ok, ship it, then :) > > in the meanwhile I'll try compile a more recent Qt5 version (which branch > > do you use ? stable ?) > > and then I'll go debug breeze and oxygen (I'm actually eager to) "stable" shouldn't be used. The ri

Re: Review Request 120235: restore ResizeOrigin

2014-09-16 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120235/#review66684 --- We currently have the following ways of changing the dialog si

Re: Review Request 120234: Add option to enable high DPI pixmaps in oxygen-demo

2014-09-16 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120234/#review66683 --- Ship it! ok, ship it, then :) in the meanwhile I'll try compi

Review Request 120235: restore ResizeOrigin

2014-09-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120235/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: Review Request 120234: Add option to enable high DPI pixmaps in oxygen-demo

2014-09-16 Thread David Edmundson
> On Sept. 16, 2014, 3:17 p.m., Hugo Pereira Da Costa wrote: > > First of, I am perfectly fine with the option, but the question is, how do > > I test it, and use it, to fix oxygen and breeze > > I have qt-5.4 here, X system, but whether I enable or not the option and > > the QT_DEVICE_PIXEL_R

Re: Review Request 120234: Add option to enable high DPI pixmaps in oxygen-demo

2014-09-16 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120234/#review66680 --- First of, I am perfectly fine with the option, but the questio

Re: Review Request 120234: Add option to enable high DPI pixmaps in oxygen-demo

2014-09-16 Thread David Edmundson
> On Sept. 16, 2014, 2:41 p.m., Marco Martin wrote: > > is this depending from Qt 5.4? I don't thik we still can do that? (maybe > > ifdeffed?) this enum was added for 5.3, it just didn't do anything on X till now. - David --- This is

Re: Review Request 120234: Add option to enable high DPI pixmaps in oxygen-demo

2014-09-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120234/#review66672 --- is this depending from Qt 5.4? I don't thik we still can do th

Review Request 120234: Add option to enable high DPI pixmaps in oxygen-demo

2014-09-16 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120234/ --- Review request for Plasma and Hugo Pereira Da Costa. Repository: oxygen

Re: Review Request 120232: Improve the notifications history delegates

2014-09-16 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120232/ --- (Updated Sept. 16, 2014, 2:01 p.m.) Status -- This change has been m

Re: Review Request 120232: Improve the notifications history delegates

2014-09-16 Thread Martin Klapetek
> On Sept. 16, 2014, 3:36 p.m., Kai Uwe Broulik wrote: > > applets/notifications/package/contents/ui/NotificationDelegate.qml, line 150 > > > > > > The label wraps, right? That would probably overlap the action b

Re: Review Request 120232: Improve the notifications history delegates

2014-09-16 Thread Martin Klapetek
> On Sept. 16, 2014, 3:31 p.m., Marco Martin wrote: > > Couldn't the inside of the popup be a recycled component between the two? Ideally yes. On the other hand, the floating popup is much much wider than the systray popup, so we might want to do some optimizations so it fits better into the s

Re: Review Request 120232: Improve the notifications history delegates

2014-09-16 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120232/#review7 --- applets/notifications/package/contents/ui/NotificationDelegat

Re: Review Request 120232: Improve the notifications history delegates

2014-09-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120232/#review6 --- Ship it! Couldn't the inside of the popup be a recycled compo

Re: Review Request 120232: Improve the notifications history delegates

2014-09-16 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120232/#review5 --- Oh and I forgot - there are close buttons in every notificatio

Review Request 120232: Improve the notifications history delegates

2014-09-16 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120232/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Initial standalone Plasma::Package repository

2014-09-16 Thread Marco Martin
Hi all, first, brief introductionon what this is: during a Bof about scripting in applications at Akademy it occurred that some applications may be interested by the functionality provided by Plasma::Package, provided it was on a lower tier. Since I already had kindof the idea of making Package

Re: Review Request 120040: Install kdesu under bin

2014-09-16 Thread Maarten De Meyer
> On Sept. 2, 2014, 6:54 p.m., Hrvoje Senjan wrote: > > >in kde4 kdesu was installed under bin > > > > it was actually also in libexec. just that KStandardDirs::findExe() looked > > in libexec paths, QStandardPaths doesn't... > > Marco Martin wrote: > right, it seems on both places here, b

Re: Review Request 120040: Install kdesu under bin

2014-09-16 Thread Harald Sitter
> On Sept. 2, 2014, 6:54 p.m., Hrvoje Senjan wrote: > > >in kde4 kdesu was installed under bin > > > > it was actually also in libexec. just that KStandardDirs::findExe() looked > > in libexec paths, QStandardPaths doesn't... > > Marco Martin wrote: > right, it seems on both places here, b

Re: Review Request 120040: Install kdesu under bin

2014-09-16 Thread Marco Martin
> On Sept. 2, 2014, 6:54 p.m., Hrvoje Senjan wrote: > > >in kde4 kdesu was installed under bin > > > > it was actually also in libexec. just that KStandardDirs::findExe() looked > > in libexec paths, QStandardPaths doesn't... right, it seems on both places here, but is probably a distro thing.

Re: Review Request 120040: Install kdesu under bin

2014-09-16 Thread Marco Martin
On Sept. 2, 2014, 6:37 p.m., Marco Martin wrote: > > I'm a bit worried by the multitude of user and distro specific scripts that > > rely on kdesu being present :/ > > Marco Martin wrote: > to me either way it gets fixed i'm ok. > the other option is to keep it called kdesu, so it would