Re: Kioslave repos

On Wednesday 20 August 2014 11:38:12 Jonathan Riddell wrote: > On Wed, Aug 20, 2014 at 12:28:30PM +0200, Aleix Pol wrote: > >On Tue, Aug 19, 2014 at 9:49 PM, David Faure wrote: > > On Tuesday 01 July 2014 22:25:15 Jonathan Riddell wrote: > > > On Tue, Jul 01, 2014 at 11:25:11PM +0200

Re: Review Request 120151: Cleanups in Host::categories (applets/systemtray)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120151/#review66301 --- applets/systemtray/plugin/host.cpp

Review Request 120151: Cleanups in Host::categories (applets/systemtray)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120151/ --- Review request for Plasma. Repository: plasma-workspace Description ---

New Review Tools Trial

Hey all. Plasma-framework is taking part in a trial of using gerrit for reviews. See https://techbase.kde.org/Development/Gerrit *How will this affect you*: - If you review frameworks patches you may need to also check another tool - Currently gerrit does not email plasma-devel, I hope to get thi

Re: Review Request 120141: Cleanup Applet Configuration sidebar

> On Sept. 11, 2014, 4:36 nachm., Eike Hein wrote: > > I'm sorry to reopen, but my clock config dialog now looks like this: > > > >  > > > > What gives? :) > > Eike Hein wrote: > Hmm I also don't really like how different from KConfigDi

[Breeze] [Bug 158379] Draw focus rect in Kate Part instead of Widget Style (Oxygen)

https://bugs.kde.org/show_bug.cgi?id=158379 --- Comment #11 from Hugo Pereira Da Costa --- Git commit c71ed504dad4f92979e905067b22cafc015b8afd by Hugo Pereira Da Costa. Committed on 11/09/2014 at 21:18. Pushed by hpereiradacosta into branch 'master'. - Use QGridLayout for setting up View layout

Re: Review Request 120141: Cleanup Applet Configuration sidebar

> On Sept. 11, 2014, 4:36 nachm., Eike Hein wrote: > > I'm sorry to reopen, but my clock config dialog now looks like this: > > > >  > > > > What gives? :) > > Eike Hein wrote: > Hmm I also don't really like how different from KConfigDi

Re: Review Request 120141: Cleanup Applet Configuration sidebar

> On Sept. 11, 2014, 4:36 p.m., Eike Hein wrote: > > I'm sorry to reopen, but my clock config dialog now looks like this: > > > >  > > > > What gives? :) Hmm I also don't really like how different from KConfigDialog this still is ... color

Re: Review Request 120141: Cleanup Applet Configuration sidebar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120141/#review66282 --- I'm sorry to reopen, but my clock config dialog now looks like

Re: Review Request 120130: to prevent a compiler error

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120130/ --- (Updated Sept. 11, 2014, 2:44 p.m.) Status -- This change has been m

Re: Review Request 120130: to prevent a compiler error

> On Zář. 11, 2014, 1:55 odp., Kevin Krammer wrote: > > Ship It! Push it to all branches please, which means master, Plasma/5.0 and 0.9.3. Thanks. - Jan --- This is an automatically generated e-mail. To reply, visit: https://git.review

Re: Review Request 120130: to prevent a compiler error

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120130/#review66256 --- Ship it! Ship It! - Kevin Krammer On Sept. 11, 2014, 1:45

Re: Review Request 120130: to prevent a compiler error

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120130/ --- (Updated Sept. 11, 2014, 3:45 p.m.) Review request for Plasma, Daniel Nic

Re: Review Request 120036: Note loading in Notes Plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120036/#review66248 --- Ship it! Some minor nitpicks below. Thanks! applets/notes/p

Re: Review Request 119916: Make the notification popup higher when 3 actions are present

> On Sept. 11, 2014, 3:08 p.m., Kai Uwe Broulik wrote: > > And then we need to fix the horrible Free Space Notifier notification ;) http://quickgit.kde.org/?p=plasma-workspace.git&a=commitdiff&h=66c83af0baaf018947bb5e4edadd28ed4cb45e27 ;) - Martin ---

Re: Review Request 119916: Make the notification popup higher when 3 actions are present

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119916/#review66247 --- Ship it! And then we need to fix the horrible Free Space Noti

Re: Review Request 120141: Cleanup Applet Configuration sidebar

> On Sept. 11, 2014, 11:47 vorm., Marco Martin wrote: > > desktoppackage/contents/configuration/ConfigCategoryDelegate.qml, line 75 > > > > > > this may pose a performance problem, don't bind things to properties

Re: Review Request 120141: Cleanup Applet Configuration sidebar

> On Sept. 11, 2014, 11:47 a.m., Marco Martin wrote: > > desktoppackage/contents/configuration/ConfigCategoryDelegate.qml, line 75 > > > > > > this may pose a performance problem, don't bind things to properties

Re: Review Request 120141: Cleanup Applet Configuration sidebar

> On Sept. 11, 2014, 11:47 vorm., Marco Martin wrote: > > desktoppackage/contents/configuration/ConfigCategoryDelegate.qml, line 75 > > > > > > this may pose a performance problem, don't bind things to properties

Re: Review Request 120141: Cleanup Applet Configuration sidebar

> On Sept. 11, 2014, 11:47 a.m., Marco Martin wrote: > > desktoppackage/contents/configuration/ConfigCategoryDelegate.qml, line 75 > > > > > > this may pose a performance problem, don't bind things to properties

Re: Review Request 120141: Cleanup Applet Configuration sidebar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120141/ --- (Updated Sept. 11, 2014, 12:56 p.m.) Status -- This change has been

Re: Review Request 119916: Make the notification popup higher when 3 actions are present

> On Sept. 11, 2014, 11:45 a.m., David Edmundson wrote: > > Kai, Martin. What's the status of this? > > Might be good to work it out whilst you're both here. > > Martin Klapetek wrote: > It's ready, waiting for Ship it. Ship it! - David --

Re: Review Request 120141: Cleanup Applet Configuration sidebar

> On Sept. 11, 2014, 11:47 a.m., Marco Martin wrote: > > desktoppackage/contents/configuration/ConfigCategoryDelegate.qml, line 75 > > > > > > this may pose a performance problem, don't bind things to properties

Re: Review Request 120141: Cleanup Applet Configuration sidebar

> On Sept. 11, 2014, 11:47 a.m., Marco Martin wrote: > > Should be good, tough is better to put screenshot in the review request if > > the patch is about visual changes > > Kai Uwe Broulik wrote: > I would have if the internet weren't that slow... right :) so yeah, ship it - Marco ---

Re: Review Request 119916: Make the notification popup higher when 3 actions are present

> On Sept. 11, 2014, 1:45 p.m., David Edmundson wrote: > > Kai, Martin. What's the status of this? > > Might be good to work it out whilst you're both here. It's ready, waiting for Ship it. - Martin --- This is an automatically generate

Re: Review Request 120141: Cleanup Applet Configuration sidebar

> On Sept. 11, 2014, 11:47 vorm., Marco Martin wrote: > > Should be good, tough is better to put screenshot in the review request if > > the patch is about visual changes I would have if the internet weren't that slow... > On Sept. 11, 2014, 11:47 vorm., Marco Martin wrote: > > desktoppackage

Re: Review Request 120141: Cleanup Applet Configuration sidebar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120141/#review66228 --- Should be good, tough is better to put screenshot in the revie

Re: Review Request 119274: Use Atlas textures in SvgItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119274/ --- (Updated Sept. 11, 2014, 11:45 a.m.) Status -- This change has been

Re: Review Request 119916: Make the notification popup higher when 3 actions are present

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119916/#review66227 --- Kai, Martin. What's the status of this? Might be good to work

Re: Review Request 120141: Cleanup Applet Configuration sidebar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120141/#review66226 --- Ship it! Woo, I like patches with lots of red :) Looks good

Review Request 120141: Cleanup Applet Configuration sidebar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120141/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Notes for SLC BoF

2014-09-11 11:14 GMT+02:00 Marco Martin : > main points of the discussion this morning about Share Like Connect (went a > bit in KActivityManager land) > https://notes.kde.org/p/SLC_bof_2014 > > * SLC will use KWin > * the information of the current document/url will be sent to kwin, is the > only

Notes for SLC BoF

main points of the discussion this morning about Share Like Connect (went a bit in KActivityManager land) https://notes.kde.org/p/SLC_bof_2014 * SLC will use KWin * the information of the current document/url will be sent to kwin, is the only one that * who can know the current active window * way

Re: Review Request 120130: to prevent a compiler error

This os Wong please use constBeging() Em 10/09/2014 14:45, "Guy Maurel" escreveu: >This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120130/ > Review request for Plasma, Daniel Nicoletti, Jan Grulich, Kevin > Krammer, and Lukáš Tinkl. > By Guy M