[Breeze] [Bug 158379] Draw focus rect in Kate Part instead of Widget Style (Oxygen)

2014-09-09 Thread Dominik Haumann
https://bugs.kde.org/show_bug.cgi?id=158379 Dominik Haumann changed: What|Removed |Added Component|part|general Product|kate

Re: Review Request 120092: Turn KFormat into Q_GADGET and expose DurationFormat

2014-09-09 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120092/ --- (Updated Sept. 9, 2014, 3:50 p.m.) Status -- This change has been ma

Re: Review Request 120092: Turn KFormat into Q_GADGET and expose DurationFormat

2014-09-09 Thread David Edmundson
> On Sept. 7, 2014, 1:48 p.m., David Edmundson wrote: > > I've just added kdeframeworks to the review group in case they have > > comments. > > Kai Uwe Broulik wrote: > Meh. Q_GADGET expands to add a static const QMetaObject staticMetaObject > and that's a BIC, right? https://techbase.kde

Re: Review Request 120092: Turn KFormat into Q_GADGET and expose DurationFormat

2014-09-09 Thread Kai Uwe Broulik
> On Sept. 7, 2014, 1:48 nachm., David Edmundson wrote: > > I've just added kdeframeworks to the review group in case they have > > comments. Meh. Q_GADGET expands to add a static const QMetaObject staticMetaObject and that's a BIC, right? - Kai Uwe

Re: Review Request 120087: Expose DurationFormatOption from KLocale

2014-09-09 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120087/#review66127 --- Ship it! Ship It! - Marco Martin On Sept. 9, 2014, 1:56 p.

Re: Review Request 120087: Expose DurationFormatOption from KLocale

2014-09-09 Thread Kai Uwe Broulik
> On Sept. 9, 2014, 2:18 nachm., David Edmundson wrote: > > The Q_DECLARE should be in kformat? It is. See Review 120092 - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120087/

Re: Review Request 120087: Expose DurationFormatOption from KLocale

2014-09-09 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120087/#review66125 --- The Q_DECLARE should be in kformat? - David Edmundson On Se

Re: Review Request 120087: Expose DurationFormatOption from KLocale

2014-09-09 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120087/ --- (Updated Sept. 9, 2014, 1:56 nachm.) Review request for Plasma. Changes

Re: Review Request 120110: Fix a crash when shutting down plasma shell, while destruction models

2014-09-09 Thread Joseph Wenninger
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120110/ --- (Updated Sept. 9, 2014, 11:49 vorm.) Status -- This change has been

Re: Review Request 120110: Fix a crash when shutting down plasma shell, while destruction models

2014-09-09 Thread Joseph Wenninger
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120110/ --- (Updated Sept. 9, 2014, 11:48 vorm.) Review request for KDE Frameworks an

Re: Review Request 120110: Fix a crash when shutting down plasma shell, while destruction models

2014-09-09 Thread David Edmundson
> On Sept. 9, 2014, 9:04 a.m., David Edmundson wrote: > > src/declarativeimports/core/datasource.cpp, line 171 > > > > > > Nice work identifying the cause, but I think we can improve the fix. > > > > We

Re: Review Request 120110: Fix a crash when shutting down plasma shell, while destruction models

2014-09-09 Thread Joseph Wenninger
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120110/ --- (Updated Sept. 9, 2014, 10:38 vorm.) Review request for KDE Frameworks an

Re: Review Request 120110: Fix a crash when shutting down plasma shell, while destruction models

2014-09-09 Thread Joseph Wenninger
> On Sept. 9, 2014, 9:04 vorm., David Edmundson wrote: > > src/declarativeimports/core/datasource.cpp, line 171 > > > > > > Nice work identifying the cause, but I think we can improve the fix. > > > > We

Re: Review Request 120110: Fix a crash when shutting down plasma shell, while destruction models

2014-09-09 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120110/#review66107 --- src/declarativeimports/core/datasource.cpp

Re: Review Request 120110: Fix a crash when shutting down plasma shell, while destruction models

2014-09-09 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120110/#review66098 --- src/declarativeimports/core/datasource.cpp

Review Request 120110: Fix a crash when shutting down plasma shell, while destruction models

2014-09-09 Thread Joseph Wenninger
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120110/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor