Re: Plasma popup window types

2014-08-17 Thread Martin Gräßlin
On Sunday 17 August 2014 22:03:08 Kai Uwe Broulik wrote: > Hi there, > > I noticed that the scalein effect is applied to plasma popups interfering > with the slidingpopups effect. > > The scalein checks for not window.popupMenu and window.specialWindow and > window.utility and window.minimized as

Review Request 119817: Display notification popup at the top for top panel

2014-08-17 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119817/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Plasma popup window types

2014-08-17 Thread Kai Uwe Broulik
Hi there, I noticed that the scalein effect is applied to plasma popups interfering with the slidingpopups effect. The scalein checks for not window.popupMenu and window.specialWindow and window.utility and window.minimized as well as not effect.isGrabbed(window, Effect.WindowAddedGrabRole), h

Re: Review Request 112208: KMix qml applet

2014-08-17 Thread Diego Casella
> On Aug. 12, 2014, 11:19 a.m., Christian Esken wrote: > > For me it looks fine, with some questions: > > 1) Is this completely decoupled from KMix? I do not see a "open mixer" to > > open the main application. > > 2) Is it supposed to be integrated in KMix > > 3) In general, the question is how

Re: Review Request 119781: Port TextArea to QtControls

2014-08-17 Thread David Edmundson
> On Aug. 17, 2014, 1:38 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/TextAreaStyle.qml, line > > 30 > > > > > > I can see why you're doing this but I think this approach is

Re: Review Request 119814: [ksld] ScreenLocker inhibits sleep on logind

2014-08-17 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119814/#review64680 --- "what do you think is the best solution for handling the "lock

Re: Paste Sticky note onto panel

2014-08-17 Thread Kai Uwe Broulik
> yes, is intended (and i was regularly using it in kde4, had a side panel just > for that actually), when not locked (if this happens when actually locked is > a > problem) but note that locked != just panel controller closed Right, I had widgets unlocked. Now that mediacontroller handles midd

Review Request 119814: [ksld] ScreenLocker inhibits sleep on logind

2014-08-17 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119814/ --- Review request for Plasma and Àlex Fiestas. Repository: plasma-workspace

Re: Paste Sticky note onto panel

2014-08-17 Thread Marco Martin
On Saturday 16 August 2014, Kai Uwe Broulik wrote: > Hi there, > > I just discovered when middleclicking a panel it will dump a sticky note > there like it does on the desktop. Is this intended? Looks weird to me, at > least when not in panel config mode. yes, is intended (and i was regularly usi

Re: Review Request 119781: Port TextArea to QtControls

2014-08-17 Thread Marco Martin
> On Aug. 17, 2014, 1:38 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/TextAreaStyle.qml, line > > 30 > > > > > > I can see why you're doing this but I think this approach is

Re: Review Request 119813: Show activity-linked files in folder view option

2014-08-17 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119813/#review64674 --- Looks good, but: I'm aware of at least one downstream that wou

Review Request 119813: Show activity-linked files in folder view option

2014-08-17 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119813/ --- Review request for Plasma, Eike Hein, Marco Martin, and Sebastian Kügler.

Re: Review Request 119781: Port TextArea to QtControls

2014-08-17 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119781/#review64672 --- src/declarativeimports/plasmacomponents/qml/styles/TextAreaSt