Jenkins build is back to normal : plasma-desktop_master_qt5 #488

See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119455: make Button a QtControl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119455/ --- (Updated July 24, 2014, 6:17 p.m.) Review request for KDE Frameworks and

Re: Review Request 119455: make Button a QtControl

> On July 24, 2014, 4:56 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml, line 83 > > > > > > style.labelImplicitWidth doesn't exist? gah, leftover - Marco

Re: Review Request 119455: make Button a QtControl

> On July 24, 2014, 4:56 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml, line 41 > > > > > > This isn't very declarative, is there a reason we can't do: > >

Re: Review Request 119455: make Button a QtControl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119455/#review63091 --- src/declarativeimports/plasmacomponents/qml/styles/ButtonStyl

Re: Review Request 119455: make Button a QtControl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119455/ --- (Updated July 24, 2014, 4:31 p.m.) Review request for KDE Frameworks and

Re: Review Request 119455: make Button a QtControl

> On July 24, 2014, 4:20 p.m., Martin Gräßlin wrote: > > Concerning the icon names: for the Desktops Effects KCM the names are > > working without me doing anything. So there must be a solution hidden in > > the widgets emulating style. yes, the native style figures out that internally, create

Re: Review Request 119455: make Button a QtControl

> On July 24, 2014, 4:18 p.m., Andrew Lake wrote: > > Exciting! > > > > Might this eventually support a ButtonStyle.qml in the plasma theme that > > overrides the svg-based ButtonStyle if it's present? That way we could take > > the already developed Breeze ButtonStyle.qml and just ship it in

Re: Review Request 119455: make Button a QtControl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119455/#review63087 --- Concerning the icon names: for the Desktops Effects KCM the na

Re: Review Request 119455: make Button a QtControl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119455/#review63086 --- Exciting! Might this eventually support a ButtonStyle.qml in

Review Request 119455: make Button a QtControl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119455/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Build failed in Jenkins: plasma-desktop_master_qt5 #487

See Changes: [kensington] Fix header include to match plasma-workspace change. -- [...truncated 2488 lines...]

Re: Review Request 119452: Rename libkworkspace for coinstallability with kde-workspace4.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119452/ --- (Updated July 24, 2014, 3:40 p.m.) Status -- This change has been ma

Re: Review Request 119425: Cache the textures created for the fast path

> On July 24, 2014, 10:55 a.m., David Edmundson wrote: > > src/declarativeimports/core/framesvgitem.cpp, line 45 > > > > > > Having spoken to you offline this does make sense, but it needs > > documentation as to

Re: Review Request 119425: Cache the textures created for the fast path

> On July 24, 2014, 10:55 a.m., David Edmundson wrote: > > src/declarativeimports/core/framesvgitem.cpp, line 45 > > > > > > Having spoken to you offline this does make sense, but it needs > > documentation as to

Re: Review Request 119425: Cache the textures created for the fast path

> On July 24, 2014, 10:55 a.m., David Edmundson wrote: > > src/declarativeimports/core/framesvgitem.cpp, line 45 > > > > > > Having spoken to you offline this does make sense, but it needs > > documentation as to

Re: Review Request 119425: Cache the textures created for the fast path

> On July 24, 2014, 10:55 a.m., David Edmundson wrote: > > src/declarativeimports/core/framesvgitem.cpp, line 45 > > > > > > Having spoken to you offline this does make sense, but it needs > > documentation as to

Re: Review Request 119425: Cache the textures created for the fast path

> On July 24, 2014, 10:55 a.m., David Edmundson wrote: > > src/declarativeimports/core/framesvgitem.cpp, line 45 > > > > > > Having spoken to you offline this does make sense, but it needs > > documentation as to

Re: Review Request 119451: some machinery for look and feel package

> On July 24, 2014, 12:34 p.m., David Edmundson wrote: > > lookandfeelaccess/lookandfeelaccess.cpp, line 89 > > > > > > My concern is this will create more problems than it's worth. > > > > Scenario: > >

Re: Review Request 119425: Cache the textures created for the fast path

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119425/ --- (Updated July 24, 2014, 11:14 a.m.) Review request for Plasma. Changes

Re: Review Request 119425: Cache the textures created for the fast path

> On July 24, 2014, 10:55 a.m., David Edmundson wrote: > > src/declarativeimports/core/framesvgitem.cpp, line 45 > > > > > > Having spoken to you offline this does make sense, but it needs > > documentation as to

Re: Review Request 119425: Cache the textures created for the fast path

> On July 24, 2014, 10:55 a.m., David Edmundson wrote: > > src/declarativeimports/core/framesvgitem.cpp, line 45 > > > > > > Having spoken to you offline this does make sense, but it needs > > documentation as to

Re: Review Request 119451: some machinery for look and feel package

> On July 24, 2014, 10:34 a.m., David Edmundson wrote: > > lookandfeelaccess/lookandfeelaccess.cpp, line 89 > > > > > > My concern is this will create more problems than it's worth. > > > > Scenario: > >

Re: Review Request 119425: Cache the textures created for the fast path

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119425/#review63049 --- src/declarativeimports/core/framesvgitem.cpp

Re: Review Request 119451: some machinery for look and feel package

> On July 24, 2014, 10:34 a.m., David Edmundson wrote: > > lookandfeelaccess/lookandfeelaccess.cpp, line 89 > > > > > > My concern is this will create more problems than it's worth. > > > > Scenario: > >

Re: Review Request 119451: some machinery for look and feel package

On July 24, 2014, 10:34 a.m., Marco Martin wrote: > > I'd quite like to have a chat about the goals of look and feel (next Monday > > meeting?). It was something where you guys clearly had a plan (or at least > > a name) before I got more heavily involved in Plasma, and I'm really not on > > t

Re: Review Request 119451: some machinery for look and feel package

> On July 24, 2014, 10:34 a.m., David Edmundson wrote: > > lookandfeelaccess/shellpluginloader.h, line 31 > > > > > > not used? that is just the header 1:1 coming from libplasmaquick, usual old problem - Marco

Re: Review Request 119451: some machinery for look and feel package

> On July 24, 2014, 10:34 a.m., David Edmundson wrote: > > lookandfeelaccess/lookandfeelaccess.cpp, line 89 > > > > > > My concern is this will create more problems than it's worth. > > > > Scenario: > >

Re: Review Request 119452: Rename libkworkspace for coinstallability with kde-workspace4.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119452/#review63043 --- Ship it! fine for me - Marco Martin On Lug. 24, 2014, 10:1

Re: Review Request 119451: some machinery for look and feel package

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119451/#review63037 --- lookandfeelaccess/lookandfeelaccess.cpp

Review Request 119452: Rename libkworkspace for coinstallability with kde-workspace4.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119452/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 119451: some machinery for look and feel package

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119451/#review63040 --- Also another problem connected to this: how to take the defau

Review Request 119451: some machinery for look and feel package

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119451/ --- Review request for Plasma. Repository: plasma-workspace Description ---