Re: Review Request 119250: Events and trips according to date ranges

2014-07-20 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119250/#review62748 --- Ship it! Ship It! - Sinny Kumari On July 20, 2014, 5:14 p.

Re: ToolButtons and focus

2014-07-20 Thread Marco Martin
On Sunday 20 July 2014, Frederik Gladhorn wrote: > That made me wonder if Tool Buttons shouldn't receive the tab focus by > default. I'm not 100% sure, but my gut-feeling says that might be a good > idea. Currently that's intentionally not the case - aligning well with > QWidgets. I wonder though i

Re: Review Request 119250: Events and trips according to date ranges

2014-07-20 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119250/ --- (Updated July 20, 2014, 5:14 p.m.) Review request for Plasma. Changes -

Re: Assign plasmoid global shortcut to custom action

2014-07-20 Thread Simone Gaiarin
>From the documentation of Plasma Applet I've red that I need to run addAssociatedWidget(someWidget) to make the actions work. I've done this: //Initialize the plasmoid using an IconWidget m_button = new Plasma::IconWidget(this); m_button->setIcon(KIcon("redshift-status-off")); m

Re: Review Request 119379: Lockscreen accessibility

2014-07-20 Thread Frederik Gladhorn
> On July 20, 2014, 4:11 p.m., David Edmundson wrote: > > lookandfeel/contents/components/LogoutOptions.qml, line 64 > > > > > > I think this may need to be i18ncd; unless someone is setting the > > catalog on th

ToolButtons and focus

2014-07-20 Thread Frederik Gladhorn
Hello, I just looked at the screen locker from an accessibility point of view (it's kinda' buggersome when there's no way to get back into a session after it has been locked) and with a bit of nudging (see review request) I can use it nicely. Not perfect, but good enough to get back to work. N

Re: Review Request 119379: Lockscreen accessibility

2014-07-20 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119379/#review62741 --- lookandfeel/contents/components/LogoutOptions.qml

Re: Review Request 119379: Lockscreen accessibility

2014-07-20 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119379/#review62742 --- Ship it! Ship It! - Martin Gräßlin On July 20, 2014, 6:05

Review Request 119379: Lockscreen accessibility

2014-07-20 Thread Frederik Gladhorn
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119379/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 119250: Events and trips according to date ranges

2014-07-20 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119250/#review62740 --- Works fine now. Just two minor fix: 1. New events with blank n

Re: Review Request 119250: Events and trips according to date ranges

2014-07-20 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119250/ --- (Updated July 20, 2014, 3:08 p.m.) Review request for Plasma. Changes -

Assign plasmoid global shortcut to custom action

2014-07-20 Thread Simone Gaiarin
Hi all, I'm trying to use the global shortcut that the user can configure from the "Shortcut configuration page" of a plasma applet, to trigger a KAction and let the plasmoid do something. I've done this //Setup the action m_toggleAction = new KAction("ToggleAction", this); //Add acti