Re: Review Request 118866: Start playing after Play All is used

2014-06-21 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118866/#review60679 --- This should also be fixed in Browse Music backend for consiste

Re: Review Request 118866: Start playing after Play All is used

2014-06-21 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118866/ --- (Updated June 21, 2014, 5:43 p.m.) Review request for Plasma. Changes -

Review Request 118866: Start playing after Play All is used

2014-06-21 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118866/ --- Review request for Plasma. Repository: plasma-mediacenter Description -

Re: Review Request 116874: Patch for the next and previous button functionality in an inactive playlist.

2014-06-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116874/#review60674 --- This review has been submitted with commit 97e717aae08e03fa4f

Re: Review Request 116874: Patch for the next and previous button functionality in an inactive playlist.

2014-06-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116874/#review60670 --- This review has been submitted with commit fec9938bcef6dd8847

Re: Review Request 116874: Patch for the next and previous button functionality in an inactive playlist.

2014-06-21 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116874/ --- (Updated June 21, 2014, 3:58 p.m.) Status -- This change has been ma

Re: Review Request 116874: Patch for the next and previous button functionality in an inactive playlist.

2014-06-21 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116874/#review60669 --- Ship it! Ship It! - Shantanu Tushar On June 21, 2014, 3:55

Re: Review Request 116874: Patch for the next and previous button functionality in an inactive playlist.

2014-06-21 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116874/ --- (Updated June 21, 2014, 3:55 p.m.) Review request for Plasma, Shantanu Tu

Re: Review Request 116874: Patch for the next and previous button functionality in an inactive playlist.

2014-06-21 Thread R.Harish Navnit
> On June 21, 2014, 1:59 p.m., Shantanu Tushar wrote: > > mediaelements/mediacontroller/MediaController.qml, line 100 > > > > > > runtimeData.playing || runtimeData.paused should work better, thats > > usually t

Re: Background for login, splash, and lockscreen

2014-06-21 Thread Mark Gaiser
On Sat, Jun 21, 2014 at 5:32 PM, Martin Klapetek wrote: > On Sat, Jun 21, 2014 at 5:21 PM, Mark Gaiser wrote: >> >> >> That makes me think.. Would it be technically possible to just use a >> blur filter for the login part (it's in QML right? then you can use >> the QtGraphicalEffects to blur) and

Re: Background for login, splash, and lockscreen

2014-06-21 Thread Martin Klapetek
On Sat, Jun 21, 2014 at 5:21 PM, Mark Gaiser wrote: > > That makes me think.. Would it be technically possible to just use a > blur filter for the login part (it's in QML right? then you can use > the QtGraphicalEffects to blur) and then decrease the blur to 0 when > logging in? That would look r

Re: Background for login, splash, and lockscreen

2014-06-21 Thread Mark Gaiser
On Sat, Jun 21, 2014 at 4:42 PM, Jens wrote: > Ok so then I propose we use two days or so creating a new default background > unless Nuno replies today. > I mean we base if off this one or something... > > On Saturday 21 June 2014 07.06.54 Andrew Lake wrote: >> Just for clarity I'm only proposing

Jenkins build became unstable: plasma-workspace_master_qt5 #515

2014-06-21 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Background for login, splash, and lockscreen

2014-06-21 Thread Jens
Ok so then I propose we use two days or so creating a new default background unless Nuno replies today. I mean we base if off this one or something... On Saturday 21 June 2014 07.06.54 Andrew Lake wrote: > Just for clarity I'm only proposing the blurred version for the login, > splash and locks

Review Request 118865: [startkde from plasma next] create ~/.kde directory if it doesn't exist

2014-06-21 Thread José Manuel Santamaría Lema
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118865/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Background for login, splash, and lockscreen

2014-06-21 Thread Marco Martin
On Saturday 21 June 2014, Kai Uwe Broulik wrote: > Can't we just use QtGraphicalEffects and just blur (and/or desaturate > and/or darken) whatever picture the user has chosen? > > The overall performance of these is great (at least on Android which is > slow in any other QtQuick respect) but their

Re: Background for login, splash, and lockscreen

2014-06-21 Thread Kai Uwe Broulik
Can't we just use QtGraphicalEffects and just blur (and/or desaturate and/or darken) whatever picture the user has chosen? The overall performance of these is great (at least on Android which is slow in any other QtQuick respect) but their instantiation takes ages, so might not be suitable for

Re: Background for login, splash, and lockscreen

2014-06-21 Thread Andrew Lake
Just for clarity I'm only proposing the blurred version for the login, splash and lockscreen. The normal, non-blurred version for actual desktop - nuno's wallpaper - is untouched and I assumed that one, or a "finished" version of it, would be default. Whatever ends up as the default, I'd propose a

Re: Review Request 116874: Patch for the next and previous button functionality in an inactive playlist.

2014-06-21 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116874/#review60666 --- Looks good to me, just one suggestion mediaelements/mediacon

Re: Review Request 116460: Footer clock fix

2014-06-21 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116460/#review60664 --- This review request should be marked as discarded now. Thank

Re: Review Request 118796: [notifications] Introduce a list of apps that are limited to single notification only

2014-06-21 Thread Celeste Lyn Paul
> On June 21, 2014, 1:13 p.m., Celeste Lyn Paul wrote: > > Ship It! This is great and follows one of the recommendations I made in my KDE Notifications research. - Celeste Lyn --- This is an automatically generated e-mail. To reply, vi

Re: Review Request 118796: [notifications] Introduce a list of apps that are limited to single notification only

2014-06-21 Thread Celeste Lyn Paul
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118796/#review60660 --- Ship it! Ship It! - Celeste Lyn Paul On June 20, 2014, 1:2

Re: Background for login, splash, and lockscreen

2014-06-21 Thread Jens
I am +1 about blurring the login AND as for the wallpaper: I've talked to Nuno about it and there is some "Mggrmmrl" going on there since he has fallen out of love with it and we still need him to send us the proper SVG's off it so we can do several different resolutions of it. If Andrews wallpa

Re: Background for login, splash, and lockscreen

2014-06-21 Thread Marco Martin
On Saturday 21 June 2014 00:25:35 Andrew Lake wrote: > Hello all, > > With the sharpness of the default background image in the login, splash and > lockscreen, both the foreground and background appear to be in focus - > causing a slightly uncomfortable lack of depth. Things seem to look better >

Re: Review Request 118824: Fix for "Bug 336414 - Playlist switching doesnt move highlight"

2014-06-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118824/#review60644 --- This review has been submitted with commit f5118554d78a471c28

Re: Review Request 118759: Add a separator to the path where PMC stores playlist file

2014-06-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118759/#review60643 --- This review has been submitted with commit a9a575cdb76887751b

Re: Review Request 118691: Change currentIndex of playlistModel to -1 when a media is not from playlist

2014-06-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118691/#review60642 --- This review has been submitted with commit 1e05c24eadd0668345

Re: Review Request 118688: Avoid crash when artist is invalid

2014-06-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118688/#review60641 --- This review has been submitted with commit d9bc355a07eb898b8b

Re: Review Request 118767: Fix for "Bug 328532 - Remember the playlist I was using when I closed PMC last time"

2014-06-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118767/#review60645 --- This review has been submitted with commit 312950ac1408cf421a

Re: Review Request 118468: Use the spacebar key to play/pause a media from the homescreen.

2014-06-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118468/#review60640 --- This review has been submitted with commit 64e556652117408dcf

Background for login, splash, and lockscreen

2014-06-21 Thread Andrew Lake
Hello all, With the sharpness of the default background image in the login, splash and lockscreen, both the foreground and background appear to be in focus - causing a slightly uncomfortable lack of depth. Things seem to look better with a defocused and slightly dimmed background - the foreground