Review Request 118251: Small improvments to FadingNode and IconItem

2014-05-21 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118251/ --- Review request for Plasma and David Edmundson. Repository: plasma-framewo

Re: Icons for Paste Bin and Paste

2014-05-21 Thread Jens Reuterberg
http://wstaw.org/m/2014/05/21/pastebin.svg http://wstaw.org/m/2014/05/21/harddrive.svg So these two in sorta the style of fabian, do they work for now? Will do the plasmoid preview too On Wednesday 21 May 2014 10.23.39 Jens Reuterberg wrote: > Ok I'm on it. Have some laundry to do but will get

Re: plasma packages in kde-workspace

2014-05-21 Thread Vishesh Handa
On Wed, May 21, 2014 at 4:59 PM, Marco Martin wrote: > > That should be fine, if as in kde-workspace times, if the policy is kept to > workspace can contain libraries, but won't guarantee compatibility until > moved > in frameworks > Okay. No objections from me then. -- Vishesh Handa

Re: plasma packages in kde-workspace

2014-05-21 Thread Marco Martin
On Wednesday 21 May 2014 16:49:47 Vishesh Handa wrote: > On Wed, May 21, 2014 at 4:01 PM, Jonathan Riddell wrote: > > Some parts of what is now being released as Plasma aren't in kde-workspace > > on projects.kde.org. I'd like to move the following to kde-workspace, > > let me know if that's a pr

Re: plasma packages in kde-workspace

2014-05-21 Thread Vishesh Handa
On Wed, May 21, 2014 at 4:01 PM, Jonathan Riddell wrote: > > Some parts of what is now being released as Plasma aren't in kde-workspace > on projects.kde.org. I'd like to move the following to kde-workspace, > let me know if that's a problem > > baloo > milou > powerdevil > kfilemetadata >

plasma packages in kde-workspace

2014-05-21 Thread Jonathan Riddell
Some parts of what is now being released as Plasma aren't in kde-workspace on projects.kde.org. I'd like to move the following to kde-workspace, let me know if that's a problem baloo milou powerdevil kfilemetadata Jonathan ___ Plasma-devel maili

Re: Icons for Paste Bin and Paste

2014-05-21 Thread Jens Reuterberg
Marco if you have a list send it send it :) On Tuesday 20 May 2014 19.00.08 Marco Martin wrote: > On Tuesday 20 May 2014, Ivan Čukić wrote: > > The issue is a bit broader. > > > > 1. There are a few whose icons are overlapping (my favourite is an icon > > with an analogue clock on the digital clo

Re: Review Request 118205: Turn the free space notifier into StatusNotifierItem

2014-05-21 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118205/ --- (Updated May 21, 2014, 11:33 a.m.) Status -- This change has been ma

Re: Review Request 118205: Turn the free space notifier into StatusNotifierItem

2014-05-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118205/#review58234 --- This review has been submitted with commit 66c83af0baaf018947

Re: Icons for Paste Bin and Paste

2014-05-21 Thread Jens Reuterberg
Ok I'm on it. Have some laundry to do but will get to "the office" after lunch On Wednesday 21 May 2014 10.20.03 Martin Klapetek wrote: > Speaking of which - we do need one new systray icon for [1], the current > oxygen one is "drive-harddisk". It shows up when you're running low on your > disk sp

Re: Icons for Paste Bin and Paste

2014-05-21 Thread Martin Klapetek
Speaking of which - we do need one new systray icon for [1], the current oxygen one is "drive-harddisk". It shows up when you're running low on your disk space, so doesn't need to be a hard drive icon but something resembling that. [1] - https://git.reviewboard.kde.org/r/118205/file/1263/ Cheers

Re: Review Request 118205: Turn the free space notifier into StatusNotifierItem

2014-05-21 Thread Martin Klapetek
> On May 21, 2014, 7:36 a.m., Sebastian Kügler wrote: > > freespacenotifier/freespacenotifier.cpp, line 105 > > > > > > I wonder if fsInfo.size() can ever be 0? Please check that, in order to > > avoid divide by