Jenkins build is still unstable: plasma-workspace_master_qt5 #239

2014-05-16 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118092: Left and right movement in All music

2014-05-16 Thread Sujith Haridasan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118092/ --- (Updated May 16, 2014, 6:36 p.m.) Review request for Plasma, Shantanu Tus

Jenkins build is still unstable: plasma-workspace_master_qt5 #238

2014-05-16 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 118169: Rename pkgconfig file

2014-05-16 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118169/ --- Review request for Plasma and Jonathan Riddell. Repository: libkscreen

Re: Ship with Aurorae and Qtcurve or not...

2014-05-16 Thread Andrew Lake
On Fri, May 16, 2014 at 6:29 AM, Jens Reuterberg wrote: > I am already pinged and have pinged Andrew > > Best I can tell, the new Plasma Next plan for visuals is: * Widget style: QtCurve with Breeze settings applied for qt4 and qt5 QWidget apps * Window decoration: Oxygen with background gradi

Re: Breeze repo

2014-05-16 Thread Marco Martin
On Friday 16 May 2014, Andrew Lake wrote: > No problem on merging Marco. > done ;) -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Breeze repo

2014-05-16 Thread Andrew Lake
No problem on merging Marco. On Fri, May 16, 2014 at 4:39 AM, Marco Martin wrote: > On Thursday 15 May 2014, Marco Martin wrote: > > On Monday 05 May 2014, Andrew Lake wrote: > > > I went ahead and added a 'working' branch and added the following: > > going into "resuscitating dead threads" aga

Re: Ship with Aurorae and Qtcurve or not...

2014-05-16 Thread Marco Martin
On Friday 16 May 2014, Ivan Čukić wrote: > > > at the moment is a kde4 application to be safer to access config of > > > kde4 (otherwise i guess would be possible by just accessing ~/.kde or > > > ~/kde4 going by attempts, but a bit more error prone perhaps) > > > > We should be able to check KDE

Re: Review Request 118126: Show applets from the system tray in Widget Explorer

2014-05-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118126/#review58072 --- that's the least terrible. registering the containment to the

Re: Review Request 118126: Show applets from the system tray in Widget Explorer

2014-05-16 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118126/#review58071 --- BUMP. - David Edmundson On May 14, 2014, 1:08 p.m., David

Re: Ship with Aurorae and Qtcurve or not...

2014-05-16 Thread Ivan Čukić
> > at the moment is a kde4 application to be safer to access config of kde4 > > (otherwise i guess would be possible by just accessing ~/.kde or ~/kde4 > > going by attempts, but a bit more error prone perhaps) > > We should be able to check KDEDIRS first here? (It's unused in KF5, but > could

Re: Ship with Aurorae and Qtcurve or not...

2014-05-16 Thread Sebastian Kügler
On Friday, May 16, 2014 16:20:26 Marco Martin wrote: > On Friday 16 May 2014, David Edmundson wrote: > > We have an extra month. Lets do it. > > > > > > > > As for your application, I think we need a guard on > > if (QFile::exists( theQStyleRcFile ) { > > > > return; > > > > } > > so we don't tr

Re: Ship with Aurorae and Qtcurve or not...

2014-05-16 Thread Marco Martin
On Friday 16 May 2014, David Edmundson wrote: > We have an extra month. Lets do it. > > As for your application, I think we need a guard on > if (QFile::exists( theQStyleRcFile ) { > return; > } > so we don't trash user configs. > > group.writeEntry("widgetStyle", "oxygen"); > seems wrong > >

Re: Ship with Aurorae and Qtcurve or not...

2014-05-16 Thread David Edmundson
We have an extra month. Lets do it. As for your application, I think we need a guard on if (QFile::exists( theQStyleRcFile ) { return; } so we don't trash user configs. group.writeEntry("widgetStyle", "oxygen"); seems wrong Is the plan to add a kconf_update script to run this? Or have it run b

Re: Review Request 118092: Left and right movement in All music

2014-05-16 Thread Shantanu Tushar
> On May 16, 2014, 4:20 a.m., Ashish Madeti wrote: > > Now if you are on Songs tab, a single left/right key press will take you to > > Artists/Albums section but when you return to Songs section, the focus is > > still on tab bar. Due to this user has to first go to the list by pressing > > do

Re: Review Request 118092: Left and right movement in All music

2014-05-16 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118092/#review58065 --- components/listbrowser/ListBrowser.qml

Jenkins build is still unstable: plasma-workspace_master_qt5 #237

2014-05-16 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Ship with Aurorae and Qtcurve or not...

2014-05-16 Thread Marco Martin
On Friday 16 May 2014, Thomas Pfeiffer wrote: > > i see here a giant thread of opinions wether "would look nice" or not, > > and zero about concrete steps about how to solve the whole mess. > > that's not cool > > Do you need input from developers or designers? If designer input is > needed, just

Re: Ship with Aurorae and Qtcurve or not...

2014-05-16 Thread Jens Reuterberg
I am already pinged and have pinged Andrew On Fri, May 16, 2014 at 3:28 PM, Thomas Pfeiffer wrote: > On Friday 16 May 2014 13:37:34 Marco Martin wrote: > > On Thursday 15 May 2014, Marco Martin wrote: > > > btw, i added a small kde4 application in the breeze repo in the branch > > > mart/kde

Re: Ship with Aurorae and Qtcurve or not...

2014-05-16 Thread Thomas Pfeiffer
On Friday 16 May 2014 13:37:34 Marco Martin wrote: > On Thursday 15 May 2014, Marco Martin wrote: > > btw, i added a small kde4 application in the breeze repo in the branch > > mart/kde4breeze > > that tries to set qtcurve, apply colors etc in the kde4 session. > > Do we go in this direction? > >

Re: Review Request 118160: [screenlocker] Move grace time unlock functionality to KSLDApp

2014-05-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118160/ --- (Updated May 16, 2014, 1:26 p.m.) Status -- This change has been mar

Re: Review Request 118160: [screenlocker] Move grace time unlock functionality to KSLDApp

2014-05-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118160/#review58060 --- This review has been submitted with commit 5c78986e1aea066cab

Re: Review Request 118160: [screenlocker] Move grace time unlock functionality to KSLDApp

2014-05-16 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118160/#review58059 --- Ship it! Ship It! - David Edmundson On May 16, 2014, 1:20

Re: Review Request 118160: [screenlocker] Move grace time unlock functionality to KSLDApp

2014-05-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118160/ --- (Updated May 16, 2014, 3:20 p.m.) Review request for Plasma and David Edm

Re: Review Request 118160: [screenlocker] Move grace time unlock functionality to KSLDApp

2014-05-16 Thread Martin Gräßlin
> On May 16, 2014, 2:46 p.m., David Edmundson wrote: > > ksmserver/screenlocker/lockwindow.cpp, line 307 > > > > > > This is a behavioural change as we no longer have the return. > > > > Now we'll be in

Re: Review Request 118160: [screenlocker] Move grace time unlock functionality to KSLDApp

2014-05-16 Thread David Edmundson
> On May 16, 2014, 12:46 p.m., David Edmundson wrote: > > ksmserver/screenlocker/lockwindow.cpp, line 307 > > > > > > This is a behavioural change as we no longer have the return. > > > > Now we'll be i

Re: Review Request 118160: [screenlocker] Move grace time unlock functionality to KSLDApp

2014-05-16 Thread Martin Gräßlin
> On May 16, 2014, 2:46 p.m., David Edmundson wrote: > > ksmserver/screenlocker/lockwindow.cpp, line 307 > > > > > > This is a behavioural change as we no longer have the return. > > > > Now we'll be in

Re: Review Request 118160: [screenlocker] Move grace time unlock functionality to KSLDApp

2014-05-16 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118160/#review58055 --- ksmserver/screenlocker/lockwindow.cpp

Re: Breeze repo

2014-05-16 Thread Marco Martin
On Thursday 15 May 2014, Marco Martin wrote: > On Monday 05 May 2014, Andrew Lake wrote: > > I went ahead and added a 'working' branch and added the following: > going into "resuscitating dead threads" again: > > can the working branch be merged now? ping again, just to remind about how horribly

Re: Ship with Aurorae and Qtcurve or not...

2014-05-16 Thread Marco Martin
On Thursday 15 May 2014, Marco Martin wrote: > btw, i added a small kde4 application in the breeze repo in the branch > mart/kde4breeze > that tries to set qtcurve, apply colors etc in the kde4 session. > Do we go in this direction? err, would be cool at least to know if i have to invest time in t

Re: Ship with Aurorae and Qtcurve or not...

2014-05-16 Thread Marco Martin
On Friday 16 May 2014, David Edmundson wrote: > On Fri, May 16, 2014 at 1:04 PM, Jens Reuterberg wrote: > > Screenshot? > > http://imgur.com/Px6n2YO the buttons are quite alien, but may be bearable -- Marco Martin ___ Plasma-devel mailing list Plasma

Re: Re: Re: Ship with Aurorae and Qtcurve or not...

2014-05-16 Thread Martin Gräßlin
On Friday 16 May 2014 13:11:37 David Edmundson wrote: > On Fri, May 16, 2014 at 1:04 PM, Jens Reuterberg wrote: > > Screenshot? > > http://imgur.com/Px6n2YO true, looks quite good. That's with gradient disabled, isn't it? signature.asc Description: This is a digitally signed message part. _

Re: Re: Ship with Aurorae and Qtcurve or not...

2014-05-16 Thread David Edmundson
On Fri, May 16, 2014 at 1:04 PM, Jens Reuterberg wrote: > Screenshot? http://imgur.com/Px6n2YO ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Re: Ship with Aurorae and Qtcurve or not...

2014-05-16 Thread Jens Reuterberg
Screenshot? On Fri, May 16, 2014 at 12:41 PM, David Edmundson < da...@davidedmundson.co.uk> wrote: > QtCurve QStyle + Oxygen window dec is an option. > > I run it here, it looks ok. > ___ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mai

Re: Re: Ship with Aurorae and Qtcurve or not...

2014-05-16 Thread David Edmundson
QtCurve QStyle + Oxygen window dec is an option. I run it here, it looks ok. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins build is still unstable: plasma-workspace_master_qt5 #236

2014-05-16 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Re: Re: Jenkins build became unstable: plasma-workspace_master_qt5 #217

2014-05-16 Thread Martin Gräßlin
Martin GräßlinOn Friday 16 May 2014 08:35:50 wrote: > Martin GräßlinOn Wednesday 14 May 2014 14:14:26 wrote: > > On Wednesday 14 May 2014 12:14:39 KDE CI System wrote: > > > See > > > > seems to be my fault, apparently Jenkins (o

Review Request 118160: [screenlocker] Move grace time unlock functionality to KSLDApp

2014-05-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118160/ --- Review request for Plasma and David Edmundson. Repository: plasma-workspa