Re: Breeze QML window decoration

2014-05-04 Thread Martin Gräßlin
On Sunday 04 May 2014 22:28:23 Andrew Lake wrote: > Based on the design we came up with in the VDG forum, I completed a first > go at doing up a Aurorae QML window decoration. > > I added it to the 'working' branch of the Breeze repo. As far as I can tell > it works about as well as the Plastik QM

Re: Re: Fwd: [kconfig] src/core: Store app config file in ~/.config//rc

2014-05-04 Thread Martin Gräßlin
On Monday 05 May 2014 08:17:49 David Faure wrote: > On Monday 05 May 2014 07:25:37 Martin Gräßlin wrote: > > On Sunday 04 May 2014 23:53:40 David Faure wrote: > > > Hello, > > > > > > please note this change in KConfig. > > > > > > I would recommend making sure your applications call > > > app.se

Re: Fwd: [kconfig] src/core: Store app config file in ~/.config//rc

2014-05-04 Thread David Faure
On Monday 05 May 2014 07:25:37 Martin Gräßlin wrote: > On Sunday 04 May 2014 23:53:40 David Faure wrote: > > Hello, > > > > please note this change in KConfig. > > > > I would recommend making sure your applications call > > app.setOrganizationDomain("kde.org") so that the config files go into th

Re: Review Request 117822: Add safety checks to XCB functions in WindowThumbnail

2014-05-04 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117822/ --- (Updated May 5, 2014, 6:06 a.m.) Status -- This change has been mark

Re: Review Request 117822: Add safety checks to XCB functions in WindowThumbnail

2014-05-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117822/#review57280 --- This review has been submitted with commit 491befb8508095da35

Re: Breeze repo

2014-05-04 Thread Andrew Lake
I went ahead and added a 'working' branch and added the following: - Colors: This is the Breeze color scheme that has the both the style and the window decoration colors. I think this is releasable, so if there are no objections I'd like to move this over 'master' so it can ship in the june releas

Re: Fwd: [kconfig] src/core: Store app config file in ~/.config//rc

2014-05-04 Thread Martin Gräßlin
On Sunday 04 May 2014 23:53:40 David Faure wrote: > Hello, > > please note this change in KConfig. > > I would recommend making sure your applications call > app.setOrganizationDomain("kde.org") so that the config files go into the > right subdir right now. Otherwise you'll face migration issues

Breeze QML window decoration

2014-05-04 Thread Andrew Lake
Based on the design we came up with in the VDG forum, I completed a first go at doing up a Aurorae QML window decoration. I added it to the 'working' branch of the Breeze repo. As far as I can tell it works about as well as the Plastik QML decoration. Quick screenshot: http://wstaw.org/m/2014/05/

Re: Review Request 112208: KMix qml applet

2014-05-04 Thread Mark Gaiser
> On March 22, 2014, 11:09 p.m., Mark Gaiser wrote: > > Is there still an intention on getting this in KDE 4.xx? > > Just wondering since it seems to be much better then the current kmix popup. > > Christian Esken wrote: > I also haven't heard about further development here. Diego as origina

Re: Review Request 112208: KMix qml applet

2014-05-04 Thread Diego Casella
> On March 22, 2014, 11:09 p.m., Mark Gaiser wrote: > > Is there still an intention on getting this in KDE 4.xx? > > Just wondering since it seems to be much better then the current kmix popup. > > Christian Esken wrote: > I also haven't heard about further development here. Diego as origina

Fwd: [kconfig] src/core: Store app config file in ~/.config//rc

2014-05-04 Thread David Faure
Hello, please note this change in KConfig. I would recommend making sure your applications call app.setOrganizationDomain("kde.org") so that the config files go into the right subdir right now. Otherwise you'll face migration issues later when setting that. -- Forwarded Message

Re: Review Request 112208: KMix qml applet

2014-05-04 Thread Diego Casella
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112208/ --- (Updated May 4, 2014, 9:46 p.m.) Review request for Plasma, Aaron J. Seig

Re: Review Request 117900: Cleanup of screenlocker

2014-05-04 Thread Martin Gräßlin
> On May 1, 2014, 6:59 p.m., David Edmundson wrote: > > ksmserver/screenlocker/ksldapp.cpp, line 296 > > > > > > I don't see why we're using lambdas here. IMHO it's makes establishGrab > > more unreadable and ha

Re: Review Request 117981: Filter out images with image width lesser than 500 pixel in Plasma media Center

2014-05-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117981/#review57232 --- This review has been submitted with commit 25989b7d1581617c27

Re: Review Request 117981: Filter out images with image width lesser than 500 pixel in Plasma media Center

2014-05-04 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117981/ --- (Updated May 4, 2014, 8:30 a.m.) Status -- This change has been mark

Re: Review Request 117983: Nuke PmcImageProvider and streamline image providers

2014-05-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117983/#review57231 --- This review has been submitted with commit e911838bd72f48dce8

Re: Review Request 117983: Nuke PmcImageProvider and streamline image providers

2014-05-04 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117983/ --- (Updated May 4, 2014, 8:19 a.m.) Status -- This change has been mark

Re: Review Request 117894: Add a kscreenlocker_test test application

2014-05-04 Thread Martin Gräßlin
> On May 1, 2014, 7 p.m., David Edmundson wrote: > > The greeter is invokable on it's own anyway, what benefit does this have? I think you misunderstood: it's not to run the greeter but the server part in ksmserver which holds the X11 lock. - Martin -

Re: Review Request 117983: Nuke PmcImageProvider and streamline image providers

2014-05-04 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117983/#review57228 --- Ship it! Ship It! - Bhushan Shah On May 4, 2014, 12:28 p.m

Re: Review Request 117981: Filter out images with image width lesser than 500 pixel in Plasma media Center

2014-05-04 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117981/#review57227 --- Ship it! Few nitpicks, looks okay otherwise. plugins/kdedes

Review Request 117984: Try to prioritize photos taken by a camera-like device

2014-05-04 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117984/ --- Review request for Plasma. Repository: plasma-mediacenter Description -