Review Request 117923: Export everything by defult for test in plasmamediacentertest librray

2014-04-30 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117923/ --- Review request for Plasma. Repository: plasma-mediacenter Description -

Re: Review Request 117915: Fetch photo-taken Date/Time for Images and file created Date/Time for other files

2014-04-30 Thread Shantanu Tushar
> On May 1, 2014, 6:06 a.m., Commit Hook wrote: > > This review has been submitted with commit > > 121e51d74ff50a3644f275d5cfb571326c7a7286 by Shantanu Tushar to branch > > master. Had pushed this by mistake when trying to fix a bug, reverted it. The review is still open. - Shantanu -

Re: Review Request 117915: Fetch photo-taken Date/Time for Images and file created Date/Time for other files

2014-04-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117915/#review57044 --- This review has been submitted with commit 121e51d74ff50a3644

Re: Review Request 117915: Fetch photo-taken Date/Time for Images and file created Date/Time for other files

2014-04-30 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117915/ --- (Updated May 1, 2014, 6:06 a.m.) Status -- This change has been mark

[plasma-workspace/plasmashell+libkscreen] /: Adopt libkscreen to get information of the screens

2014-04-30 Thread Aleix Pol
Git commit 168c15a463746cf9039f2f9e188b1827ed809f97 by Aleix Pol. Committed on 01/05/2014 at 01:41. Pushed by apol into branch 'plasmashell+libkscreen'. Adopt libkscreen to get information of the screens Qt subsystem has deficiencies on their approximation to multiple screens. [1] This patch adop

Review Request 117915: Fetch photo-taken Date/Time for Images and file created Date/Time for other files

2014-04-30 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117915/ --- Review request for Plasma and Vishesh Handa. Repository: plasma-mediacent

Re: Review Request 117802: Merge ShowDesktop and ShowDashboard plasma applets into one

2014-04-30 Thread Gregor Mi
> On April 30, 2014, 9:04 a.m., Marco Martin wrote: > > The idea makes sense, however it's on Plasma1, that shouldn't have nev > > changes in. > > best thing would be to have this done directly in plasam2 Thanks for the affirmation. So I keep this request open until the the plasma2 version of

Re: Review Request 117899: Use Breeze bridge mouse cursor theme by default

2014-04-30 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117899/#review57021 --- Ship it! Still good to go. :) - Sebastian Kügler On April

Re: Review Request 117867: Do not cache media lists to a database

2014-04-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117867/#review57020 --- This review has been submitted with commit e90ac3ceae6815c04d

Re: Review Request 117867: Do not cache media lists to a database

2014-04-30 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117867/ --- (Updated April 30, 2014, 5:27 p.m.) Status -- This change has been m

Re: Review Request 117867: Do not cache media lists to a database

2014-04-30 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117867/#review57016 --- Ship it! Looks fine to me other than small issues mentioned i

Build failed in Jenkins: plasma-desktop_master_qt5 #112

2014-04-30 Thread KDE CI System
See Changes: [hein] Paranoia++. -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace

Re: Review Request 117867: Do not cache media lists to a database

2014-04-30 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117867/#review57015 --- libs/mediacenter/CMakeLists.txt

Build failed in Jenkins: plasma-desktop_master_qt5 #111

2014-04-30 Thread KDE CI System
See Changes: [hein] Fix uninitialized value, thanks apol. -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in works

Re: kio trash and 64bit

2014-04-30 Thread Marco Martin
On Wednesday 30 April 2014, Harald Sitter wrote: > alohas, > > today I noticed that kio-extras fails to build on Kubuntu 14.04 32bit > with the following lovely error: > > /build/buildd/project-neon5-kio-extras-0.0+git20140430.0800+neon4~4ab0de2~1 > 4.04/trash/trashimpl.cpp:225:57: error: size of

Re: Review Request 117906: set soversion to 5

2014-04-30 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117906/#review56998 --- Ship it! Ship It! - Sebastian Kügler On April 30, 2014, 3:

Review Request 117906: set soversion to 5

2014-04-30 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117906/ --- Review request for Plasma. Repository: plasma-desktop Description -

Review Request 117904: Set soversion to match Plasma

2014-04-30 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117904/ --- Review request for Plasma, Solid and Àlex Fiestas. Repository: powerdevil

Review Request 117903: Make notifications plasmoid reuse only 3 Dialogs instead of creating new one for each notification

2014-04-30 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117903/ --- Review request for Plasma. Repository: plasma-workspace Description ---

kio trash and 64bit

2014-04-30 Thread Harald Sitter
alohas, today I noticed that kio-extras fails to build on Kubuntu 14.04 32bit with the following lovely error: /build/buildd/project-neon5-kio-extras-0.0+git20140430.0800+neon4~4ab0de2~14.04/trash/trashimpl.cpp:225:57: error: size of array 'off_t_should_be_64bit' is negative which comes from thi

Re: Review Request 117899: Use Breeze bridge mouse cursor theme by default

2014-04-30 Thread Jonathan Riddell
> On April 30, 2014, 1:30 p.m., Sebastian Kügler wrote: > > Yes, please. > > > > (Is the breeze repo already integrated into kdesrc-build?) just added to kdesrc-build - Jonathan --- This is an automatically generated e-mail. To reply,

Re: Review Request 117899: Use Breeze bridge mouse cursor theme by default

2014-04-30 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117899/ --- (Updated April 30, 2014, 2:01 p.m.) Review request for Plasma. Changes

Review Request 117900: Cleanup of screenlocker

2014-04-30 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117900/ --- Review request for Plasma and David Edmundson. Repository: plasma-workspa

Fwd: Re: KDE Cursor Set

2014-04-30 Thread Jonathan Riddell
I'll post a review to rename the mouse cursors to breeze Jonathan - Forwarded message from Ken Vermette - Date: Wed, 30 Apr 2014 09:35:41 -0400 Subject: Re: KDE Cursor Set From: Ken Vermette To: Jonathan Riddell Sorry I haven't been active on the forums! I probably would have known

Re: Review Request 117899: Use Breeze bridge mouse cursor theme by default

2014-04-30 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117899/#review56987 --- Ship it! Yes, please. (Is the breeze repo already integrated

Review Request 117899: Use Breeze bridge mouse cursor theme by default

2014-04-30 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117899/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 117897: Don't hide Dialog with hideOnWindowDeactivate==true on focus out when dialog is ancestor of new focus window

2014-04-30 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117897/ --- (Updated April 30, 2014, 1:04 p.m.) Status -- This change has been m

Re: Review Request 117897: Don't hide Dialog with hideOnWindowDeactivate==true on focus out when dialog is ancestor of new focus window

2014-04-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117897/#review56986 --- This review has been submitted with commit 000d49463b7ad0252c

Re: Review Request 117897: Don't hide Dialog with hideOnWindowDeactivate==true on focus out when dialog is ancestor of new focus window

2014-04-30 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117897/ --- (Updated April 30, 2014, 12:28 p.m.) Review request for Plasma and Marco

Re: Review Request 117779: fix crash when textureNode->texture() is null

2014-04-30 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117779/ --- (Updated April 30, 2014, 2:21 p.m.) Status -- This change has been d

Re: Review Request 117897: Don't hide Dialog with hideOnWindowDeactivate==true on focus out when dialog is ancestor of new focus window

2014-04-30 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117897/ --- (Updated April 30, 2014, 12:07 p.m.) Review request for Plasma and Marco

Re: Review Request 117897: Don't hide Dialog with hideOnWindowDeactivate==true on focus out when dialog is ancestor of new focus window

2014-04-30 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117897/#review56976 --- Ship it! Ship It! - Marco Martin On April 30, 2014, 11:59

Review Request 117897: Don't hide Dialog with hideOnWindowDeactivate==true on focus out when dialog is ancestor of new focus window

2014-04-30 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117897/ --- Review request for Plasma and Marco Martin. Repository: plasma-framework

Re: Review Request 117824: Discard window thumbnail pixmap after texture got destroyed by SceneGraph

2014-04-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117824/#review56971 --- This review has been submitted with commit af5a855da42c3ada2f

Re: Review Request 117824: Discard window thumbnail pixmap after texture got destroyed by SceneGraph

2014-04-30 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117824/ --- (Updated April 30, 2014, 11:18 a.m.) Status -- This change has been

Re: Review Request 117824: Discard window thumbnail pixmap after texture got destroyed by SceneGraph

2014-04-30 Thread Martin Gräßlin
> On April 30, 2014, 12:30 p.m., David Edmundson wrote: > > src/declarativeimports/core/windowthumbnail.cpp, line 317 > > > > > > Do you still need this after the change above? > > > > I'm all for safet

Re: Review Request 117824: Discard window thumbnail pixmap after texture got destroyed by SceneGraph

2014-04-30 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117824/#review56962 --- Ship it! - David Edmundson On April 30, 2014, 5:44 a.m., Ma

Re: Review Request 117824: Discard window thumbnail pixmap after texture got destroyed by SceneGraph

2014-04-30 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117824/#review56961 --- src/declarativeimports/core/windowthumbnail.cpp

Beta moved to Friday

2014-04-30 Thread Jonathan Riddell
KF5 beta has moved forward a few days to this Sunday. So I've updated http://techbase.kde.org/Schedules/Plasma/2014.6_Release_Schedule to move the beta forward to Friday 9th May. Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail

Review Request 117894: Add a kscreenlocker_test test application

2014-04-30 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117894/ --- Review request for Plasma, David Edmundson and Wolfgang Bauer. Repository

Re: Review Request 117859: rename kioslave files for co-installability

2014-04-30 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117859/ --- (Updated April 30, 2014, 9:36 a.m.) Review request for Plasma. Changes

Re: Review Request 117876: rename kuiserver to kuiserver5 for coinstallability

2014-04-30 Thread Hrvoje Senjan
> On April 30, 2014, 12:56 a.m., Hrvoje Senjan wrote: > > kuiserver/CMakeLists.txt, line 73 > > > > > > i guess also org.kde.kuiserver.service would need adjusting ... > > Marco Martin wrote: > shouldn't the

Re: Review Request 117876: rename kuiserver to kuiserver5 for coinstallability

2014-04-30 Thread Jonathan Riddell
> On April 29, 2014, 10:56 p.m., Hrvoje Senjan wrote: > > kuiserver/CMakeLists.txt, line 73 > > > > > > i guess also org.kde.kuiserver.service would need adjusting ... > > Marco Martin wrote: > shouldn't the

Re: Review Request 117876: rename kuiserver to kuiserver5 for coinstallability

2014-04-30 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117876/ --- (Updated April 30, 2014, 9:20 a.m.) Review request for Plasma. Changes

Review Request 117893: Add unit test for kscreenlocker_greet to test all signals

2014-04-30 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117893/ --- Review request for Plasma, David Edmundson and Wolfgang Bauer. Repository

Re: Review Request 117891: Fix x/y property values in DeclarativeDragDropEvent

2014-04-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117891/#review56951 --- This review has been submitted with commit ebeb7d77be7e22fadd

Re: Review Request 117891: Fix x/y property values in DeclarativeDragDropEvent

2014-04-30 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117891/ --- (Updated April 30, 2014, 9:08 a.m.) Status -- This change has been m

Re: Review Request 117775: rename oxygen sound files for co-installability

2014-04-30 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117775/ --- (Updated April 30, 2014, 9:08 a.m.) Review request for Plasma. Reposito

Re: Review Request 117891: Fix x/y property values in DeclarativeDragDropEvent

2014-04-30 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117891/#review56950 --- Ship it! Ship It! - Marco Martin On April 30, 2014, 6:37 a

Re: Review Request 117802: Merge ShowDesktop and ShowDashboard plasma applets into one

2014-04-30 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117802/#review56949 --- The idea makes sense, however it's on Plasma1, that shouldn't

Re: Review Request 117876: rename kuiserver to kuiserver5 for coinstallability

2014-04-30 Thread Marco Martin
> On April 29, 2014, 10:56 p.m., Hrvoje Senjan wrote: > > kuiserver/CMakeLists.txt, line 73 > > > > > > i guess also org.kde.kuiserver.service would need adjusting ... shouldn't the services maintain their name?