Re: Review Request 117779: fix crash when textureNode->texture() is null

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117779/#review56587 --- I'd rather not want to see us hide this crash. There is an und

Re: plasma-framework in kdereview

Hello, On Saturday 26 April 2014 01:57:09 Albert Astals Cid wrote: > El Divendres, 25 d'abril de 2014, a les 12:34:32, Marco Martin va escriure: > > since it was done earlier this week, better announce it formally, so > > everybody can actually do the -review part ;) > > Had a look and i18n wise

Re: plasma-framework in kdereview

I don't think we can tap into the parser too easily, we're not using the ConfigLoaderHandler for actually loading a config; we're just sharing the XML parser. It seems there's a very simple option that works. KConfigSkeleton keeps track of groups already. If we replace the core of Service::setOpe

Re: Review Request 117530: Port & build KSMServer KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117530/#review56583 --- This review has been submitted with commit 37b23c6615ef0e436b

Re: Review Request 117779: fix crash when textureNode->texture() is null

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117779/ --- (Updated April 26, 2014, 12:51 a.m.) Review request for kde-workspace and

Re: Review Request 117779: fix crash when textureNode->texture() is null

> On April 25, 2014, 9:44 p.m., Thomas Lübking wrote: > > src/declarativeimports/core/windowthumbnail.cpp, line 231 > > > > > > try before this call. > > Alexander Richardson wrote: > Okay, just thought I'd

Re: Review Request 117779: fix crash when textureNode->texture() is null

> On April 25, 2014, 11:44 p.m., Thomas Lübking wrote: > > src/declarativeimports/core/windowthumbnail.cpp, line 231 > > > > > > try before this call. Okay, just thought I'd exit early in that case and not bothe

Re: Review Request 117779: fix crash when textureNode->texture() is null

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117779/#review56577 --- src/declarativeimports/core/windowthumbnail.cpp

Review Request 117779: fix crash when textureNode->texture() is null

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117779/ --- Review request for kde-workspace and Plasma. Repository: plasma-framework

Re: plasma-framework in kdereview

On Friday 25 April 2014 20:32:32 you wrote: > > so, on one hand exposing ConfigLoaderHandler in kconfig doesn't seem too > clean, on the other hand, not being able to tap in the parsing in subclasses > may be a limitation as well tough so, how do we proceed? personally i'll sleep on it a few day

Re: plasma-framework in kdereview

On Friday 25 April 2014 22:01:42 you wrote: > > > > Any idea what it might be for? > > ha. > looking in p1, was used for extender items, so it can be removed, both the > method and the member removed it -- Marco Martin ___ Plasma-devel mailing list P

Re: Review Request 117644: screenlocker: don't leave behind screensaver processes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117644/#review56571 --- This review has been submitted with commit b1fa2678d36f6ce215

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117091/#review56568 --- This review has been submitted with commit 185dfbd70b88e60023

Re: Scriptengines and other language bindings: what to do?

On Friday 25 April 2014 21:54:44 Luca Beltrame wrote: > In short, and I say this as a person who did a lot on bindings, I would > suggest to remove script engines from the Plasma repository: I'd much > prefer, if someone ever wanted to hack on them, to have them *outside* the > repo and under a cle

Re: plasma-framework in kdereview

On Friday 25 April 2014 21:44:13 David Edmundson wrote: > In Plasma::Service there's a method called dummyGroup() which will > always return an empty KConfigGroup in an overly complicated way. It > seems to be completely unused. > > Any idea what it might be for? ha. looking in p1, was used for e

Scriptengines and other language bindings: what to do?

Hello Plasma people, I noticed the commit by Aurelien that disabled the Python script engine and that got me thinking, given that I've worked on that and in bindings in the past (although I stress, I am *not* a maintainer). I think that with QML and the components provided by the Plasma libs,

Re: plasma-framework in kdereview

In Plasma::Service there's a method called dummyGroup() which will always return an empty KConfigGroup in an overly complicated way. It seems to be completely unused. Any idea what it might be for? ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: plasma-framework in kdereview

Hi Everyone, Indeed, there was an intention to use some plasma components in Skrooge, but it never materialized in any official release. Today, this is mostly abandoned code, to my disappointment, but I never committed myself enough on finishing this part... As far as Skrooge is concerned, you

Re: plasma-framework in kdereview

On Friday 25 April 2014 20:10:31 Martin Gräßlin wrote: > > argh :/, I wasn't aware at all about that :/ > > I would have ported the users of it removing it from libplasma. > > when was this done? why wasn't notified/things weren't ported to it? > > sorry about that, would be me to blame. I did th

Re: Re: plasma-framework in kdereview

>> argh :/, I wasn't aware at all about that :/ >> I would have ported the users of it removing it from libplasma. >> when was this done? why wasn't notified/things weren't ported to it? > > sorry about that, would be me to blame. I did the integration into KConfig. No > idea how it could happen th

Re: Re: plasma-framework in kdereview

On Friday 25 April 2014 10:39:32 Marco Martin wrote: > On Friday 25 April 2014 19:28:59 David Edmundson wrote: > > > parse kconfigskeletons at runtime for what i'm concerned), that's the > > > call > > > of the application developer, as any workspace. > > > > That KConfigLoader already moved to KC

Review Request 117775: rename oxygen sound files for co-installability

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117775/ --- Review request for Plasma. Repository: oxygen Description --- Oxyg

Re: plasma-framework in kdereview

On Friday 25 April 2014 19:16:43 Kevin Ottens wrote: > I think these statements show you totally ignore the history behind > libplasma or how applications can use it... They (at least Amarok, not 100% > sure for Skrooge) benefit from the component model used in libplasma: > packages, dataengines,

Re: plasma-framework in kdereview

On Friday 25 April 2014 19:28:59 David Edmundson wrote: > > parse kconfigskeletons at runtime for what i'm concerned), that's the call > > of the application developer, as any workspace. > > That KConfigLoader already moved to KConfigGui. > > (and I agree that class is really really useful) argh

Re: plasma-framework in kdereview

On Fri, Apr 25, 2014 at 6:56 PM, Marco Martin wrote: > On Friday 25 April 2014 17:46:23 David Edmundson wrote: >> > Well... it's been planned this way for three years if not more. Before >> > that it was in kdelibs. >> > >> >> Also, right now there is only one user of this framework >> >> (plasma-

Re: Review Request 117455: [kglobalaccel] Remove Component::showKCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117455/ --- (Updated April 25, 2014, 5:24 p.m.) Status -- This change has been m

Re: Review Request 117455: [kglobalaccel] Remove Component::showKCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117455/#review56553 --- This review has been submitted with commit 73316526ed84b25b8b

Re: Review Request 117770: rename liboxygen libraries

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117770/#review56551 --- The correct fix is to install an OxygenConfig.cmake file from

Re: plasma-framework in kdereview

On Friday 25 April 2014 17:46:23 David Edmundson wrote: > > Well... it's been planned this way for three years if not more. Before > > that it was in kdelibs. > > > >> Also, right now there is only one user of this framework > >> (plasma-desktop), > > > > That's because the other users weren't po

Re: plasma-framework in kdereview

On Friday 25 April 2014 17:46:23 David Edmundson wrote: > > Well... it's been planned this way for three years if not more. Before > > that it was in kdelibs. > > > >> Also, right now there is only one user of this framework > >> (plasma-desktop), > > > > That's because the other users weren't po

Re: Review Request 117746: Don't make blocking dbus calls from KDED for appmenu.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117746/#review56546 --- Will test this as soon as possible. - Cedric Bellegarde On

Re: Review Request 117746: Don't make blocking dbus calls from KDED for appmenu.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117746/#review56545 --- Will test this as soon as possible - Cedric Bellegarde On A

Re: Review Request 117746: Don't make blocking dbus calls from KDED for appmenu.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117746/#review56544 --- Will test this as soon as possible - Cedric Bellegarde On A

Re: Review Request 117770: rename liboxygen libraries

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117770/ --- (Updated April 25, 2014, 4:40 p.m.) Review request for Plasma and Martin

Re: Review Request 117770: rename liboxygen libraries

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117770/ --- (Updated April 25, 2014, 4:39 p.m.) Review request for Plasma and Martin

Re: plasma-framework in kdereview

> Well... it's been planned this way for three years if not more. Before that it > was in kdelibs. > >> Also, right now there is only one user of this framework (plasma-desktop), > > That's because the other users weren't ported to KF5 yet. But there's > definitely more plasma users (amarok comes t

Re: Qt Quick Controls style

On Fri, Apr 25, 2014 at 1:06 AM, Martin Klapetek wrote: > I retested it and there's still one tiny issue - > http://i.imgur.com/pIb9QtU.png - see the right side of the window, the > groupboxes and the scrollarea are going out of the frame. It's ok if I > resize the window a bit, so it seems like t

Re: Review Request 117542: Improve battery monitor

> On April 24, 2014, 9:33 a.m., Sebastian Kügler wrote: > > Screenshots? > > > > My main question is: Is this going to fit into the new systemtray? The > > popup is not resizable, so it might push out part of the UI underneath. > > Kai Uwe Broulik wrote: > ... which is really unfortunate.

Re: plasma-framework in kdereview

On Friday 25 April 2014 15:14:46 Àlex Fiestas wrote: > On Friday 25 April 2014 12:34:32 Marco Martin wrote: > > Hi all, > > since it was done earlier this week, better announce it formally, so > > everybody can actually do the -review part ;) > > > > the plasma-framework repository has been moved

Re: Review Request 117773: make kwin-decoration co-installable, remove unused kconfig_update script and rename oxygen-shadow-demo to oxygen-shadow-demo5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117773/ --- (Updated April 25, 2014, 2:40 p.m.) Review request for Plasma, Martin Grä

Re: Review Request 117772: rename oxygen-demo to oxygen-demo5 and oxygen-settings to oxygen-settings5 for co-installability with kde4 kde-runtime

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117772/ --- (Updated April 25, 2014, 2:19 p.m.) Status -- This change has been m

Review Request 117773: make kwin-decoration co-installable, remove unused kconfig_update script and rename oxygen-shadow-demo to oxygen-shadow-demo5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117773/ --- Review request for Plasma and Martin Gräßlin. Repository: oxygen Descri

Re: Review Request 117450: Add Milou to the default panel layout

On Thursday 24 April 2014 11:53:49 Sebastian Kügler wrote: > One has to take history into account here. While cleaning up the Kickoff UI, > I've removed the "branding" button. This small text is a useful replacement > for that: > > - Distros want to have the distro name somewhere in the UI > - Us

Re: Review Request 117772: rename oxygen-demo to oxygen-demo5 and oxygen-settings to oxygen-settings5 for co-installability with kde4 kde-runtime

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117772/#review56532 --- This review has been submitted with commit 310702903897e54d2c

Re: Review Request 117772: rename oxygen-demo to oxygen-demo5 and oxygen-settings to oxygen-settings5 for co-installability with kde4 kde-runtime

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117772/#review56530 --- Ship it! Ship It! - Marco Martin On April 25, 2014, 2:08 p

Review Request 117772: rename oxygen-demo to oxygen-demo5 and oxygen-settings to oxygen-settings5 for co-installability with kde4 kde-runtime

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117772/ --- Review request for Plasma. Repository: oxygen Description --- rena

Review Request 117770: rename liboxygen libraries

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117770/ --- Review request for Plasma and Martin Gräßlin. Repository: oxygen Descri

Re: plasma-framework in kdereview

On Friday 25 April 2014 15:24:50 Luigi Toscano wrote: > On Friday 25 of April 2014 15:14:46 Àlex Fiestas wrote: > > Moving plasma-framework to frameworks means that we will loose flexibility > > since we won't be able to break api/abi. > > > > So, do we really have to move it there? Imho would be

Jenkins build is back to normal : khotkeys_master_qt5 #8

See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: plasma-framework in kdereview

On Friday 25 of April 2014 15:14:46 Àlex Fiestas wrote: > Moving plasma-framework to frameworks means that we will loose flexibility > since we won't be able to break api/abi. > > So, do we really have to move it there? Imho would be prudent to keep it > somewhere else where api/abi stability is n

Re: plasma-framework in kdereview

On Friday 25 April 2014 15:14:46 you wrote: > > * there was the plasma shell: has been removed and moved to > > plasma-workspace, decreasing dependencies > > Moving plasma-framework to frameworks means that we will loose flexibility > since we won't be able to break api/abi. that's exactly why i

Re: plasma-framework in kdereview

On Friday 25 April 2014 12:34:32 Marco Martin wrote: > Hi all, > since it was done earlier this week, better announce it formally, so > everybody can actually do the -review part ;) > > the plasma-framework repository has been moved in kdereview, headed > hopefully in frameworks. > what it contain

Widget and windeco themes for Plasma Next

Dear KDE developers and designers, I have read your debate about window and windeco themes for Plasma Next. I found many of the arguments used against new styles unconvincing and felt like I had to write a reply. There are at least three issues that underly the opposition to broader changes. On

Review Request 117767: do not use minor library version for soversion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117767/ --- Review request for Plasma, Aleix Pol Gonzalez and John Tapsell. Repositor

Jenkins build is back to normal : plasma-desktop_master_qt5 #70

See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117762: Improve XCB dependency handling

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117762/ --- (Updated April 25, 2014, 11:29 a.m.) Status -- This change has been

Re: Review Request 117762: Improve XCB dependency handling

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117762/#review56513 --- This review has been submitted with commit 7909afc68e59c3b892

Build failed in Jenkins: khotkeys_master_qt5 #7

See Changes: [aleixpol] Initial import from the monolithic kde-workspace. [aleixpol] Moved the documentation together with the kcm -- Started by remote host 127.0.0.1 with note: Triggered by commit

Build failed in Jenkins: plasma-desktop_master_qt5 #69

See Changes: [aleixpol] Moved kcontrol/khotkeys documentation to khotkeys repository -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PAC

Re: Which repos?

On Friday, April 25, 2014 10:24:34 Eike Hein wrote: > These dependency listings might also help: > > kde/workspace/plasma-workspace: frameworks/kdoctools > kde/workspace/plasma-workspace: frameworks/krunner > kde/workspace/plasma-workspace: frameworks/kjsembed > kde/workspace/plasma-workspace: fra

Jenkins build is back to normal : kde-runtime_frameworks_qt5 #159

See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Build failed in Jenkins: kde-runtime_frameworks_qt5 #158

See Changes: [aleixpol] solid-networkstatus was moved to kdelibs4support -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINB

Build failed in Jenkins: kde-runtime_frameworks_qt5 #157

See Changes: [aleixpol] kwindowsaddons was moved into its own repository -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINB

Build failed in Jenkins: kde-runtime_frameworks_qt5 #156

See Changes: [aleixpol] Currency data was moved to kunitconversion -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER

plasma-framework in kdereview

Hi all, since it was done earlier this week, better announce it formally, so everybody can actually do the -review part ;) the plasma-framework repository has been moved in kdereview, headed hopefully in frameworks. what it contains: * libplasma: it's the old plasma library that used to be in k

Re: Review Request 117762: Improve XCB dependency handling

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117762/#review56506 --- Ship it! Ship It! - Alex Merry On April 25, 2014, 9:17 a.m

Re: RFC: Additional hint elements for frame theme SVGs

On Friday 25 April 2014 01:40:11 Eike Hein wrote: > When a border row/column gets disabled, this margin disappears, > causing a visually uneven/asymmetrical result. Content appears not > centered, with different margins between content and opposing inside > edges (one of them now a screen edge). Th

Re: Review Request 117584: Standardise DBus service CMake code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117584/ --- (Updated April 25, 2014, 10:06 a.m.) Status -- This change has been

Re: Review Request 117584: Standardise DBus service CMake code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117584/#review56504 --- This review has been submitted with commit ad57ea90d1a44b3e9b

Re: Review Request 117584: Standardise DBus service CMake code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117584/#review56502 --- Ship it! Ship It! - David Faure On April 16, 2014, 10:50 a

Re: Plasmoids: X-KDE-PluginInfo-Website=http://plasma.kde.org/ invalid?

On Fri, Apr 25, 2014 at 10:22 AM, Aleix Pol wrote: > On Fri, Apr 25, 2014 at 9:27 AM, Sebastian Kügler wrote: > >> On Saturday, April 19, 2014 11:29:50 scl wrote: >> > I lately reworked a plasmoid. As desired in >> > the [Plasma/QML Getting started document] >> > the file metadata.desktop contai

Re: Review Request 117762: Improve XCB dependency handling

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117762/ --- (Updated April 25, 2014, 11:17 a.m.) Review request for Plasma. Reposit

Re: Review Request 117762: Improve XCB dependency handling

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117762/#review56483 --- CMakeLists.txt

Re: Plasmoids: X-KDE-PluginInfo-Website=http://plasma.kde.org/ invalid?

On Friday 25 of April 2014 10:22:27 Aleix Pol wrote: > On Fri, Apr 25, 2014 at 9:27 AM, Sebastian Kügler wrote: > > On Saturday, April 19, 2014 11:29:50 scl wrote: > > > I lately reworked a plasmoid. As desired in > > > the [Plasma/QML Getting started document] > > > the file metadata.desktop cont

Re: Which repos?

These dependency listings might also help: kde/workspace/plasma-workspace: frameworks/kdoctools kde/workspace/plasma-workspace: frameworks/krunner kde/workspace/plasma-workspace: frameworks/kjsembed kde/workspace/plasma-workspace: frameworks/knotifyconfig kde/workspace/plasma-workspace: framework

Re: Review Request 117757: Improve Kickoff's scrolling when changing categories

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117757/#review56477 --- Ship it! - David Edmundson On April 24, 2014, 8:14 p.m., Ma

Re: Plasmoids: X-KDE-PluginInfo-Website=http://plasma.kde.org/ invalid?

On Fri, Apr 25, 2014 at 9:27 AM, Sebastian Kügler wrote: > On Saturday, April 19, 2014 11:29:50 scl wrote: > > I lately reworked a plasmoid. As desired in > > the [Plasma/QML Getting started document] > > the file metadata.desktop contains the line > > X-KDE-PluginInfo-Website=http://plasma.kde.o

Re: Which repos?

Runtime isn't split, it's being dissolved into other parts. Things either end up in frameworks or are part of this list above. For example khelpcentre used to be in runtime. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/l

Re: Review Request 117762: Improve XCB dependency handling

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117762/#review56476 --- Ship it! Looks good; I trust you know which components are ac

Re: Which repos?

On Friday 25 April 2014 08:52:53 Sebastian Kügler wrote: > Hey all, > > Since I was absent for a bit, when the split happened, which repositories > did we end up with for what was kde-runtime and kde-workspace? > workspace ├── kde-cli-tools ├── khelpcenter ├── khotkeys ├── kinfocenter ├── kio-ex

Review Request 117762: Improve XCB dependency handling

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117762/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Qt Quick Controls style

On Fri, Apr 25, 2014 at 8:05 AM, Andrew Lake wrote: > > I think I managed to fix most issues that were showing up with > QtQuickControls gallery. > > Thanks much for everyone's patience! > Thanks! I retested it and there's still one tiny issue - http://i.imgur.com/pIb9QtU.png - see the right sid

Re: Review Request 117757: Improve Kickoff's scrolling when changing categories

> On April 25, 2014, 2:02 a.m., David Edmundson wrote: > > applets/kickoff/package/contents/ui/ApplicationsView.qml, line 131 > > > > > > Can't we just save and restore the contentY rather than going via > > ind

Re: Plasmoids: X-KDE-PluginInfo-Website=http://plasma.kde.org/ invalid?

On Saturday, April 19, 2014 11:29:50 scl wrote: > I lately reworked a plasmoid. As desired in > the [Plasma/QML Getting started document] > the file metadata.desktop contains the line > X-KDE-PluginInfo-Website=http://plasma.kde.org/. > > However, when I enter this URL in my browser > I can't acce

Build failed in Jenkins: plasma-desktop_master_qt5 #68

See Changes: [hein] More app name format options. [hein] Implement menu depth limit option; improve model performance. -- Started by user Ben Cooksley Building remotely on LinuxSlave - 4 (PAC

Jenkins build is back to normal : kmenuedit_master_qt5 #5

See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel