Re: Review Request 117393: Make building tests optional

2014-04-17 Thread Michael Palimaka
> On April 17, 2014, 8:22 p.m., Martin Gräßlin wrote: > > Thanks for the patience with me :-) Thanks for taking the time to find an acceptable solution, it's really appreciate. :-) - Michael --- This is an automatically generated e-mai

Re: Review Request 117393: Make building tests optional

2014-04-17 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117393/ --- (Updated April 18, 2014, 6:44 a.m.) Status -- This change has been m

Re: Review Request 117393: Make building tests optional

2014-04-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117393/#review56007 --- This review has been submitted with commit 1bca6c3dfa880d5403

Re: Proposal to hide raw QML errors in Plasma Next

2014-04-17 Thread Bhushan Shah
On Fri, Apr 18, 2014 at 2:38 AM, Giorgos Tsiapaliokas wrote: > If we have 0 debug output how does this makes it easier? > The existing debug output, if you filter it gives some hints about > what is going on, IMO this is very useful. No? This is case, but still you are missing two stuffs.. 1) We

Re: RFC: plasma tooltips animations

2014-04-17 Thread Martin Klapetek
On Thu, Apr 17, 2014 at 6:27 PM, Marco Martin wrote: > On Thursday 17 April 2014, Aleix Pol wrote: > > > to see if is one of those things that is causing problems. > > > > I've been trying it, looks good to me, but I don't really know what to > > test. > > > > I must say it feels faster though, n

Re: Proposal to hide raw QML errors in Plasma Next

2014-04-17 Thread Giorgos Tsiapaliokas
Hello, I also like the more user friendly ui errors. On Thursday 17 of April 2014 17:49:35 Aleix Pol wrote: > +1, I would like to add though that we should probably adopt a 0 qDebug > policy as well. > > It's useful to have them when working on a feature, but having things like: > plasma_shell(2

Re: Review Request 117393: Make building tests optional

2014-04-17 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117393/#review55995 --- Ship it! Thanks for the patience with me :-) - Martin Gräßli

Re: RFC: plasma tooltips animations

2014-04-17 Thread Marco Martin
On Thursday 17 April 2014, Aleix Pol wrote: > I've been trying it, looks good to me, but I don't really know what to > test. > > I must say it feels faster though, not scientifically tested though. ;) Ok, ask to test part 2: now the tooltip in master (based on Dialog) should behave way better. sh

Re: Monday hangout

2014-04-17 Thread Marco Martin
On Thursday 17 April 2014, Aleix Pol wrote: > > Plasma-devel mailing list > > Plasma-devel@kde.org > > https://mail.kde.org/mailman/listinfo/plasma-devel > > Here it's a holiday as well, so moving it sounds good. Tuesday it is, at 12:00 as usual -- Marco Martin _

Re: Review Request 117393: Make building tests optional

2014-04-17 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117393/ --- (Updated April 17, 2014, 5:53 p.m.) Review request for kwin and Plasma.

Review Request 117615: Implementation of Search in Local Browsing in Plasma Media Center

2014-04-17 Thread Harshit Agarwal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117615/ --- Review request for Plasma, Akshay Ratan, Shantanu Tushar, and Sinny Kumari.

Re: Monday hangout

2014-04-17 Thread Aleix Pol
On Thu, Apr 17, 2014 at 7:35 PM, Marco Martin wrote: > Hi all, > > since at the moment I do the note-taker of monday hangouts, I just want to > tell that next monday I won't be available. > > I'm fine either if somebody steps up and moderates the hangout monday, or > moving it to tuesday (or what

Re: Monday hangout

2014-04-17 Thread David Edmundson
It's a bank holiday in most of Europe, lets make it Tuesday. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Monday hangout

2014-04-17 Thread Marco Martin
Hi all, since at the moment I do the note-taker of monday hangouts, I just want to tell that next monday I won't be available. I'm fine either if somebody steps up and moderates the hangout monday, or moving it to tuesday (or whatever) if you prefer Cheers, Marco Martin ___

Re: Continued: milou/kickoff/whatever menu

2014-04-17 Thread Marco Martin
On Thursday 17 April 2014, Vishesh Handa wrote: > How about we take a step back and re-evaluate all of this after this > initial release? We had discussed on the sprint how we would re-evaluate > the default launcher (homerun-kicker vs normal kicker). We can also talk > about how we want to best i

Re: RFC: plasma tooltips animations

2014-04-17 Thread Marco Martin
On Thursday 17 April 2014, Aleix Pol wrote: > > to see if is one of those things that is causing problems. > > I've been trying it, looks good to me, but I don't really know what to > test. > > I must say it feels faster though, not scientifically tested though. ;) to me causes just as many cras

Re: RFC: plasma tooltips animations

2014-04-17 Thread Aleix Pol
On Tue, Apr 15, 2014 at 12:28 PM, Marco Martin wrote: > On Monday 14 April 2014 19:12:50 Martin Gräßlin wrote: > > I think these problems are fixable. First obvious question: do Tooltips > use > > PlasmaCore.Dialog? If yes I suggest that we move them to an own C++ > > implementation - Dialog is a

Re: Proposal to hide raw QML errors in Plasma Next

2014-04-17 Thread Aleix Pol
On Thu, Apr 17, 2014 at 5:35 PM, Marco Martin wrote: > On Thursday 17 April 2014, Mark Gaiser wrote: > > Does this mean that the console output is also going to be "user > friendly"? > > By console output i mean the output you get when you start > > plasma-desktop from a console. > > > > I think

Re: Proposal to hide raw QML errors in Plasma Next

2014-04-17 Thread Marco Martin
On Thursday 17 April 2014, Mark Gaiser wrote: > Does this mean that the console output is also going to be "user friendly"? > By console output i mean the output you get when you start > plasma-desktop from a console. > > I think that output should be as detailed as possible (aka, not user > frien

Re: Proposal to hide raw QML errors in Plasma Next

2014-04-17 Thread Bhushan Shah
On Thu, Apr 17, 2014 at 9:05 PM, Marco Martin wrote: > for console output, there is one and only one solution. go and hunting every > error message, fixing it properly +1 :P -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode __

Re: Proposal to hide raw QML errors in Plasma Next

2014-04-17 Thread Mark Gaiser
On Thu, Apr 17, 2014 at 4:06 PM, Bhushan Shah wrote: > Hello, > > Currently in Plasma (both Next/KDE4) we are showing raw qml error > messages when applet fails to load. > > But to our users what thing is useful is "This applet failed to > load". and to developers "Why?" > > So I am thinking to c

Re: Continued: milou/kickoff/whatever menu

2014-04-17 Thread Shantanu Tushar Jha
On Thu, Apr 17, 2014 at 8:23 PM, Vishesh Handa wrote: > On Thursday, April 17, 2014 11:53:16 AM Marco Martin wrote: > > Hi all, > > I know the discussion was already pretty long :/ but we have to continue > it. > > > > To recap the issue, is to not have too many ways to search stuff, to > give a

Re: Continued: milou/kickoff/whatever menu

2014-04-17 Thread Vishesh Handa
On Thursday, April 17, 2014 11:53:16 AM Marco Martin wrote: > Hi all, > I know the discussion was already pretty long :/ but we have to continue it. > > To recap the issue, is to not have too many ways to search stuff, to give a > good unified design direction and to decrease what's called the "gu

Re: Continued: milou/kickoff/whatever menu

2014-04-17 Thread Ivan Čukić
> > Btw: I've talked to Vishesh about this at the KTp sprint. Another > > alternative we think might work is to have Kickoff reserved only to > > launching applications (so a "search" there would only filter on > > applications, nothing more) and an integrated Milou/Krunner in the panel > > again

Re: Proposal to hide raw QML errors in Plasma Next

2014-04-17 Thread Bhushan Shah
On Thu, Apr 17, 2014 at 7:41 PM, Marco Martin wrote: > may be good, just have a couple of text labels, one that just shows "this > applet failed to load" then a "Details..." button that shows the real error > message. if this is done, it should be nothing more complicated, just a few- > liners mod

Re: Proposal to hide raw QML errors in Plasma Next

2014-04-17 Thread Marco Martin
On Thursday 17 April 2014, Bhushan Shah wrote: > Hello, > > Currently in Plasma (both Next/KDE4) we are showing raw qml error > messages when applet fails to load. > > But to our users what thing is useful is "This applet failed to > load". and to developers "Why?" may be good, just have a coup

Proposal to hide raw QML errors in Plasma Next

2014-04-17 Thread Bhushan Shah
Hello, Currently in Plasma (both Next/KDE4) we are showing raw qml error messages when applet fails to load. But to our users what thing is useful is "This applet failed to load". and to developers "Why?" So I am thinking to change AppletError somehow so that it shows simple user friendly error

Re: Continued: milou/kickoff/whatever menu

2014-04-17 Thread Marco Martin
On Thursday 17 April 2014, Thomas Pfeiffer wrote: > > comments? ;) > > How about making Kickoff a little taller by default? There is no hard > rule that launchers can only have a certain height, is there? Vishesh's yeah, making it a bit taller would be fine, it would still be only semi-modal sin

Re: Review Request 117606: Make sure that the panel is not hidden when a plasmoid is expanded

2014-04-17 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117606/ --- (Updated April 17, 2014, 11:45 a.m.) Review request for Plasma. Changes

Re: Review Request 117606: Make sure that the panel is not hidden when a plasmoid is expanded

2014-04-17 Thread Aleix Pol Gonzalez
> On April 17, 2014, 11:30 a.m., Marco Martin wrote: > > If it's for the panel, it shouldn't be done in AppletQuickItem. > > also using AcceptingInputStatus seems a tad arbitrary? I don't think it's arbitrary, having an expanded plasmoid requires input (or interaction), at least to close it. A

Re: Review Request 117606: Make sure that the panel is not hidden when a plasmoid is expanded

2014-04-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117606/#review55951 --- If it's for the panel, it shouldn't be done in AppletQuickItem

Re: Continued: milou/kickoff/whatever menu

2014-04-17 Thread Marco Martin
On Thursday 17 April 2014, Ivan Čukić wrote: > The milou layout is nice, but it IMO does not fit kickoff. > > The vertical categorized view is ok, but I'm not sure the titles should be > that prominent (the text is significantly bigger than that of the results. Probably, but that is something tha

Re: Continued: milou/kickoff/whatever menu

2014-04-17 Thread Ivan Čukić
The milou layout is nice, but it IMO does not fit kickoff. The vertical categorized view is ok, but I'm not sure the titles should be that prominent (the text is significantly bigger than that of the results. Cheerio -- So remember when you're feeling very small and insecure How amazingly unli

Re: Review Request 117606: Make sure that the panel is not hidden when a plasmoid is expanded

2014-04-17 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117606/#review55949 --- Ship it! Ship It! - David Edmundson On April 16, 2014, 11:

Re: Shutting down plasma-shell

2014-04-17 Thread Marco Martin
On Thursday 17 April 2014, Aleix Pol wrote: > > ___ > > Plasma-devel mailing list > > Plasma-devel@kde.org > > https://mail.kde.org/mailman/listinfo/plasma-devel > > I thought about the renaming as well. What would you call it? > "plasma_shell"? "PlasmaS

Re: Shutting down plasma-shell

2014-04-17 Thread Aleix Pol
On Thu, Apr 17, 2014 at 10:05 AM, Marco Martin wrote: > On Thursday 17 April 2014, Aleix Pol wrote: > > Hi, > > A patch was merged today that makes it possible to use kquitapp5 again. > > It's especially interesting to use it to make sure that the settings will > > be saved. > > > > You can close

Re: Continued: milou/kickoff/whatever menu

2014-04-17 Thread Thomas Pfeiffer
On 17.04.2014 11:53, Marco Martin wrote: Hi all, I know the discussion was already pretty long :/ but we have to continue it. To recap the issue, is to not have too many ways to search stuff, to give a good unified design direction and to decrease what's called the "gulf of execution" i.e. decid

Continued: milou/kickoff/whatever menu

2014-04-17 Thread Marco Martin
Hi all, I know the discussion was already pretty long :/ but we have to continue it. To recap the issue, is to not have too many ways to search stuff, to give a good unified design direction and to decrease what's called the "gulf of execution" i.e. deciding what's the type of thing i have to se

Re: Shutting down plasma-shell

2014-04-17 Thread Marco Martin
On Thursday 17 April 2014, Aleix Pol wrote: > Hi, > A patch was merged today that makes it possible to use kquitapp5 again. > It's especially interesting to use it to make sure that the settings will > be saved. > > You can close plasma shell now by calling: > kquitapp5 plasma_shell > > Note the