---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117452/
---
(Updated April 11, 2014, 5:43 a.m.)
Status
--
This change has been m
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117452/#review55429
---
This review has been submitted with commit
d888a16fb0f59ad665
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117464/
---
(Updated April 11, 2014, 5:42 a.m.)
Status
--
This change has been m
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117464/#review55428
---
This review has been submitted with commit
59a6e7b3fd64b7821c
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117494/
---
Review request for Plasma.
Bugs: 198661
https://bugs.kde.org/show_bug
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117481/#review55394
---
Ship it!
Ship It!
- Vishesh Handa
On April 10, 2014, 2:23
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117481/
---
Review request for Plasma.
Repository: plasma-workspace
Description
---
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117372/
---
(Updated April 10, 2014, 1:32 p.m.)
Status
--
This change has been m
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117372/#review55378
---
This review has been submitted with commit
a4622afb0d28b7d561
> On April 9, 2014, 11:27 a.m., Marco Martin wrote:
> > I like the idea, only two things:
> > * I am not sure about the default, would rather have it empty so everybody
> > that doesn't set it goes in a "misc" section
> > * if this goes in, i would like to see sprinter's querymatch have the same
> On April 9, 2014, 11:27 a.m., Marco Martin wrote:
> > I like the idea, only two things:
> > * I am not sure about the default, would rather have it empty so everybody
> > that doesn't set it goes in a "misc" section
> > * if this goes in, i would like to see sprinter's querymatch have the same
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117449/
---
(Updated April 10, 2014, 11:15 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117449/#review55357
---
This review has been submitted with commit
6eeacb05f94ab11cc7
> On April 9, 2014, 11:27 a.m., Marco Martin wrote:
> > I like the idea, only two things:
> > * I am not sure about the default, would rather have it empty so everybody
> > that doesn't set it goes in a "misc" section
> > * if this goes in, i would like to see sprinter's querymatch have the same
> On April 9, 2014, 11:27 a.m., Marco Martin wrote:
> > I like the idea, only two things:
> > * I am not sure about the default, would rather have it empty so everybody
> > that doesn't set it goes in a "misc" section
> > * if this goes in, i would like to see sprinter's querymatch have the same
> On April 9, 2014, 1:27 p.m., Marco Martin wrote:
> > I like the idea, only two things:
> > * I am not sure about the default, would rather have it empty so everybody
> > that doesn't set it goes in a "misc" section
> > * if this goes in, i would like to see sprinter's querymatch have the same,
> On April 9, 2014, 11:27 a.m., Marco Martin wrote:
> > I like the idea, only two things:
> > * I am not sure about the default, would rather have it empty so everybody
> > that doesn't set it goes in a "misc" section
> > * if this goes in, i would like to see sprinter's querymatch have the same
> On April 9, 2014, 11:27 a.m., Marco Martin wrote:
> > I like the idea, only two things:
> > * I am not sure about the default, would rather have it empty so everybody
> > that doesn't set it goes in a "misc" section
> > * if this goes in, i would like to see sprinter's querymatch have the same
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117449/#review55348
---
Ship it!
Ship It!
- Marco Martin
On April 10, 2014, 9:44 a
> On April 10, 2014, 9:47 a.m., Martin Klapetek wrote:
> > > This means the notification right now has nothing more than debug purpose.
> >
> > Wasn't there some accessibility reason for that notification? Because you
> > can also have audio notification and others (custom plugins to
> > KNoti
> On April 10, 2014, 11:47 a.m., Martin Klapetek wrote:
> > > This means the notification right now has nothing more than debug purpose.
> >
> > Wasn't there some accessibility reason for that notification? Because you
> > can also have audio notification and others (custom plugins to
> > KNot
> On April 9, 2014, 11:27 a.m., Marco Martin wrote:
> > I like the idea, only two things:
> > * I am not sure about the default, would rather have it empty so everybody
> > that doesn't set it goes in a "misc" section
> > * if this goes in, i would like to see sprinter's querymatch have the same
> On April 10, 2014, 9:16 a.m., Marco Martin wrote:
> > so, right now we already have two search uis added by default in the
> > default setup: kickoff and krunner.
> > adding a 3rd one by default, just no.
> >
> > what should be done is having the milou search ui into the kickoff search
> > (
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117372/#review55339
---
Ship it!
Ship It!
- Àlex Fiestas
On April 4, 2014, 11:56 a
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117464/#review55338
---
> This means the notification right now has nothing more than
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117449/
---
(Updated April 10, 2014, 9:44 a.m.)
Review request for Plasma and Marco M
> On April 10, 2014, 11:16 a.m., Marco Martin wrote:
> > so, right now we already have two search uis added by default in the
> > default setup: kickoff and krunner.
> > adding a 3rd one by default, just no.
> >
> > what should be done is having the milou search ui into the kickoff search
> >
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117450/#review55333
---
so, right now we already have two search uis added by default
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117450/#review55334
---
so, right now we already have two search uis added by default
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117449/#review55331
---
diff missing :)
- Marco Martin
On April 9, 2014, 3:18 p.m.,
> On April 9, 2014, 11:27 a.m., Marco Martin wrote:
> > I like the idea, only two things:
> > * I am not sure about the default, would rather have it empty so everybody
> > that doesn't set it goes in a "misc" section
> > * if this goes in, i would like to see sprinter's querymatch have the same
> On April 9, 2014, 7:20 p.m., Martin Gräßlin wrote:
> > Oh I just found a usage in kglobaccel itself:
> >
> > KNotification *notification = new KNotification(
> > "newshortcutregistered",
> > KNotification::CloseOnTimeout,
> > q->parent())
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117464/#review55327
---
Ship it!
Ship It!
- Aurélien Gâteau
On April 10, 2014, 8:2
> On April 10, 2014, 9:17 a.m., Aurélien Gâteau wrote:
> > Looks good, but patch does not apply here. It fails with:
> >
> > error: kglobalaccel/CMakeLists.txt: does not exist in index
> > error: kglobalaccel/globalshortcutsregistry.cpp: does not exist in index
> > error: kglobalaccel/kglobalacc
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117464/#review55325
---
Looks good, but patch does not apply here. It fails with:
err
35 matches
Mail list logo
