Re: Review Request 116907: Implemented "Player" MPRIS spec adaptor

2014-03-19 Thread Ashish Madeti
> On March 20, 2014, 11 a.m., Sujith Haridasan wrote: > > Ashish can you explain why do we need session bus for every single adaptor? > > Just wanted to know what advantage would that make? We need to register each adaptor on session bus separately (i.e in their respective constructors) becaus

Re: Review Request 116907: Implemented "Player" MPRIS spec adaptor

2014-03-19 Thread Sujith Haridasan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/#review53474 --- Ashish can you explain why do we need session bus for every si

Re: Polishing sprint in May: dates?

2014-03-19 Thread Bhushan Shah
Hello, On Wed, Mar 19, 2014 at 4:48 PM, Sebastian Kügler wrote: > I am proposing dates here, though this is meant as a "soft proposal", May is a > busy month, and we can't realistically get everyone into the same place. But > even just with a few of us, it will be worth it. We will meet in the Bl

Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed

2014-03-19 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/#review53472 --- Ship it! Ship It! - Shantanu Tushar On March 19, 2014, 6:4

Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed

2014-03-19 Thread Harshit Agarwal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/ --- (Updated March 19, 2014, 6:40 p.m.) Review request for Plasma, Akshay Rat

Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed

2014-03-19 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/#review53438 --- shells/newshell/mainwindow.cpp

Re: QML Bindings for KDE frameworks, take 2

2014-03-19 Thread Marco Martin
On Tuesday 18 March 2014, Kevin Ottens wrote: > > * QtExtracomponents: qt only except kiconthemes (i would go into making > > it less pretty and remove the kiconthemes dependency) > > Yes, please make it independent of KIconThemes, and then could be renamed > into KQuickControlsAddons? so, in th

Re: Review Request 116874: Patch for the next and previous button functionality in an inactive playlist.

2014-03-19 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116874/#review53435 --- With current patch, suppose you play anything from media brows

Review Request 116907: Implemented "Player" MPRIS spec adaptor

2014-03-19 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/ --- Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Harida

Re: Review Request 116898: Get rid of unnecessary Q_INVOKABLE declarations

2014-03-19 Thread Sujith Haridasan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116898/#review53430 --- Ship it! Looks good to me :) - Sujith Haridasan On March 1

Re: Dialog: reimplemented too much

2014-03-19 Thread Marco Martin
On Wednesday 19 March 2014, Aleix Pol wrote: > > ___ > > Plasma-devel mailing list > > Plasma-devel@kde.org > > https://mail.kde.org/mailman/listinfo/plasma-devel > > Why do we need KRunner (or the milou shell) and the OSD written in C++? > > Aleix * b

Re: Review Request 116796: Show brightness OSD only on user input

2014-03-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116796/#review53425 --- This review has been submitted with commit aa8f0f51201d188d20

Re: Review Request 116796: Show brightness OSD only on user input

2014-03-19 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116796/ --- (Updated March 19, 2014, 3:20 p.m.) Status -- This change has been m

Re: Dialog: reimplemented too much

2014-03-19 Thread Martin Klapetek
On Wed, Mar 19, 2014 at 4:09 PM, Aleix Pol wrote: > > Why do we need KRunner (or the milou shell) and the OSD written in C++? > The OSD currently is QML only; however the VDG came up with designs that require doing some window flags/hints magic which are not available from QML + the Dialog is no

Re: Review Request 116796: Show brightness OSD only on user input

2014-03-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116796/#review53423 --- This review has been submitted with commit 067c2a3f7268c7c250

Re: Dialog: reimplemented too much

2014-03-19 Thread Aleix Pol
On Wed, Mar 19, 2014 at 4:15 PM, Marco Martin wrote: > On Wednesday 19 March 2014, Aleix Pol wrote: > > > ___ > > > Plasma-devel mailing list > > > Plasma-devel@kde.org > > > https://mail.kde.org/mailman/listinfo/plasma-devel > > > > Why do we need KRun

Re: Dialog: reimplemented too much

2014-03-19 Thread Aleix Pol
On Tue, Mar 18, 2014 at 8:18 PM, Marco Martin wrote: > Hi all, > > thinking about what i was needing to reimplement the KRunner shell, I've > came > across a problem that looks too much the problem of the OSD. > We too often need something that is almost identical to Dialog > but-not-really > (be

Review Request 116898: Get rid of unnecessary Q_INVOKABLE declarations

2014-03-19 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116898/ --- Review request for Plasma and Sujith Haridasan. Repository: plasma-mediac

Polishing sprint in May: dates?

2014-03-19 Thread Sebastian Kügler
Hey, A bunch of us want to get together in May to put finishing touches in Plasma Next. This sprint is important because it allows us to sit down and fix remaining bugs. I am proposing dates here, though this is meant as a "soft proposal", May is a busy month, and we can't realistically get ev

Re: "Plasma Next + Apps" view on build.kde.org

2014-03-19 Thread Aurélien Gâteau
On Wed, Mar 19, 2014, at 3:21, Martin Gräßlin wrote: > On Wednesday 19 March 2014 03:07:27 Aurélien Gâteau wrote: > > Just a quick note to let you know I created a new view on build.kde.org > > which groups the jobs from Plasma Next and the available KF5 > > applications. You can find it here: > >

Re: "Plasma Next + Apps" view on build.kde.org

2014-03-19 Thread Martin Gräßlin
On Wednesday 19 March 2014 03:07:27 Aurélien Gâteau wrote: > Just a quick note to let you know I created a new view on build.kde.org > which groups the jobs from Plasma Next and the available KF5 > applications. You can find it here: > > http://build.kde.org/view/Plasma%20Next%20+%20Apps/ > > I h

Re: "Plasma Next + Apps" view on build.kde.org

2014-03-19 Thread Marco Martin
On Wednesday 19 March 2014, Aurélien Gâteau wrote: > Just a quick note to let you know I created a new view on build.kde.org > which groups the jobs from Plasma Next and the available KF5 > applications. You can find it here: > > http://build.kde.org/view/Plasma%20Next%20+%20Apps/ > > I hope it h

"Plasma Next + Apps" view on build.kde.org

2014-03-19 Thread Aurélien Gâteau
Just a quick note to let you know I created a new view on build.kde.org which groups the jobs from Plasma Next and the available KF5 applications. You can find it here: http://build.kde.org/view/Plasma%20Next%20+%20Apps/ I hope it helps you tracking the state of our code. Feel free to extend it w

Re: QML Bindings for KDE frameworks, take 2

2014-03-19 Thread Marco Martin
On Tuesday 18 March 2014, Kevin Ottens wrote: > On Tuesday 18 March 2014 19:37:59 Marco Martin wrote: > > what we currently have is: > > * dirmodel: is a binding to kdirmodel -> KIO? (i would probably not > > release it yet but waiting to have folderview done so needed features > > are more clear)

Re: Review Request 116625: Oxygen as default font

2014-03-19 Thread Sebastian Kügler
> On March 19, 2014, 1:16 a.m., Commit Hook wrote: > > This review has been submitted with commit > > c504562c4dc37828790a51ff33a895a962d9b891 by Sebastian Kügler to branch > > master. > > Hrvoje Senjan wrote: > i was under the impression that consensus was to go with (only) r116633. >

Re: Review Request 116625: Oxygen as default font

2014-03-19 Thread Sebastian Kügler
> On March 6, 2014, 2:06 a.m., Hrvoje Senjan wrote: > > startkde.cmake, line 76 > > > > > > Why not just change the defaults in frameworkintegration instead of > > writing directly into users settings? > > Marti

Re: Review Request 116625: Oxygen as default font

2014-03-19 Thread Sebastian Kügler
> On March 19, 2014, 1:16 a.m., Commit Hook wrote: > > This review has been submitted with commit > > c504562c4dc37828790a51ff33a895a962d9b891 by Sebastian Kügler to branch > > master. > > Hrvoje Senjan wrote: > i was under the impression that consensus was to go with (only) r116633. >