Review Request 116891: Fix the CMakeConfig for KSMServer and ScreenSaver DBus xml

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116891/ --- Review request for Plasma and Àlex Fiestas. Repository: kde-workspace D

Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/ --- (Updated March 19, 2014, 6:30 a.m.) Review request for Plasma, Akshay Rat

Plasma media center with Plasma next in this GSoC

Hello! During this GSoC I want to work on this project Integrate Plasma Media center with Plasma Next [1] and I have already submitted my proposal on google melange [2] However yesterday after discussing on IRC I realized this project can be done in other way. Current plan is to port it to Qt5 an

Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/#review53384 --- shells/newshell/mainwindow.cpp

Re: Review Request 116625: Oxygen as default font

> On March 19, 2014, 1:16 a.m., Commit Hook wrote: > > This review has been submitted with commit > > c504562c4dc37828790a51ff33a895a962d9b891 by Sebastian Kügler to branch > > master. i was under the impression that consensus was to go with (only) r116633. at least kdeglobals injection *shoul

Re: Re: Last bits in kde-workspace

On Tue, Mar 18, 2014 at 7:19 PM, David Edmundson wrote: > kgreetplugin is a QWidget based wrapper round kcheckpass and has a > custom protocol to talk to it. > > As Martin G said, needing kchceckpass is a legacy, that isn't needed > anymore. The pam_unix module now distributes it's own SUID binar

Re: Review Request 116625: Oxygen as default font

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/#review53378 --- This review has been submitted with commit c504562c4dc3782879

Re: Review Request 116625: Oxygen as default font

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/ --- (Updated March 19, 2014, 1:16 a.m.) Status -- This change has been m

Re: Review Request 116633: Change default font settings to Oxygen font

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116633/ --- (Updated March 18, 2014, 11:52 p.m.) Status -- This change has been

Re: Review Request 116633: Change default font settings to Oxygen font

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116633/#review53377 --- This review has been submitted with commit 34d3297293437f896a

today's hangout -> tomorrow?

Hey, Marco and me are travelling today. If you want to do the hangout without us, that's fine. Otherwise, let's mee tomorrow at 12:00 CET, as usual. Cheers, -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel ma

Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/ --- (Updated March 18, 2014, 10 p.m.) Review request for Plasma, Akshay Ratan

Re: QML Bindings for KDE frameworks, take 2

On Tuesday 18 March 2014, Kevin Ottens wrote: > > It could be replaced with > QGuiApplication::styleHints()->startDragDistance(). It would then have the > same dependencies than QtExtraComponents (delta KIconThemes) and could be > merged there. Removed qwidgets dependency. The problem i see in

Re: QML Bindings for KDE frameworks, take 2

On Tuesday 18 March 2014 19:37:59 Marco Martin wrote: > what we currently have is: > * dirmodel: is a binding to kdirmodel -> KIO? (i would probably not release > it yet but waiting to have folderview done so needed features are more > clear) Would make sense in a KIO import indeed. > * draganddr

Dialog: reimplemented too much

Hi all, thinking about what i was needing to reimplement the KRunner shell, I've came across a problem that looks too much the problem of the OSD. We too often need something that is almost identical to Dialog but-not-really (because the background is slightly different, because needs some parti

QML Bindings for KDE frameworks, take 2

Hi all, as I mentioned in the last couple of tuesday meetings, in Plasma we have several QML plugins that don't depend from Plasma at all, but are bound just to either Qt or just one framework (should ideally become the way to use the framework from QML) what we currently have is: * dirmodel: i

Re: Review Request 116836: Let search results list expand to full height (since tabbar is hidden then)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116836/ --- (Updated March 18, 2014, 6:26 p.m.) Status -- This change has been m

Re: Review Request 116836: Let search results list expand to full height (since tabbar is hidden then)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116836/#review53353 --- This review has been submitted with commit b494121ff6a4df6cfa

Re: Re: Last bits in kde-workspace

kgreetplugin is a QWidget based wrapper round kcheckpass and has a custom protocol to talk to it. As Martin G said, needing kchceckpass is a legacy, that isn't needed anymore. The pam_unix module now distributes it's own SUID binary for reading the password file which it invokes if it needs to, so

Re: Review Request 116874: Patch for the next and previous button functionality in an inactive playlist.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116874/#review53331 --- shells/newshell/package/contents/ui/mediacenter.qml

Re: Review Request 116874: Patch for the next and previous button functionality in an inactive playlist.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116874/ --- (Updated March 18, 2014, 6 p.m.) Review request for Plasma, Shantanu Tush

Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/#review53344 --- shells/newshell/package/contents/ui/mediacenter.qml

Re: Review Request 116872: [kwin] Adjust CMakeLists.txt to allow standalone built of KWin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116872/ --- (Updated March 18, 2014, 4:46 p.m.) Status -- This change has been m

Re: Review Request 116872: [kwin] Adjust CMakeLists.txt to allow standalone built of KWin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116872/#review53342 --- This review has been submitted with commit f659237853d6ea1619

Re: Review Request 116872: [kwin] Adjust CMakeLists.txt to allow standalone built of KWin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116872/#review53341 --- Ship it! Some more extra cmake-fu is needed to make it work p

Re: Review Request 116869: Completely remove the legacy ksmserver shutdown effect

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116869/#review53340 --- This review has been submitted with commit 80349ea94c1dfb882f

Re: Review Request 116869: Completely remove the legacy ksmserver shutdown effect

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116869/ --- (Updated March 18, 2014, 4:33 p.m.) Status -- This change has been m

Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/ --- (Updated March 18, 2014, 4:13 p.m.) Review request for Plasma, Akshay Rat

Re: Review Request 116869: Completely remove the legacy ksmserver shutdown effect

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116869/#review53325 --- Ship it! Looks good. - Àlex Fiestas On March 18, 2014, 7:4

Re: Review Request 116874: Patch for the next and previous button functionality in an inactive playlist.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116874/#review53324 --- shells/newshell/package/contents/ui/mediacenter.qml

Review Request 116874: Patch for the next and previous button functionality in an inactive playlist.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116874/ --- Review request for Plasma, Shantanu Tushar and Sinny Kumari. Bugs: 330990

Re: Re: Re: Last bits in kde-workspace

On Tue, Mar 18, 2014 at 2:47 PM, Martin Gräßlin wrote: > On Tuesday 18 March 2014 14:26:06 Aleix Pol wrote: > > On Tue, Mar 18, 2014 at 11:56 AM, Martin Gräßlin > wrote: > > > On Tuesday 18 March 2014 11:31:04 Marco Martin wrote: > > > > On Monday 17 March 2014, Aleix Pol wrote: > > > > > Hi pla

Re: Re: Re: Last bits in kde-workspace

On Tuesday 18 March 2014 14:26:06 Aleix Pol wrote: > On Tue, Mar 18, 2014 at 11:56 AM, Martin Gräßlin wrote: > > On Tuesday 18 March 2014 11:31:04 Marco Martin wrote: > > > On Monday 17 March 2014, Aleix Pol wrote: > > > > Hi plasma, > > > > Do you know if kde-workspace/libs/kdm and kcheckpass can

Re: Review Request 116872: [kwin] Adjust CMakeLists.txt to allow standalone built of KWin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116872/#review53322 --- kwin/CMakeLists.txt

Review Request 116872: [kwin] Adjust CMakeLists.txt to allow standalone built of KWin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116872/ --- Review request for kwin, Plasma, Àlex Fiestas, and Aleix Pol Gonzalez. Re

Re: Re: Last bits in kde-workspace

On Tue, Mar 18, 2014 at 11:56 AM, Martin Gräßlin wrote: > On Tuesday 18 March 2014 11:31:04 Marco Martin wrote: > > On Monday 17 March 2014, Aleix Pol wrote: > > > Hi plasma, > > > Do you know if kde-workspace/libs/kdm and kcheckpass can actually be > > > dropped? > > > It's being used by the scr

Re: Review Request 115431: Fix the numbers cut off problem in digital clock applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115431/ --- (Updated March 18, 2014, 12:56 p.m.) Review request for Plasma. Bugs: 2

Re: Review Request 116796: Show brightness OSD only on user input

> On March 17, 2014, 11:19 p.m., Àlex Fiestas wrote: > > I can't test it but it looks good. > > > > I wonder, can this be put in powerdevil from 4.13? > > Sebastian Kügler wrote: > The DBus interface of plasma-shell is new, so if it's in powerdevil, it > will only work if plasma-shell is r

Re: Last bits in kde-workspace

On Tue, 18 Mar 2014 11:31:04 +0100, Marco Martin wrote: On Monday 17 March 2014, Aleix Pol wrote: Hi plasma, Do you know if kde-workspace/libs/kdm and kcheckpass can actually be dropped? It's being used by the screen locker at the moment and I'm feeling unsure. uhm, wasn't libs/kdm already

Re: Re: Last bits in kde-workspace

On Tuesday 18 March 2014 11:31:04 Marco Martin wrote: > On Monday 17 March 2014, Aleix Pol wrote: > > Hi plasma, > > Do you know if kde-workspace/libs/kdm and kcheckpass can actually be > > dropped? > > It's being used by the screen locker at the moment and I'm feeling unsure. > > uhm, wasn't libs

Re: Last bits in kde-workspace

On Monday 17 March 2014, Aleix Pol wrote: > Hi plasma, > Do you know if kde-workspace/libs/kdm and kcheckpass can actually be > dropped? > It's being used by the screen locker at the moment and I'm feeling unsure. uhm, wasn't libs/kdm already dropped? anyways, any idea how to do the password check

Re: Plasma Next - Translations KCM - What Languages?

>>> [: John Layt :] >>> Or do we list all languages regardless of whether they are installed or >>> not (probably way too many)? >> >> [: Chusslove Illich :] >> I would rather go this way, have this finished once and for all. I would >> only try to clearly present it not as "you will get this langu

Re: Plasma Next - Translations KCM - What Languages?

> [: Harald Sitter :] > What we need is some plugin awesomeness (or equally fancy mechanism) to > allow the distribution to put everything into context. The KCM wants to > know what translations are available -> try asking a plugin. The KCM wants > to set a new language order -> tell a plugin to ma

Re: Plasma Next - Translations KCM - What Languages?

> [: John Layt :] > Or do we list all languages regardless of whether they are installed or > not (probably way too many)? I would rather go this way, have this finished once and for all. I would only try to clearly present it not as "you will get this language when you choose it" but as "this is

Re: Review Request 116796: Show brightness OSD only on user input

> On March 17, 2014, 10:19 p.m., Àlex Fiestas wrote: > > I can't test it but it looks good. > > > > I wonder, can this be put in powerdevil from 4.13? The DBus interface of plasma-shell is new, so if it's in powerdevil, it will only work if plasma-shell is running, not plasma-desktop. If that'

Re: Review Request 116836: Let search results list expand to full height (since tabbar is hidden then)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116836/#review53306 --- Ship it! Good to go in. Thanks for taking care of it. You ca

Review Request 116869: Completely remove the legacy ksmserver shutdown effect

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116869/ --- Review request for kwin, Plasma, Àlex Fiestas, and Teo Mrnjavac. Reposito