Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed

2014-03-15 Thread Harshit Agarwal
> On March 15, 2014, 7:44 p.m., Shantanu Tushar wrote: > > browsingbackends/localfiles/localfilesabstractbackend.cpp, line 169 > > > > > > 0 won't work when there are already some itmes in the playlist before >

Re: Review Request 116824: Implementation of Single time addition on multiple clicks of the Play All button

2014-03-15 Thread Harshit Agarwal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116824/ --- (Updated March 16, 2014, 6:09 a.m.) Status -- This change has been d

Re: Review Request 116824: Implementation of Single time addition on multiple clicks of the Play All button

2014-03-15 Thread Shantanu Tushar
> On March 15, 2014, 7:43 p.m., Shantanu Tushar wrote: > > In general I don't see why N clicks of a button won't repeat the action N > > times, sounds very logical to me. So not sure if it needs "fixing". > > Harshit Agarwal wrote: > Agreed, but PlayAll should be a single click feature righ

Re: Review Request 116802: Fix for "Bug 331919 - MediaPlayer is not in front when a media is played from 'Open With'"

2014-03-15 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116802/ --- (Updated March 15, 2014, 8:22 p.m.) Status -- This change has been m

Re: Review Request 116802: Fix for "Bug 331919 - MediaPlayer is not in front when a media is played from 'Open With'"

2014-03-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116802/#review53014 --- This review has been submitted with commit 6b6d71a7e7e2c3282a

Re: Review Request 116824: Implementation of Single time addition on multiple clicks of the Play All button

2014-03-15 Thread Harshit Agarwal
> On March 15, 2014, 7:43 p.m., Shantanu Tushar wrote: > > In general I don't see why N clicks of a button won't repeat the action N > > times, sounds very logical to me. So not sure if it needs "fixing". Agreed, but PlayAll should be a single click feature right? Either we deactivate the butto

Re: Review Request 116800: introduce the command line argument --appletPath in plasmoidviewer

2014-03-15 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116800/#review53005 --- Ship it! There's a whole bunch of unrelated changes in here,

Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed

2014-03-15 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/#review53000 --- browsingbackends/localfiles/localfilesabstractbackend.cpp

Re: Review Request 116824: Implementation of Single time addition on multiple clicks of the Play All button

2014-03-15 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116824/#review52999 --- In general I don't see why N clicks of a button won't repeat t

Re: Review Request 116802: Fix for "Bug 331919 - MediaPlayer is not in front when a media is played from 'Open With'"

2014-03-15 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116802/#review52998 --- Ship it! Ship It! - Shantanu Tushar On March 15, 2014, 4:1

Review Request 116824: Implementation of Single time addition on multiple clicks of the Play All button

2014-03-15 Thread Harshit Agarwal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116824/ --- Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and

Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed

2014-03-15 Thread Harshit Agarwal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/ --- (Updated March 15, 2014, 6:21 p.m.) Review request for Plasma, Akshay Rat

Re: Plasma-next-nm

2014-03-15 Thread Jan Grulich
On Saturday 15 of March 2014 13:33 Daniel Nicoletti wrote: > 2014-03-14 7:21 GMT-03:00 Jan Grulich : > > For libnm-qt we decided to port master branch to Qt5 and make it work with > > the current stable version of > > NM and also with the current development version (future NM 0.9.10). In > > lib

Re: Plasma-next-nm

2014-03-15 Thread Daniel Nicoletti
2014-03-14 7:21 GMT-03:00 Jan Grulich : > For libnm-qt we decided to port master branch to Qt5 and make it work with > the current stable version of > NM and also with the current development version (future NM 0.9.10). In > libmm-qt it is also ported to Qt5 in > master, but we set minimum requir

Re: Review Request 116802: Fix for "Bug 331919 - MediaPlayer is not in front when a media is played from 'Open With'"

2014-03-15 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116802/ --- (Updated March 15, 2014, 9:45 p.m.) Review request for Plasma, Shantanu T

Re: Review Request 116802: Fix for "Bug 331919 - MediaPlayer is not in front when a media is played from 'Open With'"

2014-03-15 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116802/#review52985 --- shells/newshell/package/contents/ui/mediacenter.qml

Re: Review Request 116802: Fix for "Bug 331919 - MediaPlayer is not in front when a media is played from 'Open With'"

2014-03-15 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116802/ --- (Updated March 15, 2014, 9:20 p.m.) Review request for Plasma, Shantanu T

Re: Plasma-next-nm

2014-03-15 Thread Sebastian Kügler
Hi Jan, On Friday, March 14, 2014 11:21:17 Jan Grulich wrote: > I would like to inform you about the current situation with plasma-nm and > libraries for Plasma Next. > > We just started working on a proper Qt5/KF5 port of plasm-nm together with > libnm-qt/libmm-qt libraries. For libnm-qt we deci

Re: Review Request 116802: Fix for "Bug 331919 - MediaPlayer is not in front when a media is played from 'Open With'"

2014-03-15 Thread Sinny Kumari
> On March 15, 2014, 2:38 p.m., Sinny Kumari wrote: > > shells/newshell/package/contents/ui/mediacenter.qml, line 366 > > > > > > Instead of pushing playlist and popping it back, its better to not push > > it. J

Re: Review Request 116802: Fix for "Bug 331919 - MediaPlayer is not in front when a media is played from 'Open With'"

2014-03-15 Thread Shantanu Tushar
> On March 15, 2014, 2:38 p.m., Sinny Kumari wrote: > > shells/newshell/package/contents/ui/mediacenter.qml, line 366 > > > > > > Instead of pushing playlist and popping it back, its better to not push > > it. J

Re: Review Request 116802: Fix for "Bug 331919 - MediaPlayer is not in front when a media is played from 'Open With'"

2014-03-15 Thread Ashish Madeti
> On March 15, 2014, 8:08 p.m., Sinny Kumari wrote: > > shells/newshell/package/contents/ui/mediacenter.qml, line 366 > > > > > > Instead of pushing playlist and popping it back, its better to not push > > it. J

Re: Plasma Next - Translations KCM - What Languages?

2014-03-15 Thread Albert Astals Cid
El Divendres, 14 de març de 2014, a les 22:34:27, Chusslove Illich va escriure: > > [: John Layt :] > > Or do we list all languages regardless of whether they are installed or > > not (probably way too many)? > > I would rather go this way, have this finished once and for all. I would > only try

Re: Review Request 116802: Fix for "Bug 331919 - MediaPlayer is not in front when a media is played from 'Open With'"

2014-03-15 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116802/#review52976 --- shells/newshell/package/contents/ui/mediacenter.qml

Re: Review Request 116744: Play All Button in Plasma Media Center

2014-03-15 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116744/#review52969 --- I think you can use a simpler logic described below, browsin

Re: Review Request 116804: Bug Fix for the Footer time

2014-03-15 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116804/#review52962 --- Please discard this review request - Bhushan Shah On March

Re: Review Request 116804: Bug Fix for the Footer time

2014-03-15 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116804/#review52961 --- This bug is resolved by commit http://commits.kde.org/plasma-