Re: Review Request 115859: Force-allow background contrast while sliding desktops

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115859/#review50191 --- kwin/effects/slide/slide.h

Re: Review Request 115859: Force-allow background contrast while sliding desktops

> On Feb. 18, 2014, 3:57 p.m., Thomas Lübking wrote: > > kwin/effects/slidingpopups/slidingpopups.cpp, line 51 > > > > > > unrelated? > > Sebastian Kügler wrote: > Kind of to the core issue, yes, but had been

Re: Review Request 115859: Force-allow background contrast while sliding desktops

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115859/ --- (Updated Feb. 19, 2014, 12:37 a.m.) Review request for kwin and Plasma.

Re: Review Request 115859: Force-allow background contrast while sliding desktops

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115859/ --- (Updated Feb. 19, 2014, 12:33 a.m.) Review request for kwin and Plasma.

Re: Review Request 115859: Force-allow background contrast while sliding desktops

> On Feb. 18, 2014, 2:15 p.m., Thomas Lübking wrote: > > kwin/effects/slide/slide.cpp, line 72 > > > > > > what about setting and removing this with setting the "slide" flag and > > catch windowAdded() while slid

Review Request 115871: Use QStandardPaths for finding plasma shells instead of hardcoding to install prefix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115871/ --- Review request for Plasma, Ivan Čukić and Sebastian Kügler. Bugs: 331063

Re: plasma workspace integration for akonadi

On Monday, 2014-02-10, 13:47:45, Sebastian Kügler wrote: > On Friday, February 07, 2014 19:25:55 Kevin Krammer wrote: > > On Friday, 2014-02-07, 18:26:20, Marco Martin wrote: > > > * *if* a Qt5 kdepimlibs was available, would this way be > > > preferrable anyways? > > > > My understanding is that

Re: Review Request 115859: Force-allow background contrast while sliding desktops

> On Feb. 18, 2014, 3:57 p.m., Thomas Lübking wrote: > > kwin/effects/slidingpopups/slidingpopups.cpp, line 51 > > > > > > unrelated? Kind of to the core issue, yes, but had been in the description from the begi

Re: Review Request 115859: Force-allow background contrast while sliding desktops

> On Feb. 18, 2014, 2:15 p.m., Thomas Lübking wrote: > > kwin/effects/slide/slide.cpp, line 72 > > > > > > what about setting and removing this with setting the "slide" flag and > > catch windowAdded() while slid

Re: Review Request 115859: Force-allow background contrast while sliding desktops

> On Feb. 18, 2014, 2:15 p.m., Thomas Lübking wrote: > > kwin/effects/slide/slide.cpp, line 72 > > > > > > what about setting and removing this with setting the "slide" flag and > > catch windowAdded() while slid

Re: Review Request 115859: Force-allow background contrast while sliding desktops

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115859/ --- (Updated Feb. 18, 2014, 3:58 p.m.) Review request for kwin and Plasma.

Re: Review Request 115859: Force-allow background contrast while sliding desktops

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115859/#review50159 --- kwin/effects/slide/slide.h

Re: Proposed fix for issue 330115

Okay ! Finally fixed ! All I had to do was run sudo make install ! and then when I changed the clock to 12:22 pm it finally showed 12:22 pm and NOT 0:22 AM. I'll proceed to submit the patch for review now . Thanks. Warm Regards. R.Harish Navnit The Enigma O

Re: Review Request 115859: Force-allow background contrast while sliding desktops

> On Feb. 18, 2014, 3:06 p.m., Martin Gräßlin wrote: > > kwin/effects/slide/slide.h, line 43 > > > > > > please add override and you can remove the virtual in that case > > Sebastian Kügler wrote: > This shou

Re: Proposed fix for issue 330115

On Tue, Feb 18, 2014 at 9:02 PM, R.Harish Navnit wrote: > Also, make sure you do a "make install" before running the app so that you >> are actually running the new code. >> > I wasn't doing this earlier on , now I tried it and I ended up getting an > error ! Here's the output log : http://paste.k

Re: Review Request 115859: Force-allow background contrast while sliding desktops

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115859/ --- (Updated Feb. 18, 2014, 3:46 p.m.) Review request for kwin and Plasma.

Re: Review Request 115859: Force-allow background contrast while sliding desktops

> On Feb. 18, 2014, 2:15 p.m., Thomas Lübking wrote: > > kwin/effects/slide/slide.cpp, line 72 > > > > > > what about setting and removing this with setting the "slide" flag and > > catch windowAdded() while slid

Re: Review Request 115859: Force-allow background contrast while sliding desktops

> On Feb. 18, 2014, 2:06 p.m., Martin Gräßlin wrote: > > kwin/effects/slide/slide.h, line 43 > > > > > > please add override and you can remove the virtual in that case This should be done for all the virtual met

Re: Proposed fix for issue 330115

On Tue, Feb 18, 2014 at 8:51 PM, Shantanu Tushar Jha wrote: > No idea. How do you know it doesn't work for you? Did you try setting your > clock to 12:45 PM and then start PMC? > Yes , I changed my clock to time between 12noon and 1pm and it still displays as AM. > Also, make sure you do a "make

Re: Proposed fix for issue 330115

No idea. How do you know it doesn't work for you? Did you try setting your clock to 12:45 PM and then start PMC? Also, make sure you do a "make install" before running the app so that you are actually running the new code. Its not a good idea to submit a patch for review if it doesn't work with yo

Re: Proposed fix for issue 330115

On Tue, Feb 18, 2014 at 7:46 PM, Shantanu Tushar Jha wrote: > Your patch works fine for me, I see 00:45 AM without the patch and 12:45 > PM with the patch. > That is great news ! I'll submit the patch for review then . But any guess why it doesn't work for me ? Regards. R.Harish Navnit The Enigma

Re: Proposed fix for issue 330115

Your patch works fine for me, I see 00:45 AM without the patch and 12:45 PM with the patch. On Tue, Feb 18, 2014 at 6:55 PM, R.Harish Navnit wrote: > I've made a patch for the issue and it's content can be found here : > http://paste.kde.org/pcx7kgozj > > However , it still doesn't reflect in th

Re: Review Request 115859: Force-allow background contrast while sliding desktops

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115859/#review50146 --- kwin/effects/slide/slide.cpp

Re: Review Request 115859: Force-allow background contrast while sliding desktops

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115859/#review50145 --- kwin/effects/slide/slide.h

Re: Review Request 115859: Force-allow background contrast while sliding desktops

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115859/ --- (Updated Feb. 18, 2014, 1:58 p.m.) Review request for kwin and Plasma.

Re: Proposed fix for issue 330115

I've made a patch for the issue and it's content can be found here : http://paste.kde.org/pcx7kgozj However , it still doesn't reflect in the PMC application . I'm still trying to figure out why ? I feel the required changes have been made. Are there any other files that have to be changed in orde

Re: Review Request 115859: Force-allow background contrast while sliding desktops

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115859/#review50142 --- kwin/effects/slidingpopups/slidingpopups.cpp

Re: Review Request 115859: Force-allow background contrast while sliding desktops

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115859/#review50141 --- kwin/effects/slide/slide.cpp

Re: Review Request 115859: Force-allow background contrast while sliding desktops

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115859/ --- (Updated Feb. 18, 2014, 12:54 p.m.) Review request for kwin and Plasma.

Re: Review Request 115857: Fix flickering of sliding popups while disappearing

> On Feb. 18, 2014, 7:37 a.m., Martin Gräßlin wrote: > > I'm sorry, but you are fixing symptoms and not the problem. Calling the > > repaint is correct, otherwise we might end with artefacts. The problem must > > be that another effect is still holding a reference to the window and thus > > it

Re: Review Request 115865: Adds new components for different sized labels

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115865/#review50139 --- What's wrong with PlasmaExtras.Title and PlasmaExtras.Heading?

Re: Review Request 115857: Fix flickering of sliding popups while disappearing

> On Feb. 18, 2014, 6:37 a.m., Martin Gräßlin wrote: > > I'm sorry, but you are fixing symptoms and not the problem. Calling the > > repaint is correct, otherwise we might end with artefacts. The problem must > > be that another effect is still holding a reference to the window and thus > > it

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115695/#review50136 --- Ping, any comments? - Martin Klapetek On Feb. 13, 2014, 11:

Re: Review Request 115857: Fix flickering of sliding popups while disappearing

> On Feb. 18, 2014, 6:37 a.m., Martin Gräßlin wrote: > > I'm sorry, but you are fixing symptoms and not the problem. Calling the > > repaint is correct, otherwise we might end with artefacts. The problem must > > be that another effect is still holding a reference to the window and thus > > it

Re: Review Request 115865: Adds new components for different sized labels

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115865/ --- (Updated Feb. 18, 2014, 10:26 a.m.) Review request for Plasma. Reposito

Review Request 115865: Adds new components for different sized labels

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115865/ --- Review request for Plasma. Repository: plasma-mediacenter Description -

Re: Review Request 115857: Fix flickering of sliding popups while disappearing

> On Feb. 18, 2014, 6:37 a.m., Martin Gräßlin wrote: > > I'm sorry, but you are fixing symptoms and not the problem. Calling the > > repaint is correct, otherwise we might end with artefacts. The problem must > > be that another effect is still holding a reference to the window and thus > > it

Re: Review Request 115857: Fix flickering of sliding popups while disappearing

> On Feb. 18, 2014, 6:37 a.m., Martin Gräßlin wrote: > > I'm sorry, but you are fixing symptoms and not the problem. Calling the > > repaint is correct, otherwise we might end with artefacts. The problem must > > be that another effect is still holding a reference to the window and thus > > it