Re: Review Request 114741: Add time duration to media item for youtube videos.

2013-12-31 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114741/#review46511 --- Ship it! Thanks for the patch. Works absolutely fine :) - Si

Re: Setup build of kdeplasma-addons on CI system

2013-12-31 Thread Sebastian Kügler
On Monday, December 30, 2013 12:29:51 David Edmundson wrote: > On Mon, Dec 30, 2013 at 8:04 AM, Bhushan Shah wrote: > > Hello! > > > > On Sun, Dec 29, 2013 at 6:49 PM, Sebastian Kügler wrote: > >> So please everybody, tackle bugs, do not port code that isn't really > >> needed > >> for a basic f

Re: Students to work on Plasma

2013-12-31 Thread Sebastian Kügler
On Monday, December 30, 2013 17:45:24 Bhushan Shah wrote: > On Mon, Dec 30, 2013 at 3:37 PM, Marco Martin wrote: > > porting away from kde4support > > http://community.kde.org/Open_Academy#6._Get_rid_of_KDE4Support_dependecie > > s_in_Plasma2 > I am afraid that it is even task! Quick git grep, An

Re: Battery Monitor on Plasma 2

2013-12-31 Thread Sebastian Kügler
On Sunday, December 29, 2013 21:59:48 Marco Martin wrote: > On Sunday 29 December 2013, Sebastian Kügler wrote: > > > formfactor does exist, but there aren't differences between being in > > > apanel or in a systray... > > > hmm, so when in a systray would make sense a "constrained" formfactor or

Re: Review Request 114746: [calculator runner] Replace regexp with explicit character category check

2013-12-31 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114746/#review46478 --- Ship it! Ship It! - David Edmundson On Dec. 31, 2013, 3:06