Re: Review Request 114271: drawFloatFrame for QtQuick menus

2013-12-04 Thread Martin Gräßlin
> On Dec. 3, 2013, 3:39 p.m., David Edmundson wrote: > > > > Yichao Yu wrote: > May I ask if how did you get the rounded corner? > > I have got this[1] kind of white frame for menu with rounded corder and > haven't found a good way to get rid of it (without interfering with other

Re: Review Request 114253: Port favicons dataengine to KF5

2013-12-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114253/#review45147 --- plasma/generic/dataengines/favicons/faviconprovider.h

Re: Review Request 114271: drawFloatFrame for QtQuick menus

2013-12-04 Thread Yichao Yu
> On Dec. 3, 2013, 9:39 a.m., David Edmundson wrote: > > > > Yichao Yu wrote: > May I ask if how did you get the rounded corner? > > I have got this[1] kind of white frame for menu with rounded corder and > haven't found a good way to get rid of it (without interfering with other

Re: Fails to build against Qt 5.3 dev snapshot

2013-12-04 Thread Sebastian Kügler
On Wednesday, December 04, 2013 07:48:41 Alan Alpert wrote: > On Tue, Dec 3, 2013 at 8:33 AM, Alan Alpert <4163654...@gmail.com> wrote: > > On Tue, Dec 3, 2013 at 8:20 AM, Marco Martin wrote: > >> On Monday 02 December 2013, Alan Alpert wrote: > >> > >> So, to summarize on the situation: > >> Can

Re: Fails to build against Qt 5.3 dev snapshot

2013-12-04 Thread Alan Alpert
On Tue, Dec 3, 2013 at 8:33 AM, Alan Alpert <4163654...@gmail.com> wrote: > On Tue, Dec 3, 2013 at 8:20 AM, Marco Martin wrote: >> On Monday 02 December 2013, Alan Alpert wrote: >> >>> Oh, are you guys planning to release something on 5.2? I thought you >>> were still in an early development phase

Re: Review Request 114295: Fix textfield/lineedit hover frame with QtQuickControls

2013-12-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114295/#review45086 --- Ship it! Nice, can you fix TextArea too whilst you're at it?

Re: Review Request 114271: drawFloatFrame for QtQuick menus

2013-12-04 Thread David Edmundson
> On Dec. 3, 2013, 2:26 p.m., David Edmundson wrote: > > kstyles/oxygen/oxygenstyle.cpp, line 2558 > > > > > > in other cases in this file I've done: > > > > if (option->styleObject->inherits("QQuickStyl

Review Request 114295: Fix textfield/lineedit hover frame with QtQuickControls

2013-12-04 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114295/ --- Review request for Plasma and Hugo Pereira Da Costa. Repository: kde-works

Re: Review Request 114291: Fix kde-workspace build

2013-12-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114291/#review45082 --- This review has been submitted with commit a89d9ba08d563c38729

Re: Review Request 114291: Fix kde-workspace build

2013-12-04 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114291/ --- (Updated Dec. 4, 2013, 10:40 a.m.) Status -- This change has been mar

[plasma-shell] [Bug 328419] New: Context menu of task not visible with highlight windows

2013-12-04 Thread Martin Gräßlin
https://bugs.kde.org/show_bug.cgi?id=328419 Bug ID: 328419 Summary: Context menu of task not visible with highlight windows Classification: Unclassified Product: plasma-shell Version: master Platform: unspecified

Re: Review Request 114291: Fix kde-workspace build

2013-12-04 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114291/#review45077 --- Ship it! Ship It! - Martin Gräßlin On Dec. 4, 2013, 8:19 a.