Re: Review Request 113697: Return focus to input widget after pressing alt key in the screen locker.

2013-11-26 Thread Teemu Rytilahti
> On Nov. 7, 2013, 12:19 a.m., Teemu Rytilahti wrote: > > I'm not actually sure whether is okay to force focus after any key is being > > released... > > Christoph Feck wrote: > Bug 319935 is probably the same issue, and also contains a patch at > comment #1 for the "onReleased" function,

Re: Review Request 113697: Return focus to input widget after pressing alt key in the screen locker.

2013-11-26 Thread Teemu Rytilahti
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113697/ --- (Updated Nov. 27, 2013, 12:27 a.m.) Review request for Plasma. Changes -

Setting a Notification's urgency

2013-11-26 Thread Christoph Feck
Hi, according to a comment in a bug report[1], applications can specify an "urgency" property with notifications, with the intention that anything non-critical will automatically be removed after some time idling in the notifications list. Is this API still available with the QML notifications

Re: Review Request 113697: Return focus to input widget after pressing alt key in the screen locker.

2013-11-26 Thread Christoph Feck
> On Nov. 7, 2013, 12:19 a.m., Teemu Rytilahti wrote: > > I'm not actually sure whether is okay to force focus after any key is being > > released... > > Christoph Feck wrote: > Bug 319935 is probably the same issue, and also contains a patch at > comment #1 for the "onReleased" function,

Re: Review Request 114114: Remove KLocale QML bindings usage from kde-workspace

2013-11-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114114/#review44552 --- This review has been submitted with commit 47340c61a68f0c7155a

Re: Review Request 114114: Remove KLocale QML bindings usage from kde-workspace

2013-11-26 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114114/ --- (Updated Nov. 26, 2013, 11:41 p.m.) Status -- This change has been ma

Re: Review Request 114114: Remove KLocale QML bindings usage from kde-workspace

2013-11-26 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114114/#review44551 --- Ship it! Ship It! - Sebastian Kügler On Nov. 25, 2013, 6:30

Re: Review Request 114059: [Pager] Avoid crashes when no windows

2013-11-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114059/#review44550 --- This review has been submitted with commit 201c66ce97bf683d818

Re: Review Request 114059: [Pager] Avoid crashes when no windows

2013-11-26 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114059/ --- (Updated Nov. 26, 2013, 11:38 p.m.) Status -- This change has been ma

Re: Review Request 114114: Remove KLocale QML bindings usage from kde-workspace

2013-11-26 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114114/#review44529 --- Ping - Martin Klapetek On Nov. 25, 2013, 6:30 p.m., Martin K

Re: Review Request 114101: Use StandaloneFormat for month name

2013-11-26 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114101/ --- (Updated Nov. 26, 2013, 7:14 p.m.) Status -- This change has been mar

Re: No co-installability of plasma 1 and 2

2013-11-26 Thread Martin Graesslin
On Tuesday 26 November 2013 12:23:18 Maximiliano Curia wrote: > In article <25673324.XNmJUoyzAe@martin-desktop> you wrote: > > in todays hangout Alex asked whether kwin binary is going to be renamed to > > kwin5 to make it possible to co-install plasma 1 and plasma 2. > > > > My opinion of that is

Re: Review Request 114059: [Pager] Avoid crashes when no windows

2013-11-26 Thread Luís Gabriel Lima
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114059/#review44493 --- Ship it! Ship It! - Luís Gabriel Lima On Nov. 26, 2013, 11:

Re: No co-installability of plasma 1 and 2

2013-11-26 Thread Aaron J. Seigo
On Tuesday, November 26, 2013 12:23:18 Maximiliano Curia wrote: > In article <25673324.XNmJUoyzAe@martin-desktop> you wrote: > > in todays hangout Alex asked whether kwin binary is going to be renamed to > > kwin5 to make it possible to co-install plasma 1 and plasma 2. > > > > My opinion of that

Re: No co-installability of plasma 1 and 2

2013-11-26 Thread Maximiliano Curia
In article <25673324.XNmJUoyzAe@martin-desktop> you wrote: > in todays hangout Alex asked whether kwin binary is going to be renamed to > kwin5 to make it possible to co-install plasma 1 and plasma 2. > My opinion of that is, that we don't need to have things co-installable. > After > all kde-wo

Re: Review Request 114055: Include translatoins sub-directory to CMakeLists.txt , Fedora Packaging fails searching for translations

2013-11-26 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114055/#review44489 --- Ship it! looks good to me. I checked on Fedora 19 and translat

Re: Review Request 114059: [Pager] Avoid crashes when no windows

2013-11-26 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114059/ --- (Updated Nov. 26, 2013, 11:26 a.m.) Review request for Plasma and Luís Gab