Re: Review Request 113193: fix some warnings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113193/#review41616 --- Ship it! Yep. :) - Sebastian Kügler On Oct. 10, 2013, 8:40

Re: Review Request 113193: fix some warnings

> On Oct. 12, 2013, 9:23 p.m., Sebastian Kügler wrote: > > src/declarativeimports/core/dialog.cpp, line 63 > > > > > > We normally use just 0 for this. I will change that before committing. Otherwise good to go i

Re: Review Request 113193: fix some warnings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113193/#review41614 --- Looks good already, some minor comments inline. src/declarati

Re: Review Request 113207: Plasmate: Request for merge, branch plasmoidviewer2 to frameworks-scratch

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113207/#review41613 --- Ship it! Code looks pretty good, there's a bunch of nitpicks,

Re: Review Request 110288: Checks if an optional field was instantiated before accessing it

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110288/ --- (Updated Oct. 12, 2013, 4:07 p.m.) Status -- This change has been mar

Re: Review Request 110288: Checks if an optional field was instantiated before accessing it

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110288/#review41596 --- This review has been submitted with commit 61d18f327ccec546221

Re: Review Request 110288: Checks if an optional field was instantiated before accessing it

> On May 4, 2013, 2:44 p.m., Giorgos Tsiapaliokas wrote: > > The patch is ok, it can go in. > > > > Are you familiar with out git workflow policy? > > > > http://community.kde.org/Plasma/IntegrationBranches/GeneralPolicy > > > > If you have any questions don't hesitate to ask :) > > Albert As