Re: Review Request 113193: fix some warnings

2013-10-10 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113193/ --- (Updated Oct. 10, 2013, 10:40 p.m.) Review request for Plasma. Repositor

Review Request 113193: fix some warnings

2013-10-10 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113193/ --- Review request for Plasma. Repository: plasma-framework Description

Re: Review Request 113179: Make the runners compile again

2013-10-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113179/#review41533 --- This review has been submitted with commit a3c7a9690f432170015

Re: Review Request 113179: Make the runners compile again

2013-10-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113179/ --- (Updated Oct. 10, 2013, 6:29 p.m.) Status -- This change has been mar

Re: plasmoidviewer 2 merge blockers?

2013-10-10 Thread Sebastian Kügler
On Thursday, October 10, 2013 17:29:05 Giorgos Tsiapaliokas wrote: > a or b? :) a. :) The tool is useful and helps with porting other things. Merging doesn't mean letting it linger, but actually having it build and giving it exposure to other developers will more likely improve things, rather t

Re: plasmoidviewer 2 merge blockers?

2013-10-10 Thread Giorgos Tsiapaliokas
Hello, On 10 October 2013 15:48, Sebastian Kügler wrote: > What is holding back the merge from your point of view? > it depends from the containment. Right now `plasmoidviewer -a foo` will use the plasmoidviewer's containment which is missing * more testing and someone to review the code * no w

update your cmake!

2013-10-10 Thread Sebastian Kügler
Hi, In order to build KF5 and Plasma2 code, you have to update your cmake to 2.8.12. Otherwise, you'll get build errors. Cheers, -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.

plasmoidviewer 2 merge blockers?

2013-10-10 Thread Sebastian Kügler
Hey guys, I've had a coarse look at your plasmoidviewer branch in the plasmate repo. I've fixed some smaller issues, and updated the buildsystem. What is holding back the merge from your point of view? Cheers, -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 _

plasma 2 battery monitor, where?

2013-10-10 Thread Sebastian Kügler
Hi Kai Uwe, Some time ago, you blogged about the Plasma 2 port of the battery monitor. Where can I find that? It doesn't seem to be in kde-workspace. Cheersm -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel m

Re: Review Request 113179: Make the runners compile again

2013-10-10 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113179/#review41496 --- Ship it! With the two issues I've pointed out, this patch can