Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

2013-09-11 Thread Martin Gräßlin
> On Aug. 9, 2013, 9:27 p.m., David Faure wrote: > > tier1/kconfig/src/gui/kconfigloader.h, line 99 > > > > > > I wonder if this should really derive from KConfigSkeleton, rather than > > encapsulate it. > >

Re: Review Request 112674: Bugfix: Make the calculator applet calculate correctly

2013-09-11 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112674/#review39848 --- Ship it! Looks good, thanks! Please commit this patch to KDE/4

Re: Review Request 112674: Bugfix: Make the calculator applet calculate correctly

2013-09-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112674/#review39850 --- This review has been submitted with commit 4a25adbac6677db9ca9

Re: Review Request 112674: Bugfix: Make the calculator applet calculate correctly

2013-09-11 Thread Paul Rohrbach
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112674/ --- (Updated Sept. 11, 2013, 5:48 p.m.) Review request for Plasma. Summary (

Re: Review Request 112674: Bugfix: Make the calculator applet calculate correct

2013-09-11 Thread Paul Rohrbach
> On Sept. 11, 2013, 5:28 p.m., Sebastian Kügler wrote: > > applets/calculator/package/contents/ui/calculator.qml, line 41 > > > > > > Why is this change needed (operator initialized to undefined)? This should not

Re: Review Request 112674: Bugfix: Make the calculator applet calculate correctly

2013-09-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112674/ --- (Updated Sept. 11, 2013, 6:13 p.m.) Status -- This change has been ma

Re: Review Request 112674: Bugfix: Make the calculator applet calculate correctly

2013-09-11 Thread Paul Rohrbach
> On Sept. 11, 2013, 5:59 p.m., Sebastian Kügler wrote: > > Looks good, thanks! Please commit this patch to KDE/4.11, master and > > frameworks-scratch branches. Thank you for accepting the patch :). But I can't commit it, because I don't have commit rights. - Paul

Review Request 112674: Bugfix: Make the calculator applet calculate correct

2013-09-11 Thread Paul Rohrbach
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112674/ --- Review request for Plasma. Description --- This patch should solve bu

Re: Review Request 112674: Bugfix: Make the calculator applet calculate correct

2013-09-11 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112674/#review39846 --- Almost good, two nitpicks inside. applets/calculator/package/

Re: develop app

2013-09-11 Thread Sebastian Kügler
On Wednesday, September 11, 2013 15:23:24 Daniel Kreuter wrote: > Only to virtualbox instances? I would like to be able to push over ssh > directly to my pa device. Also directly onto the device, that's essentially the same. You can switch on SSH access in the Settings / Development screen. Chee

Re: develop app

2013-09-11 Thread Daniel Kreuter
Only to virtualbox instances? I would like to be able to push over ssh directly to my pa device. On Wed, Sep 11, 2013 at 11:25 AM, Marco Martin wrote: > On Tuesday 10 September 2013, nic...@nicoladefilippo.it wrote: >> Hi, >> i read the documentation, good documentation, but maybe fragmented. Wh

Re: Review Request 111863: Feature: Folder Preview in Local Pictures Browsing

2013-09-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111863/ --- (Updated Sept. 11, 2013, 9:50 a.m.) Status -- This change has been ma

Re: Review Request 111863: Feature: Folder Preview in Local Pictures Browsing

2013-09-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111863/#review39803 --- This review has been submitted with commit 2993289315534667e86

Re: develop app

2013-09-11 Thread nicola
Hi, > On Tuesday 10 September 2013, nic...@nicoladefilippo.it wrote: >> Hi, >> i read the documentation, good documentation, but maybe fragmented. >> Which >> is the best solutions to develop of a app (qml and c++) for a wetab? to >> create target in mer sdk, to compile in it and thus to try on t

Re: develop app

2013-09-11 Thread Marco Martin
On Tuesday 10 September 2013, nic...@nicoladefilippo.it wrote: > Hi, > i read the documentation, good documentation, but maybe fragmented. Which > is the best solutions to develop of a app (qml and c++) for a wetab? to > create target in mer sdk, to compile in it and thus to try on the device? >

Review Request 112447: implement the PlasmaView library

2013-09-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112447/ --- Status -- This change has been marked as submitted. Review request fo

Re: Review Request 112447: implement the PlasmaView library

2013-09-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112447/#review39802 --- This review has been submitted with commit 97ada33110fbd02b365

Re: Review Request 112142: QQuick item for live updating window thumbnails

2013-09-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112142/#review39800 --- This review has been submitted with commit 91d306d2e8eb637c300

Re: Review Request 112142: QQuick item for live updating window thumbnails

2013-09-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112142/ --- (Updated Sept. 11, 2013, 7:44 a.m.) Status -- This change has been ma

Re: Review Request 111770: Implemented search feature in Local Browsing.

2013-09-11 Thread Sinny Kumari
> On Sept. 11, 2013, 7:31 a.m., Sinny Kumari wrote: > > One issue > > Suppose I searched for videos folder in search bar. Now, with search filter > > i can see videos folder in mediabrowser. Later when I click on video folder > > to broswe inside then it shows me blank. This is happening becasu

Re: Review Request 111770: Implemented search feature in Local Browsing.

2013-09-11 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111770/#review39798 --- One issue Suppose I searched for videos folder in search bar. N

Re: Review Request 111863: Feature: Folder Preview in Local Pictures Browsing

2013-09-11 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111863/#review39796 --- Ship it! works fine for me - Sinny Kumari On Sept. 11, 2013

Re: Review Request 111863: Feature: Folder Preview in Local Pictures Browsing

2013-09-11 Thread Akshay Ratan
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111863/ --- (Updated Sept. 11, 2013, 7:05 a.m.) Review request for Plasma, Shantanu Tu