Re: Review Request 112105: [1.1] PMC fix for KDE 4.11 - prevent deletion of popped pages from PageStack

2013-08-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112105/ --- (Updated Aug. 16, 2013, 5:41 a.m.) Status -- This change has been mar

Re: Review Request 112105: [1.1] PMC fix for KDE 4.11 - prevent deletion of popped pages from PageStack

2013-08-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112105/#review37914 --- This review has been submitted with commit 23f0363ba442f504e01

Re: Review Request 110216: Rename Screen Locker screensaver KCM to Lock Screen

2013-08-15 Thread Albert Astals Cid
> On April 27, 2013, 2:09 p.m., Marco Martin wrote: > > Ship It! > > Albert Astals Cid wrote: > Janitorial dude question: Has this been commited and you forgot to mark > it as submitted or it does still need submitting? > > > Marco Martin wrote: > should still be committed Want me to

Re: Review Request 110626: Overhaul sunxi kickstart generation into a generic way

2013-08-15 Thread Ben Cooksley
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110626/ --- (Updated Aug. 15, 2013, 10:41 p.m.) Status -- This change has been ma

Re: Review Request 110216: Rename Screen Locker screensaver KCM to Lock Screen

2013-08-15 Thread Marco Martin
> On April 27, 2013, 2:09 p.m., Marco Martin wrote: > > Ship It! > > Albert Astals Cid wrote: > Janitorial dude question: Has this been commited and you forgot to mark > it as submitted or it does still need submitting? > should still be committed - Marco --

Re: Review Request 110626: Overhaul sunxi kickstart generation into a generic way

2013-08-15 Thread Marco Martin
> On May 23, 2013, 9:59 p.m., Marco Martin wrote: > > Ship It! > > Albert Astals Cid wrote: > Janitorial dude question: Has this been commited and you forgot to mark > it as submitted or it does still need submitting? > it can be marked as submitted, yes - Marco ---

Re: Review Request 107908: Fix dismissing LastNotificationPopup often failing

2013-08-15 Thread Albert Astals Cid
> On April 24, 2013, 6:51 p.m., Marco Martin wrote: > > Ship It! Janitorial dude question: Has this been commited and you forgot to mark it as submitted or it does still need submitting? - Albert --- This is an automatically generated

Re: Review Request 110288: Checks if an optional field was instantiated before accessing it

2013-08-15 Thread Albert Astals Cid
> On May 4, 2013, 9:14 a.m., Giorgos Tsiapaliokas wrote: > > The patch is ok, it can go in. > > > > Are you familiar with out git workflow policy? > > > > http://community.kde.org/Plasma/IntegrationBranches/GeneralPolicy > > > > If you have any questions don't hesitate to ask :) Janitorial du

Re: Review Request 110626: Overhaul sunxi kickstart generation into a generic way

2013-08-15 Thread Albert Astals Cid
> On May 23, 2013, 9:59 p.m., Marco Martin wrote: > > Ship It! Janitorial dude question: Has this been commited and you forgot to mark it as submitted or it does still need submitting? - Albert --- This is an automatically generated e-

Re: Review Request 110216: Rename Screen Locker screensaver KCM to Lock Screen

2013-08-15 Thread Albert Astals Cid
> On April 27, 2013, 2:09 p.m., Marco Martin wrote: > > Ship It! Janitorial dude question: Has this been commited and you forgot to mark it as submitted or it does still need submitting? - Albert --- This is an automatically generated

Re: Review Request 108325: LastNotificationPopup fix for closing not to move + add move button + better layout for 3 action buttons

2013-08-15 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108325/ --- (Updated Aug. 15, 2013, 10:03 p.m.) Status -- This change has been di

Re: Review Request 108325: LastNotificationPopup fix for closing not to move + add move button + better layout for 3 action buttons

2013-08-15 Thread Albert Astals Cid
> On April 5, 2013, 4:16 p.m., Albert Astals Cid wrote: > > Can you please attach the diff properly and not give ship its to yourself? > > > > I'd suggest you discard this review that is already broken and start a new > > one where you attach the diff properly and you don't give you a ship it t

Re: Actual width of checkbox element

2013-08-15 Thread Kai Uwe Broulik
Am Donnerstag, 15. August 2013, 22:04:54 schrieb Marco Martin: > On Thursday 15 August 2013, Kai Uwe Broulik wrote: > > > patches welcome ;) > > > > Hmm, when I try to manually set the implicitWidth or route it > > somewhereelse > > it says "implicitWidth not available in QtQuick Item 1.0" (or so)

Re: Actual width of checkbox element

2013-08-15 Thread Marco Martin
On Thursday 15 August 2013, Kai Uwe Broulik wrote: > > patches welcome ;) > > Hmm, when I try to manually set the implicitWidth or route it somewhereelse > it says "implicitWidth not available in QtQuick Item 1.0" (or so). implicitWidth is available only since 1.1, so across the component the imp

Re: Actual width of checkbox element

2013-08-15 Thread Kai Uwe Broulik
> patches welcome ;) Hmm, when I try to manually set the implicitWidth or route it somewhereelse it says "implicitWidth not available in QtQuick Item 1.0" (or so). ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Actual width of checkbox element

2013-08-15 Thread Marco Martin
On Thursday 15 August 2013, Kai Uwe Broulik wrote: > Hi, > > > its implicitWidth should return a proper value (if it doesn't means the > > component should be fixed ;) > > implicitWidth seems to return 0 for the checkbox item. then needs to be fixed... patches welcome ;) -- Marco Martin _

Re: Review Request 112105: [1.1] PMC fix for KDE 4.11 - prevent deletion of popped pages from PageStack

2013-08-15 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112105/#review37872 --- Ship it! Thanks for noticing this issue on KDE 4.11. Works fin

Re: Actual width of checkbox element

2013-08-15 Thread Kai Uwe Broulik
Hi, > its implicitWidth should return a proper value (if it doesn't means the > component should be fixed ;) implicitWidth seems to return 0 for the checkbox item. (If I could've just kept the switch … :P) ___ Plasma-devel mailing list Plasma-devel@

Re: Review Request 112105: [1.1] PMC fix for KDE 4.11 - prevent deletion of popped pages from PageStack

2013-08-15 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112105/#review37870 --- Ship it! meh, i changed it because some reported leaks since t

Review Request 112105: [1.1] PMC fix for KDE 4.11 - prevent deletion of popped pages from PageStack

2013-08-15 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112105/ --- Review request for Plasma. Description --- In KDE 4.11, if you do not

Re: plasma-shell in plasma2

2013-08-15 Thread Heena Mahour
However , the plasmoids appear on the desktop (plasma 2 ) momentary then it shows an output plasma-shell(31515)/default onTriggered: Saved coordinates for ToolBox in config: 992x992 plasma-shell(31515)/default qt_assert: ASSERT: "oldActiveFocusItem" in file items/qquickwindow.cpp, line 735 Aborted

Re: plasma-shell in plasma2

2013-08-15 Thread Heena Mahour
okayy on deleting ~/.config5/plasma-shellrc I got it . On Thu, Aug 15, 2013 at 4:16 PM, Heena Mahour wrote: > export > QT_PLUGIN_PATH=$KF5/lib/plugins:$KF5/lib64/plugins:$KF5/lib/i386-linux-gnu/plugins:$QTDIR/plugins#:$QT_PLUGIN_PATH > export > QML2_IMPORT_PATH=$KF5/lib/qml:$KF5/lib64/qml:$KF5

Re: plasma-shell in plasma2

2013-08-15 Thread Heena Mahour
export QT_PLUGIN_PATH=$KF5/lib/plugins:$KF5/lib64/plugins:$KF5/lib/i386-linux-gnu/plugins:$QTDIR/plugins#:$QT_PLUGIN_PATH export QML2_IMPORT_PATH=$KF5/lib/qml:$KF5/lib64/qml:$KF5/lib/i386-linux-gnu/qml:$QTDIR/qml If I do echo $KF5/lib/plugins then it is giving /opt/kf5/lib/plugins How can I be sure

Re: plasma-shell in plasma2

2013-08-15 Thread Marco Martin
On Thursday 15 August 2013, Heena Mahour wrote: > Hey > > I am getting http://picpaste.com/screen13-GNKwWhEy.png this on > plasma-shell. This is the output on terminal > http://pastebin.com/raw.php?i=zL2fMK8c Could you suggest how I may load > plasmoid in plasma-shell ? > > Regards Q_PLUGIN_PATH

plasma-shell in plasma2

2013-08-15 Thread Heena Mahour
Hey I am getting http://picpaste.com/screen13-GNKwWhEy.png this on plasma-shell. This is the output on terminal http://pastebin.com/raw.php?i=zL2fMK8c Could you suggest how I may load plasmoid in plasma-shell ? Regards -- -Heena Season of kde'12 participant Google Summer of Code 2013 Delhi Col

Re: Actual width of checkbox element

2013-08-15 Thread Marco Martin
On Thursday 15 August 2013, Kai Uwe Broulik wrote: > Hi there, > > I got a bug report [1] about that the popup width might get so small that > the PM checkbox doesn't fit entirely. > Is there a way to determin the actual width of the checkbox including its > label? > So I could do minimumWidth: Ma

Re: Actual width of checkbox element

2013-08-15 Thread Daniel Nicoletti
This is the reason in Apper updater the checkbox doesn't use the text property, instead I have a checkbox with no text and a Text element next to it and eliding right. I don't think you can do it other way as there is no other properties exposed, but I might be wrong... 2013/8/15 Kai Uwe Broulik

Actual width of checkbox element

2013-08-15 Thread Kai Uwe Broulik
Hi there, I got a bug report [1] about that the popup width might get so small that the PM checkbox doesn't fit entirely. Is there a way to determin the actual width of the checkbox including its label? So I could do minimumWidth: Math.max( currentminimumwidth, checkboxwidth) Or should I just us

Re: Review Request 112088: active-about: add new Contributors for PA 4

2013-08-15 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112088/#review37838 --- Ship it! One R(ü|ue)diger has answered, you can commit it. -