Re: Review Request 111465: Use activeFocus for dual state button effect

2013-07-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111465/ --- (Updated July 9, 2013, 2:29 p.m.) Status -- This change has been mark

Re: Review Request 111465: Use activeFocus for dual state button effect

2013-07-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111465/#review35790 --- This review has been submitted with commit 27658911fe611b26ee7

Re: Review Request 111465: Use activeFocus for dual state button effect

2013-07-09 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111465/#review35789 --- Ship it! Ship It! - Sebastian Kügler On July 9, 2013, 2:06

Review Request 111465: Use activeFocus for dual state button effect

2013-07-09 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111465/ --- Review request for Plasma and David Edmundson. Description --- Use ac

Re: FocusScope and Plasma CheckBox

2013-07-09 Thread David Edmundson
I /think/ you want to change the checkbox to monitor activeFocus rather than focus to show the correct highlight. i.e in. plasma/declarativeimports/plasmacomponents/qml/Private/DualStateButton.qml change line 79. -state: (dualButton.enabled && (dualButton.focus || mouseArea.containsMouse)

FocusScope and Plasma CheckBox

2013-07-09 Thread Kai Uwe Broulik
Hi, I'm currently trying to improve (implement at all) keyboard navigation for the battery monitor. It works quite well except that the sliders don't have any visual "has focus" indication. What also gives me trouble is the checkbox. I have code that looks like FocusScope { id: brightnessI