Re: Review Request 111047: Handle edge cases when going back/escape

2013-06-20 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111047/#review34797 --- Ship it! Still whatever I mentioned is broken. For now, I will

Re: Review Request 110701: Make the notes plasmoid change the background color according to the current plasma theme's text color

2013-06-20 Thread Wolfgang Bauer
> On June 20, 2013, 4:59 p.m., Aaron J. Seigo wrote: > > Thank you! But this somehow depends on https://git.reviewboard.kde.org/r/110716/ because the same text color should be used everywhere (either Plasma::Theme::TextColor or Plasma::Theme::ButtonTextColor). Could you have a look at that re

Re: Review Request 110701: Make the notes plasmoid change the background color according to the current plasma theme's text color

2013-06-20 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110701/ --- (Updated June 20, 2013, 8:12 p.m.) Review request for Plasma and Anne-Mari

Re: Review Request 110701: Make the notes plasmoid change the background color according to the current plasma theme's text color

2013-06-20 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110701/#review34778 --- Ship it! applets/notes/notes.cpp

Re: Review Request 110701: Make the notes plasmoid change the background color according to the current plasma theme's text color

2013-06-20 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110701/ --- (Updated June 20, 2013, 4:22 p.m.) Review request for Plasma and Anne-Mari

Re: Review Request 110701: Make the notes plasmoid change the background color according to the current plasma theme's text color

2013-06-20 Thread Wolfgang Bauer
> On June 20, 2013, 2:13 p.m., Aaron J. Seigo wrote: > > instead of this common idiom over and over (which also introduces the same > > strings repeatedly, which means changes in future need to be made in > > several places): > > > > textIsBright() ? "black" : "yellow" > > > > why not cha

Re: Review Request 109773: New runner that translates words and sentences via Google Translate.

2013-06-20 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109773/ --- (Updated June 20, 2013, 1:06 p.m.) Status -- This change has been mar

Re: Review Request 111047: Handle edge cases when going back/escape

2013-06-20 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111047/ --- (Updated June 20, 2013, 12:19 p.m.) Review request for Plasma, Akshay Rata

Re: Review Request 110701: Make the notes plasmoid change the background color according to the current plasma theme's text color

2013-06-20 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110701/#review34750 --- instead of this common idiom over and over (which also introduc

Review Request 110701: Make the notes plasmoid change the background color according to the current plasma theme's text color

2013-06-20 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110701/ --- Review request for Plasma and Anne-Marie Mahfouf. Description --- The

Re: Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel

2013-06-20 Thread Sebastian Kügler
On Thursday, June 20, 2013 08:57:17 Kai Uwe Broulik wrote: > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/48/ > --- > > Review

Re: Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel

2013-06-20 Thread Marco Martin
> On June 20, 2013, 9:20 a.m., Aaron J. Seigo wrote: > > plasma/declarativeimports/core/datamodel.h, line 94 > > > > > > is this necessary, given that there is a setSortCaseSensitivity in the > > parent class? >

Re: Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel

2013-06-20 Thread Marco Martin
> On June 20, 2013, 9:20 a.m., Aaron J. Seigo wrote: > > plasma/declarativeimports/core/datamodel.h, line 94 > > > > > > is this necessary, given that there is a setSortCaseSensitivity in the > > parent class? yo

Re: Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel

2013-06-20 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/48/ --- (Updated June 20, 2013, 9:41 a.m.) Review request for Plasma. Changes --

Re: Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel

2013-06-20 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/48/#review34738 --- plasma/declarativeimports/core/datamodel.h

Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel

2013-06-20 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/48/ --- Review request for Plasma. Description --- This adds support for the